Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload to R2 to pr-build workflow #1763

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Conversation

andres-spacemesh
Copy link
Collaborator

No description provided.

@brusherru
Copy link
Member

Shouldn't it replace uploading to GCP?
Btw, it is failing...

Copy link

Compiled Binaries

Copy link

Compiled Binaries

@brusherru
Copy link
Member

@andres-spacemesh shouldn't we remove these lines?
https://github.com/spacemeshos/smapp/pull/1763/files#diff-404033996c34f9971e0c112d8538b9063618fc85059a44df7d4db448974888caR228-R267

@andres-spacemesh
Copy link
Collaborator Author

Uploading on both CF and GCP for now. Eventually it'll be removed

Copy link
Member

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brusherru brusherru merged commit f3070ad into develop Jul 23, 2024
8 checks passed
@brusherru brusherru deleted the upload-to-r2-pr-build branch July 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants