Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge config deeply #1418

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Merge config deeply #1418

wants to merge 4 commits into from

Conversation

brusherru
Copy link
Member

It closes #1407

@brusherru brusherru self-assigned this Aug 1, 2023
@brusherru
Copy link
Member Author

Ouch, forgot about these tests. Need to update them.

monikasmolarek
monikasmolarek approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@monikasmolarek monikasmolarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remember about the failing tests, but the core question seems to be working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monikasmolarek monikasmolarek monikasmolarek approved these changes

@pigmej pigmej Awaiting requested review from pigmej

@maparr maparr Awaiting requested review from maparr

Assignees

@brusherru brusherru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge node config and custom config deeply
2 participants
@brusherru @monikasmolarek