Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display drained amounts next to Drain Transaction #108

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

brusherru
Copy link
Member

No issue.

Here are examples, how it looks like:

  1. Vault account.
    All drain txs there displayed with the negative sign, because it drains out money from it.
    image

  2. Vesting account (which is the owner of the vault).
    Some drain txs there might be marked as "incoming" (with positive green amount), which is actually drained to the same vesting account.
    And some drain txs marked as "outgoing" (with negative red amount), which were drained to some third-party accounts.
    image

  3. Another account, that has incoming drain txs.
    image

Copy link

You can preview the changes at : https://ec2e6c61.smapp-lite-prod.pages.dev

Copy link
Collaborator

@monikasmolarek monikasmolarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not currently have any vesting/vault account to test it manually, but from the code perspective it seems ok.

@brusherru brusherru merged commit 4adb800 into main Oct 28, 2024
1 check passed
@brusherru brusherru deleted the tweak-drain-tx-ui branch October 28, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants