Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Avoid global logger in events #6258

Closed
wants to merge 3 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Aug 14, 2024

Motivation

Follow up to this discussion: #6252 (comment)

Removal of the global logger from (most of) the event package.

Description

This removes the global logger from most of the reporter.go file and removes a few other usages of the log package that are not needed any more.

Test Plan

  • existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 49.74874% with 100 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (477fdbc) to head (4781587).
Report is 5 commits behind head on develop.

Files Patch % Lines
events/reporter.go 73.7% 12 Missing and 4 partials ⚠️
mesh/mesh.go 18.7% 8 Missing and 5 partials ⚠️
api/grpcserver/globalstate_service.go 52.3% 5 Missing and 5 partials ⚠️
api/grpcserver/mesh_service.go 58.3% 7 Missing and 3 partials ⚠️
txs/conservative_state.go 0.0% 8 Missing and 2 partials ⚠️
api/grpcserver/transaction_service.go 36.3% 5 Missing and 2 partials ⚠️
genvm/vm.go 0.0% 5 Missing and 2 partials ⚠️
activation/handler_v1.go 0.0% 5 Missing and 1 partial ⚠️
activation/handler_v2.go 0.0% 5 Missing and 1 partial ⚠️
api/grpcserver/node_service.go 50.0% 2 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6258     +/-   ##
=========================================
- Coverage     82.1%   82.0%   -0.1%     
=========================================
  Files          308     307      -1     
  Lines        34087   34095      +8     
=========================================
- Hits         27992   27978     -14     
- Misses        4326    4336     +10     
- Partials      1769    1781     +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member Author

fasmat commented Aug 16, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 16, 2024
## Motivation

Follow up to this discussion: #6252 (comment)

Removal of the global logger from (most of) the event package.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Aug 16, 2024

flaky test: #6113

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 16, 2024
## Motivation

Follow up to this discussion: #6252 (comment)

Removal of the global logger from (most of) the event package.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Avoid global logger in events [Merged by Bors] - Avoid global logger in events Aug 16, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 16, 2024
@spacemesh-bors spacemesh-bors bot deleted the avoid-global-logger-events branch August 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants