Flaky Test_GetAtxsLimiting

[fasmat]

Description

Test failed in a PR without code changes

Affected code

Test_GetAtxsLimiting seems to be unstable a least on slower runners. Example CI run: https://github.com/spacemeshos/go-spacemesh/actions/runs/9870385946/job/27256024600 from PR #6088

=== Failed
=== FAIL: fetch Test_GetAtxsLimiting/with_limiting:_true (1.53s)
    logger.go:146: 2024-07-10T08:19:18.680Z	INFO	initialized datastore	{"config": {"ATXSize":1000,"MalfeasanceSize":1000}}
    mesh_data_test.go:851: 
        	Error Trace:	/Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:851
        	            				/Users/runner/work/go-spacemesh/go-spacemesh/p2p/server/server.go:540
        	            				/Users/runner/work/go-spacemesh/go-spacemesh/p2p/server/server.go:330
        	            				/Users/runner/work/go-spacemesh/go-spacemesh/p2p/server/server.go:273
        	            				/Users/runner/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78
        	            				/Users/runner/hostedtoolcache/go/1.22.5/x64/src/runtime/asm_amd64.s:1695
        	Error:      	"[{ATXDB [34 201 27 111 224 242 238 73 5 45 173 228 236 30 223 188 70 142 136 220 11 127 6 253 218 103 233 112 224 0 226 171]} {ATXDB [4 73 198 36 120 194 224 190 102 109 247 211 179 78 150 236 116 188 126 228 249 73 107 119 34 227 116 154 65 90 162 9]} {ATXDB [29 168 4 121 252 37 180 116 6 195 121 120 65 43 240 5 248 172 219 31 15 97 221 129 26 192 65 70 57 62 52 255]}]" should have 10 item(s), but has 3
        	Test:       	Test_GetAtxsLimiting/with_limiting:_true
    mesh_data_test.go:851: 
        	Error Trace:	/Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:851
        	            				/Users/runner/work/go-spacemesh/go-spacemesh/p2p/server/server.go:540
        	            				/Users/runner/work/go-spacemesh/go-spacemesh/p2p/server/server.go:330
        	            				/Users/runner/work/go-spacemesh/go-spacemesh/p2p/server/server.go:273
        	            				/Users/runner/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78
        	            				/Users/runner/hostedtoolcache/go/1.22.5/x64/src/runtime/asm_amd64.s:1695
        	Error:      	"[{ATXDB [126 67 193 128 11 81 28 73 59 68 202 188 95 74 88 187 169 105 136 155 218 211 179 117 235 165 16 161 89 146 30 42]} {ATXDB [182 200 126 251 34 161 189 181 178 105 70 60 96 23 169 138 104 26 35 168 235 164 226 15 140 39 197 188 226 254 241 116]} {ATXDB [33 9 234 136 35 20 8 115 32 42 99 187 57 145 247 141 233 175 98 45 113 127 166 133 88 83 174 9 215 115 97 230]} {ATXDB [245 152 136 246 171 34 84 78 217 119 16 51 14 123 103 50 72 141 242 93 196 144 48 38 240 217 47 129 68 60 75 160]} {ATXDB [123 218 4 173 98 210 13 165 51 6 208 31 187 103 232 229 121 0 36 54 61 173 27 247 173 225 7 87 1 71 173 154]} {ATXDB [180 120 182 56 165 118 194 206 129 145 92 69 119 231 153 228 248 57 42 61 216 200 60 205 165 48 230 146 197 162 178 14]} {ATXDB [63 83 185 181 84 44 241 16 138 246 92 153 183 148 250 170 237 2 243 89 242 162 178 118 114 185 210 78 229 188 135 81]}]" should have 10 item(s), but has 7
        	Test:       	Test_GetAtxsLimiting/with_limiting:_true
    mesh_data_test.go:911: 
        	Error Trace:	/Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:911
        	Error:      	Received unexpected error:
        	            	batch failure: f59888f6ab=EOF7bda04ad62=EOF2109ea8823=EOF3f53b9b554=EOFb6c87efb22=EOF0449c62478=EOF1da80479fc=EOF7e43c1800b=EOFb478b638a5=EOF22c91b6fe0=EOF
        	Test:       	Test_GetAtxsLimiting/with_limiting:_true
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [34 201 27 111 224 242 238 73 5 45 173 228 236 30 223 188 70 142 136 220 11 127 6 253 218 103 233 112 224 0 226 171] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [29 168 4 121 252 37 180 116 6 195 121 120 65 43 240 5 248 172 219 31 15 97 221 129 26 192 65 70 57 62 52 255] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [4 73 198 36 120 194 224 190 102 109 247 211 179 78 150 236 116 188 126 228 249 73 107 119 34 227 116 154 65 90 162 9] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [126 67 193 128 11 81 28 73 59 68 202 188 95 74 88 187 169 105 136 155 218 211 179 117 235 165 16 161 89 146 30 42] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [33 9 234 136 35 20 8 115 32 42 99 187 57 145 247 141 233 175 98 45 113 127 166 133 88 83 174 9 215 115 97 230] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [182 200 126 251 34 161 189 181 178 105 70 60 96 23 169 138 104 26 35 168 235 164 226 15 140 39 197 188 226 254 241 116] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [245 152 136 246 171 34 84 78 217 119 16 51 14 123 103 50 72 141 242 93 196 144 48 38 240 217 47 129 68 60 75 160] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [123 218 4 173 98 210 13 165 51 6 208 31 187 103 232 229 121 0 36 54 61 173 27 247 173 225 7 87 1 71 173 154] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [180 120 182 56 165 118 194 206 129 145 92 69 119 231 153 228 248 57 42 61 216 200 60 205 165 48 230 146 197 162 178 14] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: missing call(s) to *mocks.MockSyncValidator.HandleMessage(is anything, is equal to [63 83 185 181 84 44 241 16 138 246 92 153 183 148 250 170 237 2 243 89 242 162 178 118 114 185 210 78 229 188 135 81] (types.Hash32), is equal to QmetwNZw52wtRrDY1hqGx8s8Zxw9aneuBHvhzs4Nr4R2H2 (peer.ID), is anything) /Users/runner/work/go-spacemesh/go-spacemesh/fetch/mesh_data_test.go:903
    controller.go:98: aborting test due to missing call(s)

=== FAIL: fetch Test_GetAtxsLimiting (1.73s)