Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release workflow details #4

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Change release workflow details #4

merged 2 commits into from
Sep 19, 2023

Conversation

eminalemdar
Copy link
Contributor

I've updated the release workflow for the required migration from go1.x runtime version for Lambda to the provided.al2 runtime.

Copy link
Contributor

@marcinwyszynski marcinwyszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@marcinwyszynski
Copy link
Contributor

TBH I'm confused. The PR description does not correspond to the change, and the change doesn't make much sense to me. Please elaborate.

@eminalemdar
Copy link
Contributor Author

TBH I'm confused. The PR description does not correspond to the change, and the change doesn't make much sense to me. Please elaborate.

@marcinwyszynski go1.x runtime version will be deprecated at the end of the year with the end-of-life of Amazon Linux 1 and AWS recommends using the provided.al2 runtime version. There is a migration path blog for this change and provided.al2 requires the handler and the binary name to be bootstrap

@marcinwyszynski
Copy link
Contributor

OK but the IaC definitions (including runtime) are unchanged, only the release artifact name. That's very unlikely to work as-is.

@eminalemdar
Copy link
Contributor Author

OK but the IaC definitions (including runtime) are unchanged, only the release artifact name. That's very unlikely to work as-is.

that's correct! we are implementing the IaC definitions in the workerpool repository separately. But I can change the definitions here as well if that's needed.

@eminalemdar eminalemdar merged commit 119e501 into main Sep 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants