Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media metadata extraction & Thumbnailer rework #2285

Merged
merged 62 commits into from
May 9, 2024
Merged

Media metadata extraction & Thumbnailer rework #2285

merged 62 commits into from
May 9, 2024

Commits on May 2, 2024

  1. initial ffprobe commit

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b49b7db View commit details
    Browse the repository at this point in the history

  2. Working slim down version ffprobe

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    632ef47 View commit details
    Browse the repository at this point in the history

  3. Auto format ffprobe and deps source

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ecd58f1 View commit details
    Browse the repository at this point in the history

  4. Remove show_pixel_formats logic 

    - Fix do_bitexact incorrect check in main after last changes
- Fix some clangd warning
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4e24b23 View commit details
    Browse the repository at this point in the history

  5. Remove show_* and print_format options and their respective logic

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    fafdb97 View commit details
    Browse the repository at this point in the history

  6. Rework ffprobe into simple_ffprobe 

    - Simplify ffprobe logic into a simple program that gather and print a media file metadata
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    946c263 View commit details
    Browse the repository at this point in the history

  7. Reduce the amount of ffmpeg log messages while generating thumbnails

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a8e43fa View commit details
    Browse the repository at this point in the history

  8. Fix completly wrong comments

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9b36d5c View commit details
    Browse the repository at this point in the history

  9. mend

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7da23b4 View commit details
    Browse the repository at this point in the history

  10. Start modeling ffmpeg extracted metadata on schema 

     - Start porting ffprobe code to rust
 - Rename some references to media_data to exif_data
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f8072d5 View commit details
    Browse the repository at this point in the history

  11. Finish modeling media info data 

     - Add MediaProgram, MediaStream, MediaCodec, MediaVideoProps, MediaAudioProps, MediaSubtitleProps to Schema
 - Fix simple_ffproble to use its custom print_codec, instead of ffmpeg's impl
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ef9252c View commit details
    Browse the repository at this point in the history

  12. Add relation between MediaInfo and FilePath 

     - Remove shared properties from MediaInfo and related structs
 - Implement Iterator for FFmpegDict
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d477908 View commit details
    Browse the repository at this point in the history

  13. Fix and update schema

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b5aa5ae View commit details
    Browse the repository at this point in the history

  14. Data models and start populating MediaInfo in rust

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    55f0e7f View commit details
    Browse the repository at this point in the history

  15. Finish populating media info, chapters and program

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d2bf7c4 View commit details
    Browse the repository at this point in the history

  16. Improve FFmpegFormatContext data raw pointer access 

     - Implement stream data gathering
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6dfc0b6 View commit details
    Browse the repository at this point in the history

  17. Impl FFmpegCodecContext, retrieve codec information 

     - Improve some unsafe pointer uses
 - Impl from FFmpegFormatContext to MediaInfo conversion
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6c333ca View commit details
    Browse the repository at this point in the history

  18. Fix FFmpegDict Drop

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    22600fe View commit details
    Browse the repository at this point in the history

  19. Fix some crago warnings

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    36ddcbf View commit details
    Browse the repository at this point in the history

  20. Impl retrieval of video props 

     - Fix C char* to Rust String convertion
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    760d753 View commit details
    Browse the repository at this point in the history

  21. Impl retrieval of audio and subtitle props 

     - Fill props for MediaCodec
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b78cc18 View commit details
    Browse the repository at this point in the history

  22. Remove simple_ffprobe now that the Rust impl is done

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b0b39b9 View commit details
    Browse the repository at this point in the history

  23. Fix schema to match actually retrieved media info 

     - Fix import some FFmpeg constants instead of directly using values
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    032ae9d View commit details
    Browse the repository at this point in the history

  24. Rework movie_decoder 

     - Re-implement create_scale_string and add support anamorphic video
 - Improve C pointer access for FFmpegFormatContext and FFmpegCodecContext
 - Use newer FFmpeg abstractions in movie_decoder
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1cc6b40 View commit details
    Browse the repository at this point in the history

  25. Fix incorrect props when initializing MovieDecoder

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d4912bc View commit details
    Browse the repository at this point in the history

  26. Remove unecessary lifetimes

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    023b5f1 View commit details
    Browse the repository at this point in the history

  27. Added more native wrappers for some FFmpeg native objects used in mov… 

    …ie_decoder
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c7dbb61 View commit details
    Browse the repository at this point in the history

  28. Remove FFmpegPacket 

     - Some more improvements to movie_decoder
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6ad2818 View commit details
    Browse the repository at this point in the history

  29. WIP

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4c7ff12 View commit details
    Browse the repository at this point in the history

  30. Some small fixes

    @fogodev @HeavenVolkoff
    fogodev authored and HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2bbf983 View commit details
    Browse the repository at this point in the history

  31. More fixes 

    Rename movie_decoder to frame_decoder
Remove more references to film_strips
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a31cdfc View commit details
    Browse the repository at this point in the history

  32. fmt

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    79e39f6 View commit details
    Browse the repository at this point in the history

  33. Fix duplicate migration for job error changes

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b37e726 View commit details
    Browse the repository at this point in the history

  34. fix rebase

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1ae2200 View commit details
    Browse the repository at this point in the history

  35. Solving segfaults, fuck C lang 

    Co-authored-by: Vítor Vasconcellos <[email protected]>
    @fogodev @HeavenVolkoff
    fogodev and HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    789b806 View commit details
    Browse the repository at this point in the history

  36. Update rust to version 1.77 

     - Pin rust version with rust-toolchain.toml
 - Change from dtolnay/rust-toolchain to IronCoreLabs/rust-toolchain for rust-toolchain support
 - Remove unused function and imports
 - Replace most CString uses with new c literal string
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9feeb5a View commit details
    Browse the repository at this point in the history

  37. More segfault solving and other minor fixes 

    Co-authored-by: Vítor Vasconcellos <[email protected]>
    @fogodev @HeavenVolkoff
    fogodev and HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    872592a View commit details
    Browse the repository at this point in the history

  38. Fix ffmpeg rotation filter breaking portrait video thumbnails #2150 

     - Plus some other misc fixes
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6cc38f7 View commit details
    Browse the repository at this point in the history

  39. Auto format

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4e1f9af View commit details
    Browse the repository at this point in the history

  40. Retrieve video/audio metadata on frontend

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ece7c27 View commit details
    Browse the repository at this point in the history

  41. Auto format

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ec8dade View commit details
    Browse the repository at this point in the history

  42. First draft on ffmpeg data save on db 

    Co-authored-by: Vítor Vasconcellos <[email protected]>
    @fogodev @HeavenVolkoff
    fogodev and HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    43e1cd0 View commit details
    Browse the repository at this point in the history

  43. Fix some incorrect changes to prisma schema

    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3d778cb View commit details
    Browse the repository at this point in the history

  44. Some fixes for the FFmpegData schema 

     - Expand logic to save FFmpegData to db
    @HeavenVolkoff
    HeavenVolkoff committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9cdfef5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. A ton of things 

    Co-authored-by: Vítor Vasconcellos <[email protected]>
    @fogodev @HeavenVolkoff
    fogodev and HeavenVolkoff committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8dcc602 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Integrating ffmpeg media data in jobs and API

    @fogodev
    fogodev committed May 4, 2024
    Configuration menu
    Copy the full SHA
    b0d9653 View commit details
    Browse the repository at this point in the history

  2. Rspc can't BigInt

    @fogodev
    fogodev committed May 4, 2024
    Configuration menu
    Copy the full SHA
    dd28578 View commit details
    Browse the repository at this point in the history

  3. 🙄

    @fogodev
    fogodev committed May 4, 2024
    Configuration menu
    Copy the full SHA
    8e1ebe8 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add initial ffmpeg metadata entries to Inspector 

     - Fix ephemeral metadata api to match the files metadata api call
    @HeavenVolkoff
    HeavenVolkoff committed May 7, 2024
    Configuration menu
    Copy the full SHA
    56885ff View commit details
    Browse the repository at this point in the history

  2. Fix Inspector not showing ffmpeg metadata

    @HeavenVolkoff
    HeavenVolkoff committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0fd9b04 View commit details
    Browse the repository at this point in the history

  3. Add bitrate, start time and chapters video metadata to Inspector 

    - Fix backend BigInt conversion incorrectly using i32 instead of u32
- Change FFmpegFormatContext/FFmpegMetaData bit_rate to i64
- Rename byteSize to humanizeSize
- Expand humanizeSize logic to allow handling bits and Binary units
- Move capitalize to @sd/client utils
    @HeavenVolkoff
    HeavenVolkoff committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2e558d1 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Solving some issues

    @fogodev
    fogodev committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e03f158 View commit details
    Browse the repository at this point in the history

  2. Fix ffmpeg probe getting incorrect stream id and breaking database un… 

    …ique constraint

 - Fix humanizeSize breaking when receiving floating numbers
 - Fix incorrect equality in StatCard
 - Fix unhandled error in Dialog when trying to remove an unknown dialog
    @HeavenVolkoff
    HeavenVolkoff committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6d81b47 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into eng-949-collect-video… 

    …-duration
    @HeavenVolkoff
    HeavenVolkoff committed May 8, 2024
    Configuration menu
    Copy the full SHA
    91c5ba5 View commit details
    Browse the repository at this point in the history

  4. fmt

    @HeavenVolkoff
    HeavenVolkoff committed May 8, 2024
    Configuration menu
    Copy the full SHA
    05798dc View commit details
    Browse the repository at this point in the history

  5. small improvements 

     - Remove some unecessary recursion_limit directive
 - Remove unused app_image releated functions
 - Fix metadata query enabled flag
    @HeavenVolkoff
    HeavenVolkoff committed May 8, 2024
    Configuration menu
    Copy the full SHA
    329651d View commit details
    Browse the repository at this point in the history

  6. Add migration for ffmpeg media data

    @HeavenVolkoff
    HeavenVolkoff committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3d07979 View commit details
    Browse the repository at this point in the history

  7. Fix cypress test

    @HeavenVolkoff
    HeavenVolkoff committed May 8, 2024
    Configuration menu
    Copy the full SHA
    914da98 View commit details
    Browse the repository at this point in the history

  8. Requested changes

    @fogodev
    fogodev committed May 8, 2024
    Configuration menu
    Copy the full SHA
    82f6c5e View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' of github.com:spacedriveapp/spacedrive into eng-9… 

    …49-collect-video-duration
    @fogodev
    fogodev committed May 8, 2024
    Configuration menu
    Copy the full SHA
    80355e1 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Implement feedback 

     - Update locale keys for all languages
 - Add pnpm command to update all language keys
    @HeavenVolkoff
    HeavenVolkoff committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6451a78 View commit details
    Browse the repository at this point in the history

  2. Fix thumb reactivity in non indexed locations

    @HeavenVolkoff
    HeavenVolkoff committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f043ae4 View commit details
    Browse the repository at this point in the history