Update toolchain and fix a bunch of warnings

core/Cargo.toml

@@ -30,7 +30,6 @@ sd-core-sync             = { path = "./crates/sync" }
 # Spacedrive Sub-crates
 sd-actors         = { path = "../crates/actors" }
 sd-ai             = { path = "../crates/ai", optional = true }
-sd-cloud-api      = { path = "../crates/cloud-api" }
 sd-crypto         = { path = "../crates/crypto" }
 sd-ffmpeg         = { path = "../crates/ffmpeg", optional = true }
 sd-file-ext       = { path = "../crates/file-ext" }

core/crates/cloud-services/src/client.rs

@@ -18,7 +18,7 @@ use super::{
 	error::Error, key_manager::KeyManager, p2p::CloudP2P, token_refresher::TokenRefresher,
 };
 
-#[derive(Debug, Default)]
+#[derive(Debug, Default, Clone)]
 enum ClientState {
 	#[default]
 	NotConnected,
@@ -190,7 +190,8 @@ impl CloudServices {
 						_message: &[u8],
 						_cert: &rustls::pki_types::CertificateDer<'_>,
 						_dss: &rustls::DigitallySignedStruct,
-					) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error> {
+					) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error>
+					{
 						Ok(rustls::client::danger::HandshakeSignatureValid::assertion())
 					}
 
@@ -199,7 +200,8 @@ impl CloudServices {
 						_message: &[u8],
 						_cert: &rustls::pki_types::CertificateDer<'_>,
 						_dss: &rustls::DigitallySignedStruct,
-					) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error> {
+					) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error>
+					{
 						Ok(rustls::client::danger::HandshakeSignatureValid::assertion())
 					}
 
@@ -268,8 +270,8 @@ impl CloudServices {
 	/// Available routes documented in
 	/// [`sd_cloud_schema::Service`](https://github.com/spacedriveapp/cloud-services-schema).
 	pub async fn client(&self) -> Result<Client<QuinnConnection<Service>, Service>, Error> {
-		if let ClientState::Connected(client) = &*self.client_state.read().await {
-			return Ok(client.clone());
+		if let ClientState::Connected(client) = { self.client_state.read().await.clone() } {
+			return Ok(client);
 		}
 
 		// If we're not connected, we need to try to connect.

core/crates/cloud-services/src/key_manager/key_store.rs

@@ -33,7 +33,7 @@ pub struct KeyStore {
 }
 
 impl KeyStore {
-	pub fn new(iroh_secret_key: IrohSecretKey) -> Self {
+	pub const fn new(iroh_secret_key: IrohSecretKey) -> Self {
 		Self {
 			iroh_secret_key,
 			keys: BTreeMap::new(),

core/crates/cloud-services/src/sync/ingest.rs

@@ -82,7 +82,7 @@ enum IngestStatus {
 }
 
 impl Ingester {
-	pub fn new(
+	pub const  fn new(
 		sync: SyncManager,
 		ingest_notify: Arc<Notify>,
 		active: Arc<AtomicBool>,

core/crates/heavy-lifting/src/job_system/report.rs

@@ -402,7 +402,7 @@ impl ReportBuilder {
 	}
 
 	#[must_use]
-	pub fn new(id: JobId, name: JobName) -> Self {
+	pub const fn new(id: JobId, name: JobName) -> Self {
 		Self {
 			id,
 			name,

core/src/library/statistics.rs

@@ -47,7 +47,7 @@ pub async fn update_library_statistics(
 		node.config
 			.data_directory()
 			.join("libraries")
-			.join(&format!("{}.db", library.id)),
+			.join(format!("{}.db", library.id)),
 	)
 	.await
 	.unwrap_or(0);

core/src/location/manager/watcher/mod.rs

@@ -67,6 +67,8 @@ type Handler = ios::EventHandler;
 pub(super) type IgnorePath = (PathBuf, bool);
 
 type INode = u64;
+
+#[cfg(any(target_os = "ios", target_os = "macos", target_os = "windows"))]
 type InstantAndPath = (Instant, PathBuf);
 
 const ONE_SECOND: Duration = Duration::from_secs(1);

crates/actors/src/lib.rs

@@ -169,7 +169,8 @@ impl<Id: ActorId> ActorsCollection<Id> {
 
 	#[instrument(skip(self))]
 	pub async fn start(&self, identifier: Id) {
-		if let Some(actor) = self.actors_map.write().await.get_mut(&identifier) {
+		let mut actors_map  = self.actors_map.write().await;
+		if let Some(actor) = actors_map.get_mut(&identifier) {
 			if actor.is_running.load(Ordering::Acquire) {
 				warn!("Actor already running!");
 				return;
@@ -223,7 +224,8 @@ impl<Id: ActorId> ActorsCollection<Id> {
 
 	#[instrument(skip(self))]
 	pub async fn stop(&self, identifier: Id) {
-		if let Some(actor) = self.actors_map.write().await.get_mut(&identifier) {
+		let mut actors_map = self.actors_map.write().await;
+		if let Some(actor) = actors_map.get_mut(&identifier) {
 			if !actor.is_running.load(Ordering::Acquire) {
 				warn!("Actor already stopped!");
 				return;