Media metadata extraction & Thumbnailer rework #8959
HeavenVolkoffci.yml
on: pull_request
TypeScript
1m 31s
ESLint
2m 24s
Cypress
19m 20s
Rust Formatting
9m 41s
Matrix: clippy
Annotations
22 warnings
|
ESLint:
interface/app/$libraryId/Explorer/View/MediaView/index.tsx#L165
React Hook useMemo has a missing dependency: 'dateFormat'. Either include it or remove the dependency array
|
|
ESLint:
interface/app/$libraryId/Explorer/View/ViewItem.tsx#L194
React Hook useCallback has a missing dependency: 't'. Either include it or remove the dependency array
|
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:90:2
|
90 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L794
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:794:10
|
794 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L881
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:881:25
|
881 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L882
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:882:10
|
882 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L1086
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:1086:10
|
1086 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
casting `i64` to `u32` may lose the sign of the value:
crates/media-metadata/src/ffmpeg/mod.rs#L76
warning: casting `i64` to `u32` may lose the sign of the value
--> crates/media-metadata/src/ffmpeg/mod.rs:76:8
|
76 | ((duration >> 32) as u32, duration as u32)
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
note: the lint level is defined here
--> crates/media-metadata/src/lib.rs:22:2
|
22 | clippy::cast_sign_loss,
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:90:2
|
90 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
casting `i64` to `u32` may lose the sign of the value:
crates/media-metadata/src/ffmpeg/mod.rs#L76
warning: casting `i64` to `u32` may lose the sign of the value
--> crates/media-metadata/src/ffmpeg/mod.rs:76:8
|
76 | ((duration >> 32) as u32, duration as u32)
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
note: the lint level is defined here
--> crates/media-metadata/src/lib.rs:22:2
|
22 | clippy::cast_sign_loss,
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
casting `i64` to `u32` may lose the sign of the value:
crates/media-metadata/src/ffmpeg/mod.rs#L76
warning: casting `i64` to `u32` may lose the sign of the value
--> crates/media-metadata/src/ffmpeg/mod.rs:76:33
|
76 | ((duration >> 32) as u32, duration as u32)
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
|
|
casting `i64` to `u32` may lose the sign of the value:
crates/media-metadata/src/ffmpeg/mod.rs#L83
warning: casting `i64` to `u32` may lose the sign of the value
--> crates/media-metadata/src/ffmpeg/mod.rs:83:8
|
83 | ((start_time >> 32) as u32, start_time as u32)
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
|
|
casting `i64` to `u32` may lose the sign of the value:
crates/media-metadata/src/ffmpeg/mod.rs#L83
warning: casting `i64` to `u32` may lose the sign of the value
--> crates/media-metadata/src/ffmpeg/mod.rs:83:35
|
83 | ((start_time >> 32) as u32, start_time as u32)
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
|
|
casting `i64` to `u32` may lose the sign of the value:
crates/media-metadata/src/ffmpeg/mod.rs#L90
warning: casting `i64` to `u32` may lose the sign of the value
--> crates/media-metadata/src/ffmpeg/mod.rs:90:8
|
90 | ((bit_rate >> 32) as u32, bit_rate as u32)
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
cypress-videos
Expired
|
1.59 MB |
|