Skip to content

Remove normalised cache #8743

Remove normalised cache

Remove normalised cache #8743

Triggered via pull request April 26, 2024 08:00
Status Success
Total duration 34m 37s
Artifacts 1

ci.yml

on: pull_request
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

23 warnings
ESLint: apps/mobile/src/screens/browse/Tags.tsx#L27
The 'tagData' logical expression could make the dependencies of useMemo Hook (at line 35) change on every render. To fix this, wrap the initialization of 'tagData' in its own useMemo() Hook
ESLint: interface/app/$libraryId/tag/$id.tsx#L33
React Hook useMemo has a missing dependency: 'tag'. Either include it or remove the dependency array
ESLint: interface/app/$libraryId/tag/$id.tsx#L33
React Hook useMemo has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method: crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method --> crates/sync/src/compressed.rs:90:2 | 90 | pub fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:372:21 | 372 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
large size difference between variants: core/crates/heavy-lifting/src/file_identifier/tasks/extract_file_metadata.rs#L106
warning: large size difference between variants --> core/crates/heavy-lifting/src/file_identifier/tasks/extract_file_metadata.rs:106:3 | 106 | / enum StreamMessage { 107 | | Processed(Uuid, Result<FileMetadata, FileIOError>), | | -------------------------------------------------- the largest variant contains at least 224 bytes 108 | | Interrupt(InterruptionKind), | | --------------------------- the second-largest variant contains at least 1 bytes 109 | | } | |_________^ the entire enum is at least 224 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:5:2 | 5 | clippy::perf, | ^^^^^^^^^^^^ = note: `#[warn(clippy::large_enum_variant)]` implied by `#[warn(clippy::perf)]` help: consider boxing the large fields to reduce the total size of the enum | 107 | Processed(Uuid, Box<Result<FileMetadata, FileIOError>>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L794
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:794:10 | 794 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:9:2 | 9 | clippy::nursery, | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L881
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:881:25 | 881 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L882
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:882:10 | 882 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L1086
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:1086:10 | 1086 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method: crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method --> crates/sync/src/compressed.rs:90:2 | 90 | pub fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:372:21 | 372 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L794
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:794:10 | 794 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:9:2 | 9 | clippy::nursery, | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L881
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:881:25 | 881 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L882
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:882:10 | 882 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L1086
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:1086:10 | 1086 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
unused import: `sd_core_indexer_rules::seed::no_hidden`: core/src/api/search/mod.rs#L9
warning: unused import: `sd_core_indexer_rules::seed::no_hidden` --> core/src/api/search/mod.rs:9:5 | 9 | use sd_core_indexer_rules::seed::no_hidden; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

Artifacts

Produced during runtime
Name Size
cypress-videos Expired
1.68 MB