Skip to content

CI

CI #8710

Triggered via merge group April 25, 2024 16:26
Status Success
Total duration 27m 1s
Artifacts 1

ci.yml

on: merge_group
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
Clippy (macos-14)
The process '/opt/homebrew/bin/git' failed with exit code 128
using `clone` on type `u16` which implements the `Copy` trait: crates/sync/src/compressed.rs#L26
warning: using `clone` on type `u16` which implements the `Copy` trait --> crates/sync/src/compressed.rs:26:23 | 26 | let mut model_str = first.model.clone(); | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `first.model` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default
using `clone` on type `u16` which implements the `Copy` trait: crates/sync/src/compressed.rs#L39
warning: using `clone` on type `u16` which implements the `Copy` trait --> crates/sync/src/compressed.rs:39:40 | 39 | std::mem::replace(&mut model_str, op.model.clone()), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `clone` on type `u16` which implements the `Copy` trait: crates/sync/src/compressed.rs#L52
warning: using `clone` on type `u16` which implements the `Copy` trait --> crates/sync/src/compressed.rs:52:40 | 52 | std::mem::replace(&mut model_str, op.model.clone()), | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: crates/sync/src/compressed.rs#L76
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> crates/sync/src/compressed.rs:76:6 | 76 | / ops.first() 77 | | .and_then(|op| Some((*instance, *model, record, op))) | |_____________________________________________________________________________^ help: try: `ops.first().map(|op| (*instance, *model, record, op))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map = note: `#[warn(clippy::bind_instead_of_map)]` on by default
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`: crates/sync/src/compressed.rs#L87
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` --> crates/sync/src/compressed.rs:87:6 | 87 | / ops.last() 88 | | .and_then(|op| Some((*instance, *model, record, op))) | |_____________________________________________________________________________^ help: try: `ops.last().map(|op| (*instance, *model, record, op))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method: crates/sync/src/compressed.rs#L94
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method --> crates/sync/src/compressed.rs:94:2 | 94 | pub fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
using `clone` on type `u16` which implements the `Copy` trait: crates/sync/src/compressed.rs#L114
warning: using `clone` on type `u16` which implements the `Copy` trait --> crates/sync/src/compressed.rs:114:15 | 114 | ... model: model_str.clone(), | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `model_str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^

Artifacts

Produced during runtime
Name Size
cypress-videos Expired
1.84 MB