Skip to content

Media metadata extraction & Thumbnailer rework #8700

Media metadata extraction & Thumbnailer rework

Media metadata extraction & Thumbnailer rework #8700

Triggered via pull request April 25, 2024 05:15
Status Failure
Total duration 34m 51s
Artifacts 2

ci.yml

on: pull_request
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

1 error and 20 warnings
Cypress
The process '/usr/bin/env' failed with exit code 1
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method: crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method --> crates/sync/src/compressed.rs:90:2 | 90 | pub fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:372:21 | 372 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L794
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:794:10 | 794 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:9:2 | 9 | clippy::nursery, | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L1086
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:1086:10 | 1086 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead: crates/sd-indexer/src/ephemeral.rs#L115
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead --> crates/sd-indexer/src/ephemeral.rs:115:32 | 115 | let result = IndexerRule::apply_all(rules, &path).await.map_err(|err| { | ^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead: core/src/location/indexer/old_walk.rs#L499
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead --> core/src/location/indexer/old_walk.rs:499:41 | 499 | let Ok(rules_per_kind) = IndexerRule::apply_all(indexer_rules, &current_path) | ^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
used `unwrap()` on a `Result` value: core/src/api/ephemeral_files.rs#L168
warning: used `unwrap()` on a `Result` value --> core/src/api/ephemeral_files.rs:168:10 | 168 | ... trash::delete(&path).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used note: the lint level is defined here --> core/src/lib.rs:2:9 | 2 | #![warn(clippy::unwrap_used, clippy::panic)] | ^^^^^^^^^^^^^^^^^^^
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method: crates/sync/src/compressed.rs#L90
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method --> crates/sync/src/compressed.rs:90:2 | 90 | pub fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:372:21 | 372 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead: crates/sd-indexer/src/ephemeral.rs#L115
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead --> crates/sd-indexer/src/ephemeral.rs:115:32 | 115 | let result = IndexerRule::apply_all(rules, &path).await.map_err(|err| { | ^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
large size difference between variants: core/crates/heavy-lifting/src/file_identifier/tasks/extract_file_metadata.rs#L106
warning: large size difference between variants --> core/crates/heavy-lifting/src/file_identifier/tasks/extract_file_metadata.rs:106:3 | 106 | / enum StreamMessage { 107 | | Processed(Uuid, Result<FileMetadata, FileIOError>), | | -------------------------------------------------- the largest variant contains at least 224 bytes 108 | | Interrupt(InterruptionKind), | | --------------------------- the second-largest variant contains at least 1 bytes 109 | | } | |_________^ the entire enum is at least 224 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:5:2 | 5 | clippy::perf, | ^^^^^^^^^^^^ = note: `#[warn(clippy::large_enum_variant)]` implied by `#[warn(clippy::perf)]` help: consider boxing the large fields to reduce the total size of the enum | 107 | Processed(Uuid, Box<Result<FileMetadata, FileIOError>>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L794
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:794:10 | 794 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:9:2 | 9 | clippy::nursery, | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L1086
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:1086:10 | 1086 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead: core/src/location/indexer/old_walk.rs#L499
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead --> core/src/location/indexer/old_walk.rs:499:41 | 499 | let Ok(rules_per_kind) = IndexerRule::apply_all(indexer_rules, &current_path) | ^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

Artifacts

Produced during runtime
Name Size
cypress-screenshots Expired
1.56 MB
cypress-videos Expired
2.71 MB