CI #8696
utkubakirci.yml
on: merge_group
TypeScript
1m 31s
ESLint
2m 17s
Cypress
17m 50s
Rust Formatting
45s
Matrix: clippy
Annotations
1 error and 20 warnings
|
Clippy (macos-14)
The process '/opt/homebrew/bin/git' failed with exit code 128
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L26
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:26:23
|
26 | let mut model_str = first.model.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `first.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L39
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:39:40
|
39 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L52
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:52:40
|
52 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/sync/src/compressed.rs#L76
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/sync/src/compressed.rs:76:6
|
76 | / ops.first()
77 | | .and_then(|op| Some((*instance, *model, record, op)))
| |_____________________________________________________________________________^ help: try: `ops.first().map(|op| (*instance, *model, record, op))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
|
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/sync/src/compressed.rs#L87
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/sync/src/compressed.rs:87:6
|
87 | / ops.last()
88 | | .and_then(|op| Some((*instance, *model, record, op)))
| |_____________________________________________________________________________^ help: try: `ops.last().map(|op| (*instance, *model, record, op))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
|
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L94
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:94:2
|
94 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L114
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:114:15
|
114 | ... model: model_str.clone(),
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `model_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
called `map(<f>).unwrap_or_default()` on an `Option` value:
crates/crypto/src/keyring/linux/secret_service.rs#L38
warning: called `map(<f>).unwrap_or_default()` on an `Option` value
--> crates/crypto/src/keyring/linux/secret_service.rs:38:5
|
38 | .map(|k| {
| ______________^
39 | | k.search_items(id.as_sec_ser_identifier())
40 | | .ok()
41 | | .map_or(false, |x| !x.is_empty())
42 | | })
43 | | .unwrap_or_default()
| |________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_variant_and
note: the lint level is defined here
--> crates/crypto/src/lib.rs:4:2
|
4 | clippy::pedantic,
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::manual_is_variant_and)]` implied by `#[warn(clippy::pedantic)]`
help: use
|
38 ~ .is_some_and(|k| {
39 ~ k.search_items(id.as_sec_ser_identifier())
40 ~ .ok()
41 ~ .map_or(false, |x| !x.is_empty())
42 ~ })
|
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L26
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:26:23
|
26 | let mut model_str = first.model.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `first.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L39
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:39:40
|
39 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L52
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:52:40
|
52 | std::mem::replace(&mut model_str, op.model.clone()),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `op.model`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/sync/src/compressed.rs#L76
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/sync/src/compressed.rs:76:6
|
76 | / ops.first()
77 | | .and_then(|op| Some((*instance, *model, record, op)))
| |_____________________________________________________________________________^ help: try: `ops.first().map(|op| (*instance, *model, record, op))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
|
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/sync/src/compressed.rs#L87
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/sync/src/compressed.rs:87:6
|
87 | / ops.last()
88 | | .and_then(|op| Some((*instance, *model, record, op)))
| |_____________________________________________________________________________^ help: try: `ops.last().map(|op| (*instance, *model, record, op))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
|
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L94
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:94:2
|
94 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
using `clone` on type `u16` which implements the `Copy` trait:
crates/sync/src/compressed.rs#L114
warning: using `clone` on type `u16` which implements the `Copy` trait
--> crates/sync/src/compressed.rs:114:15
|
114 | ... model: model_str.clone(),
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `model_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
cypress-videos
Expired
|
1.61 MB |
|