Media metadata extraction & Thumbnailer rework #8691
HeavenVolkoffci.yml
on: pull_request
TypeScript
1m 27s
ESLint
2m 17s
Cypress
16m 44s
Rust Formatting
4m 54s
Matrix: clippy
Annotations
7 errors and 10 warnings
|
Rust Formatting
Process completed with exit code 1.
|
|
cannot borrow `self.format_ctx` as mutable because it is also borrowed as immutable:
crates/ffmpeg/src/movie_decoder.rs#L175
error[E0502]: cannot borrow `self.format_ctx` as mutable because it is also borrowed as immutable
--> crates/ffmpeg/src/movie_decoder.rs:175:33
|
170 | let stream = self.format_ctx
| --------------- immutable borrow occurs here
...
175 | av_guess_sample_aspect_ratio(self.format_ctx.as_mut(), stream, self.frame.as_mut())
| ^^^^^^^^^^^^^^^^^^^^^^^^ ------ immutable borrow later used here
| |
| mutable borrow occurs here
|
|
Clippy (macos-14)
Clippy had exited with the 101 exit code
|
|
Clippy (ubuntu-20.04)
The job was canceled because "macos-14" failed.
|
|
Clippy (ubuntu-20.04)
The operation was canceled.
|
|
Clippy (windows-latest)
The job was canceled because "macos-14" failed.
|
|
Cypress
The process '/usr/bin/env' failed with exit code 1
|
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/sync/src/compressed.rs#L76
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/sync/src/compressed.rs:76:6
|
76 | / ops.first()
77 | | .and_then(|op| Some((*instance, *model, record, op)))
| |_____________________________________________________________________________^ help: try: `ops.first().map(|op| (*instance, *model, record, op))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
|
|
using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`:
crates/sync/src/compressed.rs#L87
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`
--> crates/sync/src/compressed.rs:87:6
|
87 | / ops.last()
88 | | .and_then(|op| Some((*instance, *model, record, op)))
| |_____________________________________________________________________________^ help: try: `ops.last().map(|op| (*instance, *model, record, op))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
|
|
struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method:
crates/sync/src/compressed.rs#L94
warning: struct `CompressedCRDTOperations` has a public `len` method, but no `is_empty` method
--> crates/sync/src/compressed.rs:94:2
|
94 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10
|
742 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L829
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:829:25
|
829 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L830
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:830:10
|
830 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|