Media metadata extraction & Thumbnailer rework #8575
ci.yml
on: pull_request
TypeScript
1m 28s
ESLint
2m 19s
Cypress
20m 30s
Rust Formatting
4m 45s
Matrix: clippy
Annotations
1 error and 20 warnings
Cypress
The process '/usr/bin/env' failed with exit code 1
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead:
crates/sd-indexer/src/ephemeral.rs#L115
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead
--> crates/sd-indexer/src/ephemeral.rs:115:32
|
115 | let result = IndexerRule::apply_all(rules, &path).await.map_err(|err| {
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
unused `std::result::Result` that must be used:
core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used
--> core/crates/sync/src/ingest.rs:118:7
|
118 | self.receive_crdt_operation(op).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = self.receive_crdt_operation(op).await;
| +++++++
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10
|
742 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L829
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:829:25
|
829 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L830
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:830:10
|
830 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/mod.rs#L377
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/mod.rs:377:40
|
377 | pub_id_by_ancestor_materialized_path: &mut HashMap<String, (file_path::pub_id::Type, u64)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&HashMap<String, (file_path::pub_id::Type, u64)>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
method `video_props` is never used:
crates/ffmpeg/src/codec_ctx.rs#L135
warning: method `video_props` is never used
--> crates/ffmpeg/src/codec_ctx.rs:135:5
|
27 | impl FFmpegCodecContext {
| ----------------------- method in this implementation
...
135 | fn video_props(&self) -> Option<MediaVideoProps> {
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
struct `MediaVideoProps` is never constructed:
crates/ffmpeg/src/model.rs#L37
warning: struct `MediaVideoProps` is never constructed
--> crates/ffmpeg/src/model.rs:37:12
|
37 | pub struct MediaVideoProps {
| ^^^^^^^^^^^^^^^
|
struct `MediaAudioProps` is never constructed:
crates/ffmpeg/src/model.rs#L53
warning: struct `MediaAudioProps` is never constructed
--> crates/ffmpeg/src/model.rs:53:12
|
53 | pub struct MediaAudioProps {
| ^^^^^^^^^^^^^^^
|
struct `MediaSubtitleProps` is never constructed:
crates/ffmpeg/src/model.rs#L62
warning: struct `MediaSubtitleProps` is never constructed
--> crates/ffmpeg/src/model.rs:62:12
|
62 | pub struct MediaSubtitleProps {
| ^^^^^^^^^^^^^^^^^^
|
variants `MediaVideoProps`, `MediaAudioProps`, and `MediaSubtitleProps` are never constructed:
crates/ffmpeg/src/model.rs#L68
warning: variants `MediaVideoProps`, `MediaAudioProps`, and `MediaSubtitleProps` are never constructed
--> crates/ffmpeg/src/model.rs:68:2
|
67 | pub enum Props {
| ----- variants in this enum
68 | MediaVideoProps,
| ^^^^^^^^^^^^^^^
69 | MediaAudioProps,
| ^^^^^^^^^^^^^^^
70 | MediaSubtitleProps,
| ^^^^^^^^^^^^^^^^^^
|
variant name ends with the enum's name:
crates/ffmpeg/src/model.rs#L68
warning: variant name ends with the enum's name
--> crates/ffmpeg/src/model.rs:68:2
|
68 | MediaVideoProps,
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
cypress-screenshots
Expired
|
1.56 MB |
|
cypress-videos
Expired
|
2.51 MB |
|