Media metadata extraction & Thumbnailer rework #8546
HeavenVolkoffci.yml
on: pull_request
TypeScript
1m 29s
ESLint
2m 20s
Cypress
13m 20s
Rust Formatting
5m 13s
Matrix: clippy
Annotations
1 error and 20 warnings
|
Cypress
The process '/usr/bin/env' failed with exit code 1
|
|
unused `std::result::Result` that must be used:
core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used
--> core/crates/sync/src/ingest.rs:118:7
|
118 | self.receive_crdt_operation(op).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = self.receive_crdt_operation(op).await;
| +++++++
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10
|
742 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L829
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:829:25
|
829 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L830
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:830:10
|
830 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/mod.rs#L377
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/mod.rs:377:40
|
377 | pub_id_by_ancestor_materialized_path: &mut HashMap<String, (file_path::pub_id::Type, u64)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&HashMap<String, (file_path::pub_id::Type, u64)>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/mod.rs#L379
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/mod.rs:379:10
|
379 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead:
crates/media-metadata/src/image/datetime.rs#L61
warning: use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead
--> crates/media-metadata/src/image/datetime.rs:61:24
|
61 | Self::Naive(t) => t.timestamp(),
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this could be a `const fn`:
crates/media-metadata/src/image/datetime.rs#L58
warning: this could be a `const fn`
--> crates/media-metadata/src/image/datetime.rs:58:2
|
58 | / pub fn unix_timestamp(&self) -> i64 {
59 | | match self {
60 | | Self::Utc(t) => t.timestamp(),
61 | | Self::Naive(t) => t.timestamp(),
62 | | }
63 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn
note: the lint level is defined here
--> crates/media-metadata/src/lib.rs:10:2
|
10 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::missing_const_for_fn)]` implied by `#[warn(clippy::nursery)]`
|
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
|
unused `std::result::Result` that must be used:
core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used
--> core/crates/sync/src/ingest.rs:118:7
|
118 | self.receive_crdt_operation(op).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = self.receive_crdt_operation(op).await;
| +++++++
|
|
type `model::Props` is more private than the item `model::MediaCodec::props`:
crates/ffmpeg/src/model.rs#L79
warning: type `model::Props` is more private than the item `model::MediaCodec::props`
--> crates/ffmpeg/src/model.rs:79:2
|
79 | pub props: Option<Props>,
| ^^^^^^^^^^^^^^^^^^^^^^^^ field `model::MediaCodec::props` is reachable at visibility `pub(crate)`
|
note: but type `model::Props` is only usable at visibility `pub(self)`
--> crates/ffmpeg/src/model.rs:67:1
|
67 | enum Props {
| ^^^^^^^^^^
= note: `#[warn(private_interfaces)]` on by default
|
|
associated items `new`, `as_mut_ptr`, `get`, `set`, and `remove` are never used:
crates/ffmpeg/src/dict.rs#L20
warning: associated items `new`, `as_mut_ptr`, `get`, `set`, and `remove` are never used
--> crates/ffmpeg/src/dict.rs:20:16
|
19 | impl FFmpegDict {
| --------------- associated items in this implementation
20 | pub(crate) fn new(av_dict: Option<*mut AVDictionary>) -> Self {
| ^^^
...
33 | pub(crate) fn as_mut_ptr(&mut self) -> *mut AVDictionary {
| ^^^^^^^^^^
...
37 | pub(crate) fn get(&self, key: CString) -> Option<String> {
| ^^^
...
47 | pub(crate) fn set(&mut self, key: CString, value: CString) -> Result<(), Error> {
| ^^^
...
56 | pub(crate) fn remove(&mut self, key: CString) -> Result<(), Error> {
| ^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
multiple associated items are never used:
crates/ffmpeg/src/format_ctx.rs#L26
warning: multiple associated items are never used
--> crates/ffmpeg/src/format_ctx.rs:26:16
|
25 | impl FFmpegFormatContext {
| ------------------------ associated items in this implementation
26 | pub(crate) fn open_file(filename: CString, options: &mut FFmpegDict) -> Result<Self, Error> {
| ^^^^^^^^^
...
46 | pub(crate) fn as_mut_ptr(&mut self) -> *mut AVFormatContext {
| ^^^^^^^^^^
...
50 | pub(crate) fn find_stream_info(&self) -> Result<(), Error> {
| ^^^^^^^^^^^^^^^^
...
59 | pub fn formats(&self) -> Vec<String> {
| ^^^^^^^
...
85 | pub fn duration(&self) -> Option<TimeDelta> {
| ^^^^^^^^
...
99 | pub fn start_time(&self) -> Option<TimeDelta> {
| ^^^^^^^^^^
...
115 | pub fn bit_rate(&self) -> Option<i64> {
| ^^^^^^^^
...
123 | pub fn chapters(&self) -> Vec<MediaChapter> {
| ^^^^^^^^
...
147 | pub fn programs(&self) -> Vec<MediaProgram> {
| ^^^^^^^^
...
174 | pub fn metadata(&self) -> Option<MediaMetadata> {
| ^^^^^^^^
|