Media metadata extraction & Thumbnailer rework #8545
ci.yml
on: pull_request
TypeScript
1m 30s
ESLint
2m 18s
Cypress
13m 23s
Rust Formatting
5m 21s
Matrix: clippy
Annotations
11 errors and 10 warnings
Rust Formatting
Process completed with exit code 1.
|
mismatched types:
crates/ffmpeg/src/probe.rs#L39
error[E0308]: mismatched types
--> crates/ffmpeg/src/probe.rs:39:13
|
39 | duration: "" , // Option<i64>
| ^^ expected `Option<i64>`, found `&str`
|
= note: expected enum `std::option::Option<i64>`
found reference `&'static str`
|
mismatched types:
crates/ffmpeg/src/probe.rs#L40
error[E0308]: mismatched types
--> crates/ffmpeg/src/probe.rs:40:15
|
40 | start_time: "" , // Option<i64>
| ^^ expected `Option<i64>`, found `&str`
|
= note: expected enum `std::option::Option<i64>`
found reference `&'static str`
|
mismatched types:
crates/ffmpeg/src/probe.rs#L41
error[E0308]: mismatched types
--> crates/ffmpeg/src/probe.rs:41:12
|
41 | bitrate: "" , // Option<i64>
| ^^ expected `Option<i64>`, found `&str`
|
= note: expected enum `std::option::Option<i64>`
found reference `&'static str`
|
mismatched types:
crates/ffmpeg/src/probe.rs#L42
error[E0308]: mismatched types
--> crates/ffmpeg/src/probe.rs:42:13
|
42 | chapters: "" , // Vec<MediaChapter>
| ^^ expected `Vec<MediaChapter>`, found `&str`
|
= note: expected struct `std::vec::Vec<model::MediaChapter>`
found reference `&'static str`
|
mismatched types:
crates/ffmpeg/src/probe.rs#L43
error[E0308]: mismatched types
--> crates/ffmpeg/src/probe.rs:43:13
|
43 | programs: "" , // Vec<MediaProgram>
| ^^ expected `Vec<MediaProgram>`, found `&str`
|
= note: expected struct `std::vec::Vec<model::MediaProgram>`
found reference `&'static str`
|
Clippy (macos-14)
Clippy had exited with the 101 exit code
|
Clippy (ubuntu-20.04)
The job was canceled because "macos-14" failed.
|
Clippy (ubuntu-20.04)
The operation was canceled.
|
Clippy (windows-latest)
The job was canceled because "macos-14" failed.
|
Cypress
The process '/usr/bin/env' failed with exit code 1
|
unused `std::result::Result` that must be used:
core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used
--> core/crates/sync/src/ingest.rs:118:7
|
118 | self.receive_crdt_operation(op).await;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
118 | let _ = self.receive_crdt_operation(op).await;
| +++++++
|
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:270:5
|
270 | accept_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> core/crates/indexer-rules/src/lib.rs:25:2
|
25 | deprecated
| ^^^^^^^^^^
|
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:275:5
|
275 | reject_dir_for_its_children(source, children)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:338:21
|
338 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead:
core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead
--> core/crates/indexer-rules/src/lib.rs:372:21
|
372 | .map(|rule| rule.apply(source.as_ref()))
| ^^^^^
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10
|
742 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
note: the lint level is defined here
--> core/crates/heavy-lifting/src/lib.rs:9:2
|
9 | clippy::nursery,
| ^^^^^^^^^^^^^^^
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L829
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:829:25
|
829 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L830
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:830:10
|
830 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/mod.rs#L377
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/mod.rs:377:40
|
377 | pub_id_by_ancestor_materialized_path: &mut HashMap<String, (file_path::pub_id::Type, u64)>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&HashMap<String, (file_path::pub_id::Type, u64)>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
this argument is a mutable reference, but not used mutably:
core/crates/heavy-lifting/src/indexer/mod.rs#L379
warning: this argument is a mutable reference, but not used mutably
--> core/crates/heavy-lifting/src/indexer/mod.rs:379:10
|
379 | errors: &mut Vec<NonCriticalJobError>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|