Skip to content

[ENG-1413] Full disk access perms #6587

[ENG-1413] Full disk access perms

[ENG-1413] Full disk access perms #6587

Triggered via pull request November 17, 2023 17:07
Status Cancelled
Total duration 9m 25s
Artifacts

ci.yml

on: pull_request
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 23 warnings
Clippy (windows-latest)
The operation was canceled.
Clippy (macos-latest)
The operation was canceled.
TypeScript
The process '/usr/bin/git' failed with exit code 128
ESLint: interface/app/$libraryId/TopBar/SearchBar.tsx#L48
React Hook useCallback has unnecessary dependencies: 'location.pathname' and 'searchPath.pathname'. Either exclude them or remove the dependency array
ESLint
The process '/usr/bin/git' failed with exit code 128
Rust Formatting
The process '/usr/bin/git' failed with exit code 128
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference: core/src/api/search/utils.rs#L109
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> core/src/api/search/utils.rs:109:3 | 109 | self, | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference: core/src/api/search/utils.rs#L75
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> core/src/api/search/utils.rs:75:3 | 75 | self, | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default
used `unwrap()` on a `Result` value: core/src/api/search/saved.rs#L146
warning: used `unwrap()` on a `Result` value --> core/src/api/search/saved.rs:146:31 | 146 | let filters_as_string = serde_json::to_string(filters).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on a `Result` value: core/src/api/search/saved.rs#L117
warning: used `unwrap()` on a `Result` value --> core/src/api/search/saved.rs:117:34 | 117 | let filters: Vec<Filter> = serde_json::from_str(&filters_string).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on a `Result` value: core/src/api/search/saved.rs#L116
warning: used `unwrap()` on a `Result` value --> core/src/api/search/saved.rs:116:28 | 116 | let filters_string = String::from_utf8(filters_bytes).unwrap(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
use of `unwrap_or_else` to construct default value: core/src/api/search/saved.rs#L114
warning: use of `unwrap_or_else` to construct default value --> core/src/api/search/saved.rs:114:42 | 114 | let filters_bytes = search.filters.unwrap_or_else(Vec::new); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
used `unwrap()` on a `Result` value: core/src/api/search/saved.rs#L54
warning: used `unwrap()` on a `Result` value --> core/src/api/search/saved.rs:54:17 | 54 | ... .map(|f| serde_json::to_string(&f).unwrap().into_bytes()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used note: the lint level is defined here --> core/src/lib.rs:1:9 | 1 | #![warn(clippy::unwrap_used, clippy::panic)] | ^^^^^^^^^^^^^^^^^^^
useless conversion to the same type: `chrono::DateTime<chrono::FixedOffset>`: core/src/api/search/object.rs#L140
warning: useless conversion to the same type: `chrono::DateTime<chrono::FixedOffset>` --> core/src/api/search/object.rs:140:42 | 140 | Range::To(v) => date_accessed::lte(v.into()), | ^^^^^^^^ help: consider removing `.into()`: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `chrono::DateTime<chrono::FixedOffset>`: core/src/api/search/object.rs#L139
warning: useless conversion to the same type: `chrono::DateTime<chrono::FixedOffset>` --> core/src/api/search/object.rs:139:44 | 139 | Range::From(v) => date_accessed::gte(v.into()), | ^^^^^^^^ help: consider removing `.into()`: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
method `into_prisma` is never used: core/src/api/search/utils.rs#L36
warning: method `into_prisma` is never used --> core/src/api/search/utils.rs:36:9 | 35 | impl<T> MaybeNot<T> { | ------------------- method in this implementation 36 | pub fn into_prisma<R: From<prisma_client_rust::Operator<R>>>(self, param: fn(T) -> R) -> R { | ^^^^^^^^^^^
function `mount` is never used: core/src/api/search/saved.rs#L69
warning: function `mount` is never used --> core/src/api/search/saved.rs:69:15 | 69 | pub(crate) fn mount() -> AlphaRouter<Ctx> { | ^^^^^
method `exec` is never used: core/src/api/search/saved.rs#L38
warning: method `exec` is never used --> core/src/api/search/saved.rs:38:15 | 37 | impl SavedSearchCreateArgs { | -------------------------- method in this implementation 38 | pub async fn exec( | ^^^^ | = note: `#[warn(dead_code)]` on by default
unused import: `invalidate_query`: core/src/api/search/saved.rs#L8
warning: unused import: `invalidate_query` --> core/src/api/search/saved.rs:8:34 | 8 | use crate::{api::utils::library, invalidate_query, library::Library, prisma::saved_search}; | ^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
Clippy (ubuntu-20.04)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (ubuntu-20.04)
The process '/usr/bin/git' failed with exit code 128
Clippy (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (windows-latest)
The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128
Clippy (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (macos-latest)
The process '/usr/local/bin/git' failed with exit code 128