perf: Dory's compute_T_vec_prime should be able to use Blitzar's fixed MSM (PROOF-876) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/proof-of-sql/src/proof_primitive/dory/dory_vmv_helper.rs
Outdated
Show resolved
Hide resolved
jacobtrombetta
force-pushed
the
perf/compute-t-vec-blitzar-PROOF-876
branch
from
ba506b0
to
f4c8b55
Compare
crates/proof-of-sql/src/proof_primitive/dory/dory_vmv_helper.rs
Outdated
Show resolved
Hide resolved
JayWhite2357
requested changes
Jun 18, 2024
crates/proof-of-sql/src/proof_primitive/dory/public_parameters.rs
Outdated
Show resolved
Hide resolved
* remove parallel iterator because blitzar_sys::sxt_multiexp_handle does not implement a sync trait
jacobtrombetta
force-pushed
the
perf/compute-t-vec-blitzar-PROOF-876
branch
from
918a3b5
to
daa8c2a
Compare
JayWhite2357
approved these changes
Jun 19, 2024
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When creating a Dory proof the
compute_T_vec_primefunction requires multiple MSMs. The current implementation of this function only supports the use of the Arkworks library, which only runs on the CPU. In an effort to improve the performance of Dory, this PR introduces the Blitzar fixed MSM tocompute_T_vec_primewhen appropriate to perform the MSM computations.The commit focusing only on performance changes is available here.
What changes are included in this PR?
compute_T_vec_primenow supports Blitzar's fixed MSM if the feature flag"blitzar"is turned on. The CPU version using Arkworks is still supported.transpose_columnand related functions appearing in thedory_commitment_helper_gpuclass are moved into a separate class,transpose.blitzar_handleto theProverSetup.par_iter()ineval_vmv_re.rsbecause*mut blitzar_sys::sxt_multiexp_handlecannot be shared between threads safely.Are these changes tested?
Yes, on both CPU and GPU.