Feat/parquet to commitment #277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarttimwhite
force-pushed
the
feat/parquet-to-commitment-trevor
branch
from
ca878b2
to
868f547
Compare
iajoiner
reviewed
Oct 18, 2024
| .map(|(precision, scale)| { | ||
| Arc::new(Field::new( | ||
| field.name(), | ||
| DataType::Decimal256(*precision, *scale), |
There was a problem hiding this comment.
Our precision for big decimal columns generally exceed Decimal256 max precision which is 76
… feature flags, different inputs
…c dory, and change offset mechanism
stuarttimwhite
force-pushed
the
feat/parquet-to-commitment-trevor
branch
from
03c901a
to
9adf9cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
There is a need to be able to compute the table commitments for tables from parquet files.
What changes are included in this PR?
New utils directory with a script for calculating TableCommitments from parquet files and writing them to a file as a blob.
Are these changes tested?
Yes.