Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorporate leftover feedback from previous PR #17

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

Dustin-Ray
Copy link
Contributor

Rationale for this change

Incorporates a small amount of feedback from #12

What changes are included in this PR?

Corrects naming in tests and removes unsupported feature in group_by_util

Are these changes tested?

yes

@Dustin-Ray Dustin-Ray marked this pull request as ready for review June 19, 2024 19:45
@Dustin-Ray Dustin-Ray requested a review from iajoiner June 19, 2024 19:45
Copy link
Contributor

@iajoiner iajoiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drcapybara !

@Dustin-Ray Dustin-Ray merged commit 6c3aa58 into main Jun 19, 2024
8 checks passed
@Dustin-Ray Dustin-Ray deleted the feat/timestamp branch June 19, 2024 20:05
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants