fix!: separate element decoding error from verification error #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayWhite2357
requested changes
Jun 19, 2024
Dustin-Ray
previously approved these changes
Jun 19, 2024
iajoiner
changed the title
|
@drcapybara You are right! It is a breaking change since it changes error messages when certain non-verification errors occur. |
- add `QueryError::MiscellaneousDecodingError`, `QueryError::InvalidIndexes` and `QueryError::MiscellaneousEvaluationError` to account for decoding errors beyond overflows and invalid strings - if decoding errors happen we will use them instead of VerificationError
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
For arithmetic (such as #14) to work it is necessary to separate element decoding error from verification error. There are already
QueryError::OverflowandQueryError::InvalidStringthat handle some decoding errors. However currently in practice if overflows do take place we getVerificationError. This PR will fix this issue.What changes are included in this PR?
QueryError::MiscellaneousDecodingError,QueryError::InvalidIndexesandQueryError::MiscellaneousEvaluationErrorto account for decoding errors beyond overflows and invalid stringsVerificationErrorcrates/proof-of-sql/src/sql/proof/provable_query_result_test.rsAre these changes tested?
Yes.