Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marathon Station: Added air alarms to CMO, Surgery, Security Checkpoint #33213

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scrivoy
Copy link
Contributor

@scrivoy scrivoy commented Nov 7, 2024

About the PR

This PR adds air alarms to the following locations:

  • CMO office (including an extra air sensor in the bedroom)
  • Hallway in front of the CMO office.
  • Surgery next to CMO Office
  • Security checkpoint (Arrivals/EVAC)

Why / Balance

These areas lacked air alarms, which could lead to delayed responses to atmospheric issues. This change improves safety and functionality in critical locations.

Fixes #33211

Technical details

Added air alarms in the specified areas and linked them to the corresponding scrubbers and vents.
The CMO's office received a separate air sensor in the bedroom, placed below the table.

Media

Checkpoint
2024-11-07_21 37 36
CMO
2024-11-07_21 52 41
Hallway
2024-11-07_21 53 13
Surgery 1
2024-11-08_01 15 55
Surgery 2
2024-11-08_01 15 36

Requirements

Breaking changes

Changelog

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • marathon.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/07/24 21:54

@github-actions github-actions bot added No C# For things that don't need code. Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. labels Nov 7, 2024
@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 7, 2024

The Air Alarm position in the surgery rooms is not perfectly accessible, but there is no room on the other walls.

@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 7, 2024

okay, check failed, i'll have another look at the data.

edit: hm, everything looks good to me. but im new, so i might miss something here.

@thebadman4662
Copy link

The Air Alarm position in the surgery rooms is not perfectly accessible, but there is no room on the other walls.

One could be put near console, same with other if you moved fire alarm to disposal bin I guess? Otherwise people have to break table or their legs to access air alarm. 🤣

@scrivoy scrivoy changed the title Marathon: Added air alarms to CMO, Surgery, Security Checkpoint Marathon Station: Added air alarms to CMO, Surgery, Security Checkpoint Nov 7, 2024
@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 7, 2024

One could be put near console, same with other if you moved fire alarm to disposal bin I guess?

Yes, you're right, I hadn't thought of that. Thanks for the reminder! I will change that.

@Emisse
Copy link
Contributor

Emisse commented Nov 7, 2024

remove the invalid configurator from your map file

@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 8, 2024

remove the invalid configurator from your map file

ah okay, i was wondering where that came from, i'm on it.

@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 8, 2024

ok i have updated the position of the air alarm (new pictures in the PR overview).
i thought it would be nicer if the fire switch stayed in the middle of the hallway, so i moved the defi one tile up and put the waste bin on the other side.
To move the "yellow box decal" I had to remove everything on that tile, now it looks different, the outline of the "blue corner decal" looks lighter than the others but i used the "Medical Color" from the palette.
any idea how i can recreate this?
When this is done i'll push the commit.

2024-11-08_01 33 48

@Emisse
Copy link
Contributor

Emisse commented Nov 10, 2024

off the top of my head looks like its a similar decal but not the same one

@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 10, 2024

off the top of my head looks like its a similar decal but not the same one

I found it. I searched the map .yml for my changes and saw what was deleted.
So to archive this colour you put down the BrickTileWhiteCornerNw without a custom colour, so in this case its just white (#FFFFFFFF or 255/255/255). and then you put down the same decal but with the custom department colour medical (#52B4E996 or 82/180/233).

In the code it looks like this
grafik

I'll finish my work and push the changes.

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • marathon.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/10/24 21:56

@scrivoy
Copy link
Contributor Author

scrivoy commented Nov 11, 2024

I forgot to tell you, I finished my work on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping. No C# For things that don't need code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marathon air alarm issues.
3 participants