-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NASA Challenge_[@katiehughes1]_[Space ROS Gazebo Demos]_[closes #47] #33
base: main
Are you sure you want to change the base?
Conversation
Hi @katie-hughes - thanks for your submission! There are a few housekeeping things I need you to do per our contribution guidelines. First, please file an issue with a feature request for this demo, then update your commit message and the title of this PR to include the issue #. Second, please change your |
@mkhansenbot Thanks for letting me know. I just updated our docker related scripts to match the new CI steps, and resolved the merge conflict in the readme. Challenge Brief - NASA Space ROS Sim Summer Sprint Challenge.pdf Let me know if there are any other changes that need to be made! |
Yes, please add a "Feature request" issue (there's now a template when you create a new issue), with a brief description of the demo, then update the commit messages to refer to that issue. Also add the issue number to the PR title. Thanks again! |
@katie-hughes - I just changed the build workflow to cd into the folder first, then rebased your branch |
@mkhansenbot sounds good, will just need to update the docker related scripts so that they can run from this new location |
This is a submission for the NASA Space ROS Sim Summer Sprint Challenge written by @david-dorf and I. The main details of our submission are on the README.md introduced in the
spaceros_gz_demos
package we added to this repo. We introduce four new demos that run in Gazebo Harmonic with the relevant topics for sending robot controls and reading sensor information bridged to ROS. This includes simulated worlds with robots on the Moon, Mars, Enceladus, and in orbit above Earth. We also provide a Dockerfile that can be used to run these simulations inspaceros_gz_demos/docker
that is built upon the base Space ROS docker image, as well as some scripts to help with building and running the image.This PR is a lot of lines, but most of the lines come from the mesh files added for the different models. The relevant ROS code added is in
spaceros_gz_demos/launch
.Relevant issue: #47
space.mp4