update issue #484

- Cleanup apis generic form/view.
- API client services should only list apis that are available for core in core app_type.

apps/Core/Views/Default/html/system/api/client/services/view.html

@@ -3,14 +3,6 @@
     {% set title = 'API:' ~ api['category'] ~ ':' ~ api['provider'] ~ ' - ' ~ api['name'] %}
 {% else %}
     {% set apiId = '' %}
-    {% if api['repository'] is defined and api['repository'] === true %}
-        {% set title = 'New API:' ~ api['category'] %}
-    {% else %}
-        {% set title = 'New API:' ~ api['category'] ~ ':' ~ api['provider'] %}
-    {% endif %}
+    {% set title = 'New API:' ~ api['category'] ~ ':' ~ api['provider'] %}
 {% endif %}
-{% if api['repository'] is defined and api['repository'] === true %}
-    {{view.getPartial('../../modules/repositories/view')}}
-{% else %}
-    {{view.getPartial('services/apis/' ~ api['category'] ~ '/' ~ api['provider']|lower ~ '/view')}}
-{% endif %}
+{{view.getPartial('services/apis/' ~ api['category'] ~ '/' ~ api['provider']|lower ~ '/view')}}

system/Base/Providers/BasepackagesServiceProvider/Packages/ApiClientServices/ApiClientServices.php

@@ -95,13 +95,19 @@ protected function registerApiCategories()
     {
         $this->apiCategories = [];
 
-        $basepackagesApis = $this->modules->packages->getPackagesForCategory('basepackagesApis');
         $apis = $this->modules->packages->getPackagesForCategory('appsApis');
 
-        $apis = array_merge($basepackagesApis, $apis);
+        if ($this->apps->getAppInfo()['app_type'] === 'core') {
+            $basepackagesApis = $this->modules->packages->getPackagesForCategory('basepackagesApis');
+            $apis = array_merge($basepackagesApis, $apis);
+        }
 
         if ($apis && is_array($apis) && count($apis) > 0) {
             foreach ($apis as $api) {
+                if ($this->apps->getAppInfo()['app_type'] !== $api['app_type']) {
+                    continue;
+                }
+
                 $api['class'] = explode('\\', $api['class']);
 
                 $category = strtolower($api['class'][$this->helper->lastKey($api['class']) - 2]);