dev: UDPConn implementation by @nickaxgit #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added UDPConn, commented some areas for easier understanding, suggested a name change or two * some tidying of udpConn.go * Changes as requested (whitespace, UDP close method, extract anonymous function, errUnsupported returns, function comments etc) * fixes two isuues spotted by b0ch3nski * more linebreak issues fixed - appologies * Tiny fix to itcphandler comment (although it has that c# smell)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 45.99% 46.15% +0.15%
==========================================
Files 29 30 +1
Lines 4937 5163 +226
==========================================
+ Hits 2271 2383 +112
- Misses 2406 2504 +98
- Partials 260 276 +16 ☔ View full report in Codecov by Sentry. |
Merged
|
@nickaxgit Fixed a bug in the checksum calculation- could you test this? |
|
Will do ... sorry life has been getting in the way a bit the last few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UDPConn, commented some areas for easier understanding, suggested a name change or two
some tidying of udpConn.go
Changes as requested (whitespace, UDP close method, extract anonymous function, errUnsupported returns, function comments etc)
fixes two isuues spotted by b0ch3nski
more linebreak issues fixed - appologies
Tiny fix to itcphandler comment (although it has that c# smell)