Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable stable ID for contracts #849

Merged
merged 4 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Env variables for docker-compose.yaml
EDC_IMAGE=ghcr.io/sovity/edc-dev:7.2.1
TEST_BACKEND_IMAGE=ghcr.io/sovity/test-backend:7.2.1
EDC_IMAGE=ghcr.io/sovity/edc-dev:7.2.2
TEST_BACKEND_IMAGE=ghcr.io/sovity/test-backend:7.2.2
EDC_UI_IMAGE=ghcr.io/sovity/edc-ui:2.4.0
EDC_UI_ACTIVE_PROFILE=sovity-open-source
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
release:
types: [ published ]
pull_request:
branches: [ main ]
branches: [ main, version/v7.2.x ]

env:
REGISTRY_URL: ghcr.io
Expand Down
29 changes: 29 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,35 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md).
#### Compatible Versions


## [7.2.2] - 2024-03-13

### Overview

Bugfix

### EDC UI

https://github.com/sovity/edc-ui/releases/tag/v2.4.0

### EDC Extensions

#### Patch Changes

- DspCatalogService: Stable Contract Offer IDs removed

### Deployment Migration Notes

_No special deployment migration steps required_

#### Compatible Versions

- Connector Backend Docker Images:
- Dev EDC: `ghcr.io/sovity/edc-dev:7.2.2`
- sovity EDC CE: `ghcr.io/sovity/edc-ce:7.2.2`
- MDS EDC CE: `ghcr.io/sovity/edc-ce-mds:7.2.2`
- Connector UI Docker Image: `ghcr.io/sovity/edc-ui:2.4.0`
richardtreier marked this conversation as resolved.
Show resolved Hide resolved


## [7.2.1] - 2024-02-21

### Overview
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import jakarta.json.Json;
import jakarta.json.JsonObject;
ununhexium marked this conversation as resolved.
Show resolved Hide resolved
import lombok.RequiredArgsConstructor;
import lombok.val;
import org.eclipse.edc.jsonld.spi.JsonLd;
import org.jetbrains.annotations.NotNull;

Expand Down Expand Up @@ -67,9 +66,6 @@ private DspDataOffer buildDataOffer(JsonObject dataset) {

@NotNull
private DspContractOffer buildContractOffer(JsonObject json) {
val stableId = DspContractOfferUtils.buildStableId(json);
val withStableId = Json.createObjectBuilder(json).remove(Prop.ID).add(Prop.ID, stableId).build();

return new DspContractOffer(stableId, withStableId);
return new DspContractOffer(JsonLdUtils.id(json), json);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void testCatalogMapping() {

assertThat(offer.getContractOffers()).hasSize(1);
var co = offer.getContractOffers().get(0);
assertThat(co.getContractOfferId()).isEqualTo("contract-id:asset-id:ODJjMDNjMmM4YzQ5NmE0OTg4ZjVjOTY4OGU2MmMyN2UxYjIxZDAwZQ==");
assertThat(co.getContractOfferId()).isEqualTo("policy-1");
assertThat(toJson(co.getPolicyJsonLd())).contains("ALWAYS_TRUE");

assertThat(offer.getDistributions()).hasSize(1);
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@id": "test-1.0",
"@type": "dcat:Dataset",
"odrl:hasPolicy": {
"@id": "contract-id:asset-id:policy-id",
"@id": "policy-1",
"@type": "odrl:Set",
"odrl:permission": {
"odrl:target": "test-1.0",
Expand Down
Loading