-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
391 backend UI api wrapper GET & POST & DELETE contract definition endpoint with 02x #466
391 backend UI api wrapper GET & POST & DELETE contract definition endpoint with 02x #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after yesterday's pair programmed code review, this looks really good already! 🎉
extensions/wrapper/wrapper/src/test/java/de/sovity/edc/ext/wrapper/TestUtils.java
Outdated
Show resolved
Hide resolved
...de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/ContractDefinitionUtils.java
Outdated
Show resolved
Hide resolved
...sions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/CriterionDto.java
Outdated
Show resolved
Hide resolved
.../wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractDefinitionRequest.java
Show resolved
Hide resolved
.../wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractDefinitionRequest.java
Outdated
Show resolved
Hide resolved
extensions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/UiResource.java
Outdated
Show resolved
Hide resolved
extensions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/UiResource.java
Outdated
Show resolved
Hide resolved
.../wrapper/client/src/test/java/de/sovity/edc/client/ContractDefinitionPageApiServiceTest.java
Outdated
Show resolved
Hide resolved
...sions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/CriterionDto.java
Outdated
Show resolved
Hide resolved
extensions/wrapper/wrapper/src/test/java/de/sovity/edc/ext/wrapper/TestUtils.java
Outdated
Show resolved
Hide resolved
fix: PR review
...nsions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/OperatorDto.java
Outdated
Show resolved
Hide resolved
...ns/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/OperatorEnumDto.java
Outdated
Show resolved
Hide resolved
...nsions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/OperatorDto.java
Outdated
Show resolved
Hide resolved
...in/java/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/CriterionMapper.java
Outdated
Show resolved
Hide resolved
...in/java/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/CriterionMapper.java
Outdated
Show resolved
Hide resolved
...e/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/OperatorEnumEqualityTest.java
Outdated
Show resolved
Hide resolved
...ns/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/OperatorEnumDto.java
Outdated
Show resolved
Hide resolved
...nsions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/OperatorDto.java
Outdated
Show resolved
Hide resolved
...nsions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/OperatorDto.java
Outdated
Show resolved
Hide resolved
...er/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractDefinitionEntry.java
Outdated
Show resolved
Hide resolved
fix: PR review
e2e-test/src/test/java/de/sovity/edc/extension/e2e/connector/TestConnector.java
Outdated
Show resolved
Hide resolved
.../wrapper/client/src/test/java/de/sovity/edc/client/ContractDefinitionPageApiServiceTest.java
Outdated
Show resolved
Hide resolved
...rapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/CriterionLiteralDto.java
Outdated
Show resolved
Hide resolved
...rapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/CriterionLiteralDto.java
Outdated
Show resolved
Hide resolved
...rapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/CriterionLiteralDto.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractDefinitionCreateRequest.java
Outdated
Show resolved
Hide resolved
...er/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/ContractDefinitionEntry.java
Outdated
Show resolved
Hide resolved
...sions/wrapper/wrapper/src/main/java/de/sovity/edc/ext/wrapper/api/ui/model/CriterionDto.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i also pushed one commit, care
e2e-test/src/test/java/de/sovity/edc/extension/e2e/connector/TestConnector.java
Outdated
Show resolved
Hide resolved
extensions/postgres-flyway/src/main/resources/migration/default/V3__MS8-to-0.2.0.sql
Outdated
Show resolved
Hide resolved
extensions/postgres-flyway/src/main/resources/migration/default/V3__MS8-to-0.2.0.sql
Outdated
Show resolved
Hide resolved
...nsions/postgres-flyway/src/main/resources/migration/provider/V1__m8-provider-sample-data.sql
Outdated
Show resolved
Hide resolved
...ain/java/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/OperatorMapper.java
Show resolved
Hide resolved
...ain/java/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/OperatorMapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes sovity/edc-ui#409
closes sovity/edc-ui#391
closes sovity/edc-ui#332