fix: Operator test case

sovity · Aug 15, 2023 · 9e1cc10 · 9e1cc10
1 parent ce78b61
commit 9e1cc10
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/...java/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/CriterionMapper.java b/...java/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/CriterionMapper.java
@@ -32,7 +32,7 @@ public List<UiCriterionDto> mapToCriterionDtos(@NonNull List<Criterion> criteria
         return criteria.stream().map(this::mapToCriterionDto).toList();
     }
 
-    public UiCriterionDto mapToCriterionDto(Criterion criterion) {
+     UiCriterionDto mapToCriterionDto(Criterion criterion) {
         if (criterion == null) {
             return null;
         }

diff --git a/...a/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/OperatorMapperTest.java b/...a/de/sovity/edc/ext/wrapper/api/ui/pages/contracts/services/utils/OperatorMapperTest.java
@@ -8,7 +8,8 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.util.Arrays;
-public class OperatorMapperTest {
+
+class OperatorMapperTest {
     OperatorMapper operatorMapper;
 
     @BeforeEach
@@ -17,13 +18,21 @@ void setup() {
     }
 
     @Test
-    void MappingFromDtoToOperator() {
+    void testMappingFromDtoToOperator() {
         Arrays.stream(OperatorDto.values()).forEach(dto -> {
             Operator operator = operatorMapper.toOperator(dto);
             assertThat(operator.name()).isEqualTo(dto.name());
         });
     }
 
+    @Test
+    void testMappingFromString() {
+        Arrays.stream(Operator.values()).forEach(op -> {
+            var dto = operatorMapper.fromString(op.name());
+            assertThat(op.name()).isEqualTo(dto.name());
+        });
+    }
+
     @Test
     void testCaseInsensitivityFromString() {
         String operatorString = "Eq";