1.1.1

souvik-ghosh · Apr 20, 2020 · cd5581a · cd5581a
1 parent 03d172b
commit cd5581a
Show file tree

Hide file tree

Showing 9 changed files with 84 additions and 6,802 deletions.
diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 iOS/Android thumbnail generator with support for both local and remote videos. `react-native-create-thumbnail` is a wrapper around
 [`AVAssetImageGenerator`](https://developer.apple.com/documentation/avfoundation/avassetimagegenerator?language=objc) (iOS) and [`MediaMetadataRetriever`](https://developer.android.com/reference/android/media/MediaMetadataRetriever) (Android)
 
-[![npm](https://img.shields.io/npm/v/react-native-create-thumbnail.svg)](https://npmjs.com/package/react-native-create-thumbnail) [![npm](https://img.shields.io/npm/dm/react-native-create-thumbnail.svg)](https://npmjs.com/package/react-native-create-thumbnail) [![License](https://img.shields.io/npm/l/react-native-create-thumbnail.svg)](https://www.npmjs.com/package/react-native-create-thumbnail)
+[![npm version](https://img.shields.io/npm/v/react-native-create-thumbnail.svg)](https://npmjs.com/package/react-native-create-thumbnail) [![npm downloads](https://img.shields.io/npm/dm/react-native-create-thumbnail.svg)](https://npmjs.com/package/react-native-create-thumbnail) [![Maintenance Status](https://img.shields.io/badge/maintenance-active-green.svg)](#maintenance-status)
 
 ## Getting started
 

diff --git a/android/src/main/java/com/createthumbnail/CreateThumbnailModule.java b/android/src/main/java/com/createthumbnail/CreateThumbnailModule.java
@@ -63,12 +63,16 @@ public void create(ReadableMap options, Promise promise) {
             Bitmap image = retriever.getFrameAtTime(timeStamp * 1000, MediaMetadataRetriever.OPTION_CLOSEST_SYNC);
             retriever.release();
 
+            if (image == null) {
+                throw new IllegalStateException("File doesn't exist or not supported");
+            }
+
             File dir = new File(thumbnailDir);
             if (!dir.exists()) {
                 dir.mkdirs();
                 // Add .nomedia to hide the thumbnail directory from gallery
                 File noMedia = new File(thumbnailDir, ".nomedia");
-                file.createNewFile();
+                noMedia.createNewFile();
             }
 
             File file = new File(thumbnailDir, fileName);

diff --git a/example/.gitignore b/example/.gitignore
@@ -34,6 +34,7 @@ local.properties
 node_modules/
 npm-debug.log
 yarn-error.log
+yarn.lock
 
 # BUCK
 buck-out/

diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
@@ -182,7 +182,7 @@ PODS:
     - React-cxxreact (= 0.61.5)
     - React-jsi (= 0.61.5)
   - React-jsinspector (0.61.5)
-  - react-native-create-thumbnail (1.1.0):
+  - react-native-create-thumbnail (1.1.1):
     - React
   - React-RCTActionSheet (0.61.5):
     - React-Core/RCTActionSheetHeaders (= 0.61.5)
@@ -326,7 +326,7 @@ SPEC CHECKSUMS:
   React-jsi: cb2cd74d7ccf4cffb071a46833613edc79cdf8f7
   React-jsiexecutor: d5525f9ed5f782fdbacb64b9b01a43a9323d2386
   React-jsinspector: fa0ecc501688c3c4c34f28834a76302233e29dc0
-  react-native-create-thumbnail: 056455814fe07dc68a4d8051601724e5785a7127
+  react-native-create-thumbnail: 98493415cc6e722e80fee6522e5412857a1eed3b
   React-RCTActionSheet: 600b4d10e3aea0913b5a92256d2719c0cdd26d76
   React-RCTAnimation: 791a87558389c80908ed06cc5dfc5e7920dfa360
   React-RCTBlob: d89293cc0236d9cb0933d85e430b0bbe81ad1d72

diff --git a/example/ios/example.xcodeproj/project.pbxproj b/example/ios/example.xcodeproj/project.pbxproj
diff --git a/example/yarn.lock b/example/yarn.lock
diff --git a/index.d.ts b/index.d.ts
@@ -4,6 +4,7 @@ declare module "react-native-create-thumbnail" {
     timeStamp?: number;
     type?: "local" | "remote";
     format?: "jpeg" | "png";
+    dirSize?: number
   }
 
   export interface Thumbnail {

diff --git a/ios/CreateThumbnail.m b/ios/CreateThumbnail.m
@@ -25,6 +25,14 @@ @implementation CreateThumbnail
 
         UIImage *thumbnail = [self generateThumbImage:vidURL atTime:timeStamp];
 
+        if (thumbnail == nil) {
+            NSException *e = [NSException
+                exceptionWithName:@"FileNotSupportedException"
+                reason:@"File doesn't exist or not supported"
+                userInfo:nil];
+            @throw e;
+        }
+
         // Save to temp directory
         NSString* tempDirectory = [NSSearchPathForDirectoriesInDomains(NSCachesDirectory, NSUserDomainMask, YES) lastObject];
         tempDirectory = [tempDirectory stringByAppendingString:@"/thumbnails/"];
@@ -47,14 +55,6 @@ @implementation CreateThumbnail
             fullPath = [tempDirectory stringByAppendingPathComponent: [NSString stringWithFormat:@"thumb-%@.jpeg",[[NSProcessInfo processInfo] globallyUniqueString]]];
         }
 
-        if (data == nil) {
-            NSException *e = [NSException
-                exceptionWithName:@"FileNotSupportedException"
-                reason:@"File doesn't exist or not supported"
-                userInfo:nil];
-            @throw e;
-        }
-
         NSFileManager *fileManager = [NSFileManager defaultManager];
         [fileManager createFileAtPath:fullPath contents:data attributes:nil];
         resolve(@{

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "react-native-create-thumbnail",
   "title": "React Native Create Thumbnail",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "iOS/Android thumbnail generator with support for both local and remote videos",
   "main": "index.js",
   "scripts": {