-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign test for key retrieval via http #428
Conversation
e8b27dc
to
f6b4c3d
Compare
It looks like the travis-ci build is having problems installing ChefDK while setting up the test environment. This error makes it look like it might have a corrupt |
resources/manage.rb
Outdated
@@ -91,7 +91,7 @@ | |||
ssh_keys = [] | |||
if u['ssh_keys'] | |||
Array(u['ssh_keys']).each do |key| | |||
if key.start_with?('https') | |||
if key.start_with?('http') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we talked about this at the sous-chefs meeting on Jul 22 2019, the concern is MITM and if we want to support use cases pulling over http I think it needs to be a curl --insecure
type setup.
f6b4c3d
to
4cb60b0
Compare
Signed-off-by: Doug Knight <[email protected]>
4cb60b0
to
f5d5eb4
Compare
Sorry, I thought I wrapped this up long ago, but apparently I didn't update the PR. I added a prefix to non-ssl http, so it's now However, it appears that recent changes set |
Hmm I will try to dig into that issue if I can find some time this weekend. I imagine there has to be a way to give a list of resources that are expected to lack |
@majormoses that would be a sweet feature to have in test-kitchen |
BTW we're in the process of adopting this cookbook into Sous Chefs so please give us a week or so to get this repo ready for our automation. |
closing this due to age. please feel free to reopen if needed. |
Description
Revises test cookbook so that instead of downloading an individual's personal keys from GitHub, it
starts a web service and uses it to serve dedicated keys for validating that the
user_manage
resource can retrieve ssh keys via http.Issues Resolved
Resolves #427
Check List
See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD