fix: Memoize achievement inferencer #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a per-component instance singleton and memoizes it, as we only need to keep track of the initial states of the control panel. Also added a TODO comment for future refactoring to more modern React principles using component state and hooks.
RichDom2185
commented
Oct 8, 2024
Comment on lines
+41
to
+44
| const [initialAchievements, initialGoals] = useTypedSelector(state => [ | ||
| state.achievement.achievements, | ||
| state.achievement.goals | ||
| ]); |
There was a problem hiding this comment.
useTypedSelector automatically listens to any state changes and reruns the callback, resulting in a new instance of the inferencer created each time the state is updated. This led to the bugged behaviour where it could not keep track of the state of the newly added (unpublished) goals and achievements.
Pull Request Test Coverage Report for Build 11233333849Details
💛 - Coveralls |
boydanderson
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses a per-component instance singleton and memoizes it, as we only need to keep track of the initial states of the control panel.
Also added a TODO comment for future refactoring to more modern React principles using component state and hooks.
Closes #3060.
Type of change
Checklist