Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump React Ace to v12 #2905

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Bump React Ace to v12 #2905

wants to merge 16 commits into from

Conversation

RichDom2185
Copy link
Member

Description

Supersedes #2880.

Also did a bit of cleanup.

Our custom syntax highlighting is still broken at the moment but other syntax highlighting works.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Apr 7, 2024
@coveralls
Copy link

coveralls commented Apr 7, 2024

Pull Request Test Coverage Report for Build 8973439585

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 32.078%

Files with Coverage Reduction New Missed Lines %
src/commons/utils/AceHelper.ts 1 31.43%
src/commons/editor/Editor.tsx 4 38.41%
Totals Coverage Status
Change from base Build 8971907944: -0.03%
Covered Lines: 5006
Relevant Lines: 14652

💛 - Coveralls

@RichDom2185 RichDom2185 changed the title Bump React Ace to v11 Bump React Ace to v12 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants