Add title to footer #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sotte
requested changes
Oct 27, 2024
| end | ||
| -- add white spaces between title and slide number | ||
| local white_space_fill = string.rep(" ", width - title_len - #footer_nrs) | ||
| local footer_text = presentation_title .. white_space_fill .. footer_nrs |
There was a problem hiding this comment.
I always wanted to have this, but I was too lazy. Nice!
Comment on lines
+387
to
+403
| H.extract_title = function(slide) | ||
| local title = "" | ||
| for _, line in pairs(vim.split(slide, "\n")) do | ||
| -- if line is nonempty set it as title | ||
| if line:match("%S") then | ||
| title = line | ||
| break | ||
| end | ||
| end | ||
| -- strip any trailing whitespace | ||
| title = title:gsub("%s+$", "") | ||
| -- strip any starting * or # for org and md | ||
| title = title:gsub("^%*+%s*", "") | ||
| title = title:gsub("^#+%s*", "") | ||
| return title | ||
| end | ||
|
|
There was a problem hiding this comment.
The logic here is not quite apt to the task.
I opened the adoc file and got this title in the footer:
It works for md and org files. Let's make it work for adoc files as well.
Also I wonder if we can reuse the separator definitions from the config instead of having two very similar definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit hacky but extracts the title from the first line of the first slide.
It also left aligns the title and right aligns the slide nr.