Skip to content

Commit

Permalink
Merge pull request #221 from CondeNast/run-cleaner-tolerations
Browse files Browse the repository at this point in the history
feat(runCleaner): add tolerations to template
  • Loading branch information
fbritoferreira authored Jun 30, 2023
2 parents e9e8fc1 + 3e63eaa commit 4daf511
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/sorry-cypress/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: sorry-cypress
description: A Helm chart for Sorry Cypress
type: application
version: 1.13.3
version: 1.15.0
appVersion: 2.5.3
home: https://sorry-cypress.dev/
sources:
Expand Down
1 change: 1 addition & 0 deletions charts/sorry-cypress/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -280,4 +280,5 @@ For more information, refer to https://github.com/sendible-labs/sorry-cypress-ru
| `runCleaner.securityContext` | Privilege and access control for the runCleaner pod(s) | `{}` |
| `runCleaner.priorityClassName` | Name of the existing priority class to be used by runCleaner pod(s) | `""` |
| `runCleaner.podLabels` | Set additional labels for the runCleaner pod(s) | `{}` |
| `runCleaner.tolerations` | Set tolerations for pods | `[]` |
| `runCleaner.resources` | Resources to initialize the container | `{}` |
3 changes: 3 additions & 0 deletions charts/sorry-cypress/changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 1.15
- Set `runCleaner.tolerations` values

# 1.14
- Update app to version `2.5.3`

Expand Down
4 changes: 4 additions & 0 deletions charts/sorry-cypress/templates/cronjob-run-cleaner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ spec:
{{- if .Values.runCleaner.priorityClassName }}
priorityClassName: {{ .Values.runCleaner.priorityClassName }}
{{- end }}
{{- with .Values.runCleaner.tolerations }}
tolerations:
{{ toYaml . | nindent 12 }}
{{- end }}
containers:
- name: sorry-cypress-run-cleaner
image: "{{ .Values.runCleaner.image.repository }}:{{ .Values.runCleaner.image.tag }}"
Expand Down
2 changes: 2 additions & 0 deletions charts/sorry-cypress/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,8 @@ runCleaner:
# Name of the existing priority class to be used by pod(s)
priorityClassName: ""

tolerations: []

resources:
{}
# We usually recommend not to specify default resources and to leave this as a conscious
Expand Down

0 comments on commit 4daf511

Please sign in to comment.