Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate etcd to use 'etcd-io/etcd' and update relevant paths #838

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davissp14
Copy link

Given the coreos/etcd client was deprecated back in 2015, let's work to move to etcd-io/etcd.

@davissp14
Copy link
Author

make tests in Agola are failing with:

panic: codecgen version mismatch: current: 8, need 10. Re-generate file: /go/pkg/mod/github.com/coreos/[email protected]+incompatible/client/keys.generated.go
goroutine 1 [running]:

Not quite sure what to do about that. Tests work fine locally.

@sgotti
Copy link
Member

sgotti commented Jul 15, 2021

@davissp14 Thanks for the PR. Sorry but I don't understand the title and why this is needed. We're already using for etcdv3 go.etcd.io/etcd client v3, just the 3.4 version with a workaround since only from the recently released etcd v3.5 they fixed the wrong module path (missing /v3).
github.com/coreos/etcd is used for etcdv2 and required by libkv.

@davissp14
Copy link
Author

davissp14 commented Jul 15, 2021

@sgotti My mistake, the dependencies here are a little confusing... For context, I have a fork where i'm introducing the ability to specify Store specific credentials for Etcd. I was not able to get authentication to work properly using the current client version. Bumping to 3.5 seems to have addressed my issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants