Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.types.ChoiceAttribute: log the invalid value if validation fails #2624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

config.types.ChoiceAttribute: log the invalid value if validation fails #2624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sopel/config/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,10 @@ def parse(self, value):
if value in self.choices:
return value
else:
raise ValueError('Value must be in {}'.format(self.choices))
raise ValueError(
'{!r} is not one of the valid choices: {}'
.format(value, ', '.join(self.choices))
)

def serialize(self, value):
"""Make sure ``value`` is valid and safe to write in the config file.
Expand All @@ -662,7 +665,10 @@ def serialize(self, value):
if value in self.choices:
return value
else:
raise ValueError('Value must be in {}'.format(self.choices))
raise ValueError(
'{!r} is not one of the valid choices: {}'
.format(value, ', '.join(self.choices))
)


class FilenameAttribute(BaseValidated):
Expand Down
Loading