Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools.target: don't clobber existing permissions in Channel.add_user() #2563

Closed
wants to merge 2 commits into from
Closed

tools.target: don't clobber existing permissions in Channel.add_user() #2563

wants to merge 2 commits into from

Commits on Nov 15, 2023

  1. coretasks: move info request after JOINing new channel to new helper 

    Centralizing this removes a possible future pitfall: Updating what is
sent in response to the bot joining a new channel in one location but
not in another.

This better positions us to conditionally decide (based on e.g. enabled
capabilities or ISUPPORT tokens) what to request from the server.
    @dgw
    dgw committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1a08084 View commit details
    Browse the repository at this point in the history

  2. tools.target, test: avoid race if MODE modifies privs before WHOREPLY 

    Test case slightly modified from the one in the relevant bug report.
Reporter gets a co-authorship for providing it, as it was very helpful.

Co-authored-by: half-duplex <[email protected]>
    @dgw @half-duplex
    dgw and half-duplex committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0a2adab View commit details
    Browse the repository at this point in the history