tld: fix regressions from type-hint cleanup #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't return an attribute that's been deleted, can we? Indeed not.
dict.update() returns None, not the updated dict, so the requests.get() call was passed params=None, leading the API to respond with an HTML "MediaWiki API Help" page instead of the desired JSON-ized article.
dgw
added
Medium Priority
Bugfix
Exirel
approved these changes
Jul 12, 2023
SnoopJ
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix regressions in the
tldplugin from #2471. Mea culpa…Checklist
make qa(runsmake qualityandmake test).tldcache updatespat an error into the bot log.tldcache updateyields DEBUG level log messages indicating successNotes
Kinda broke the parser in 3ffe55c, then hid that error by breaking the data fetch too in c24dfa2 when I tried to get too smart with one-line statements.