Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional tox configuration #2469

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Add optional tox configuration #2469

merged 2 commits into from
Jul 14, 2023

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Jun 9, 2023

Description

This PR adds a tox configuration for use with Sopel. It's dgw's fault!

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
    • toxfile.py does include some plugin code licensed under MIT, not sure if that is a problem in contrib/
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

contrib/tox.ini Show resolved Hide resolved
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This being contrib/, I won't nitpick too much. I like to trust that contrib/ stuff already works for the person submitting it, or they wouldn't submit it.

I do still have housekeeping stuff to say, though: What are these commit messages? Where is your module: prefix? 😛

contrib/toxfile.py Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
contrib/README.md Outdated Show resolved Hide resolved
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit worth mentioning, but I think this is ready once squashed to a sane history with the correct "module" prefixes.

contrib/README.md Outdated Show resolved Hide resolved
@dgw dgw merged commit c26914b into sopel-irc:master Jul 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants