Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload: fix issue with reloading modules within subpackage #1398

Closed

Commits on Apr 7, 2018

  1. reload: Recurse into packaged modules

    Force-reload all sub-modules of packages recursively.
    
    See sopel-irc#1056.
    dgw committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    142cb4d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. reload: fix issue with reloading modules within subpackage

    sopel-irl#1314 used recursion to reload nested modules. However, in Python 2 (maybe python 3 as well), this approach leads to odd behavior with callables being unloaded/reloaded twice. The loop detects my_module.my_callable and my_callable as two separate modules to reload. The first time it detects it, the rule is added to bot._callables as a string.
    I combined patched dgw branch 1056-no-dupes onto 1056-fix-with-recursion, to provide a more optimal solution to issue sopel-irc#1056.
    Humorous Baby committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    8845786 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    513aa25 View commit details
    Browse the repository at this point in the history