Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting: include title in assignee, label, & milestone webhooks #79

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 25, 2020

New utility function get_issue_or_pr_title() because of course GitHub can't just give us one place to get fields that are common to all issues including pull requests. Let's only use it when necessary…

I'll say this resolves #52, and let @half-duplex complain in a new issue (or #25) if I missed any spots. 😛

New utility function `get_issue_or_pr_title()` because of course GitHub
can't just give us one place to get fields that are common to all issues
including pull requests. Let's only use it when necessary...
@dgw dgw added this to the 0.4.0 milestone Oct 25, 2020
@half-duplex
Copy link
Member

Seems reasonable, though may need a length cap at some point?

@dgw
Copy link
Member Author

dgw commented Oct 29, 2020

Possibly. But the title would need to be (at a guess) 2-300 characters bytes before that became an issue. I'm OK leaving it as-is.

@dgw dgw merged commit 1e2fe09 into master Nov 2, 2020
@dgw dgw deleted the more-titles-in-more-places branch November 2, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More messages need issue/PR titles
2 participants