SONIC PAC WPA Supplicant updates for Hostapd #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samitabh
changed the title
kcudnik
reviewed
Oct 3, 2023
|
|
||
| #define RADIUS_VALUE_LENGTH 253 | ||
|
|
||
| #define RADIUS_ATTR_TYPE_USER_NAME 1 |
There was a problem hiding this comment.
Is this file copy from somewhere or those are type should be an enum instead of defines
There was a problem hiding this comment.
And many others defines as enums
kcudnik
reviewed
Oct 3, 2023
| MKA_PEER_TIMEOUT | ||
| } clientStatus_t; | ||
|
|
||
| typedef enum radiusAttrFlags_s |
There was a problem hiding this comment.
Why there is _s suffix at the end ?
kcudnik
reviewed
Oct 3, 2023
|
|
||
| typedef struct in4_addr_s | ||
| { | ||
| unsigned int s_addr; /* 32 bit IPv4 address in network byte order */ |
There was a problem hiding this comment.
Why not use addr directly instead of 1 struct item ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.