Add timeout for rexec's get_password (#3484) #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What I did I added a timeout setting for the get_password function in rexec module so that automatic pipelines that does not expect password input will not get blocked. The current timeout setting is 10 sec. #### How I did it Add a SIGALRM signal before waiting for password input. #### How to verify it Run a "show ip bgp summary" on SONiC Chassis Supversior and does not input password until it times out. #### Previous command output (if the output of a command-line utility has changed) Before adding such a mechanism, if you do not input password when run "rexec -c <cmd>" you will be blocked at the following output: ``` Since the current device is a chassis supervisor, this command will be executed remotely on all linecards Password for username 'XXX': ``` #### New command output (if the output of a command-line utility has changed) After adding such a mechanism, if you do not input password when run "rexec -c <cmd>" you will see a timeout message after 10 seconds. ``` Since the current device is a chassis supervisor, this command will be executed remotely on all linecards Password for username 'XXX': Aborted! Timeout when waiting for password input. ```
gechiang
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added a timeout setting for the get_password function in rexec module so that automatic pipelines that does not expect password input will not get blocked. The current timeout setting is 10 sec.
How I did it
Add a SIGALRM signal before waiting for password input.
How to verify it
Run a "show ip bgp summary" on SONiC Chassis Supversior and does not input password until it times out.
Previous command output (if the output of a command-line utility has changed)
Before adding such a mechanism, if you do not input password when run "rexec -c " you will be blocked at the following output:
New command output (if the output of a command-line utility has changed) After adding such a mechanism, if you do not input password when run "rexec -c " you will see a timeout message after 10 seconds.