Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UT test_config_reload_untriggered_timer #81

This pull request is big! We’re only showing the most recent 250 commits.

Commits on Dec 1, 2022

  1. Change show kube command default value of insecure key to True (#2517)

    * Change show kube command default value of insecure key to True
    
    Signed-off-by: Yun Li <[email protected]>
    
    * Add test cases
    
    Signed-off-by: Yun Li <[email protected]>
    lixiaoyuner authored and yxieca committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f2bf7ed View commit details
    Browse the repository at this point in the history
  2. [drop counters] Fix CLI script for unconfigured PGs (#2518)

    - What I did
    Since PG counters are created only if they are configured in the switch, it is not enough to relay only on the first entry in the DB when building the output table of watermarkstat script.
    We need to go over all configured counters, check what is the max configured and build the table accordingly.
    
    - How I did it
    Iterate all configured PG buffers for all ports and find the max index.
    Build the output table according to the max index.
    
    - How to verify it
    Run test "pgdropstat_test.py" including this PR and observe it passes.
    liorghub authored and yxieca committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    252910a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. [scripts/fast-reboot] Shutdown remaining containers through systemd (…

    …#2133)
    
    The current implementation has two issues:
    
    1. In case containers from "docker ps" output are ordered in a way that database is first in the list, the "systemctl stop database" followed by "docker kill database" will stop all other containers through systemd
    and ruin this optimization
    2. After "docker kill database" there are lots of errors from daemons like hostcfgd, system-healthd, caclmgrd, etc. Also it causes those daemons to hang when received SIGTERM making a delay on following "systemctl stop database".
    
    In the new implementation, services are implicitly stopped by systemd in the order that is correct. If a certain container needs an optimization that will kill the container instead of stopping it the container may implement this optimization in its /usr/local/bin/*.sh script.
    
    It is also more optimal since independent services might be stopped in parallel.
    
    - What I did
    Stop services using systemd
    
    - How I did it
    Stop services using systemd
    
    - How to verify it
    Run warm-reboot.
    
    Signed-off-by: Stepan Blyschak <[email protected]>
    stepanblyschak authored and yxieca committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    e3658e9 View commit details
    Browse the repository at this point in the history
  2. [GCU] Add RemoveCreateOnlyDependency Validator/Generator (#2500)

    What I did
    Add RemoveCreateOnlyDependency Generator and Validator.
    
    How I did it
    Added new validator/generator for handling the lane replacement case. The validator/generator understands that for which create-only fields and their dependencies need to be removed.
    
    How to verify it
    Unit Test.
    wen587 authored and yxieca committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    0391221 View commit details
    Browse the repository at this point in the history
  3. [generate_dump] [Mellanox] Fix the duplicate dfw dump collection prob…

    …lem by adding symlinks (#2536)
    
    - What I did
    Currently the dfw dumps which are usually saved under /var/log/mellanox/sdk-dumps are collect twice in the techsupport. Once under log/ and once under sai_sdk_dump/ folder.
    
    Fixed the scenario by creating a symbolic link from sai_sdk_dump/sai-dfw-xxxxxxxxx.tar.gz -> ../log/sai-dfw-xxxxxxxxx.tar.gz
    
    - How I did it
    dfw dumps are copied from syncd currently, but the logic is updated to collect files from the host if SAI_DUMP_STORE_PATH is mounted on the host
    Fixed the duplicate dfw dump collection problems by adding a relative symbolic link from sai-sdk-dump/ -> log/ folder.
    fw dump me collection is moved to a new function collect_mellanox_dfw_dumps which in run at the end i.e. after the files under /var/log are saved
    
    - How to verify it
    root@switch:/home/admin# show techsupport --verbose
    root@switch:/home/admin/sonic_dump_r-lionfish-13_20221202_081958/log# ls -Al | grep dfw
    -rw-r--r-- 1 root root  1841061 Dec  2 08:21 sai-dfw-1669685690.tar.gz
    root@switch:/home/admin/sonic_dump_r-lionfish-13_20221202_081958/sai_sdk_dump# ls -Al
    
    Signed-off-by: Vivek Reddy Karri <[email protected]>
    vivekrnv authored and yxieca committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    e53b32e View commit details
    Browse the repository at this point in the history
  4. [config] Add check in config interface ip command to block if the int…

    …erface is portchannel member (#2539)
    
    - What I did
    Added a check in config interface ip command to block if the interface is portchannel member
    
    - How I did it
    Added check in config handling
    
    - How to verify it
    Added UT to verify.
    dgsudharsan authored and yxieca committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    4b51e41 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. [azure-pipelines] update azp from buster to bullseye (#2455)

    Signed-off-by: maipbui [email protected]
    What I did
    Update to bullseye to use python 3.9
    How I did it
    Change pipeline from buster to bullseye
    How to verify it
    Pass PR build checker
    maipbui authored and yxieca committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    da870fc View commit details
    Browse the repository at this point in the history
  2. [202205][show]Fix show route return code on error (#2547)

    Porting of changes #2542 to 202205
    
    What I did
    Fix show route return command to return error code on failure cases. The parameter return_cmd=True in run_command will suppress the return code and return success even in error scenarios.
    
    How I did it
    When run command is called with return_cmd = True, modified its return to include return code, which can then be used to assess if there is an error by the caller
    
    How to verify it
    Added UT to verify it
    dgsudharsan authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    25d581e View commit details
    Browse the repository at this point in the history
  3. [202205][generate_dump]: Enhance show techsupport for cisco-8000 plat…

    …form (#2533)
    
    What I did
    Added cisco-8000 specific platform information to "show techsupport" tarfile
    
    How I did it
    Added collect_cisco_8000 function to scripts/generate_dump which filters out the wanted files from /usr/share/sonic/device/${platform} and saves them in the techsupport tarfile under sai subdirectory
    
    How to verify it
    Run "show techsupport" and grep sai in the generated techsupport tarfile
    
    Signed-off-by: Geert Vlaemynck <[email protected]>
    gvlaemyn authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    aaa8d25 View commit details
    Browse the repository at this point in the history
  4. [202205][route_check]: Ignore ASIC only SOC IPs (cherry-picking #2548…

    …) (#2552)
    
    * [202205][route_check]: Ignore ASIC only SOC IPs (cherry-picking #2548)
    
    * [tests]: Improve route check test
    
    - Split test into separate methods based on functionality being tested
    - Parametrize main test method for better granularity when viewing results/running test cases
    - Add config DB mocking support
    - Move some setup/teardown code to fixtures for better consistency
    - Extract test data to separate file
    - Ignore routes for SOC IPs that are only present in the ASIC
    - Add test case to cover ASIC only SOC IPs
    
    Signed-off-by: Lawrence Lee <[email protected]>
    
    Signed-off-by: Lawrence Lee <[email protected]>
    Co-authored-by: Lawrence Lee <[email protected]>
    yxieca and theasianpianist authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    2c29fde View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. [muxcable][show] update show mux tunnel-route to separate ASIC and …

    …kernel into two columns (#2553)
    
    Stemming from sonic-net/sonic-swss#2557.
    
    This PR is to update show mux tunnel-route command to show status of both ASIC and kernel tunnel routes.
    
    sign-off: Jing Zhang [email protected]
    
    What I did
    How I did it
    How to verify it
    Previous command output (if the output of a command-line utility has changed)
    Only check Kernel Route, if removing tunnel route for server_ipv4 in kernel, it won't show in CMD output:
    
    zhangjing@********************:~$ show mux tunnel-route Ethernet4
    PORT       DEST_TYPE    DEST_ADDRESS
    ---------  -----------  --------------------------------
    Ethernet4  server_ipv6  2603:10b0:d11:8614::a32:9112/128
    New command output (if the output of a command-line utility has changed)
    Check both ASIC and APP DB for tunnel route status
    
    zhangjing@********************:~$ show mux tunnel-route Ethernet4
    PORT       DEST_TYPE    DEST_ADDRESS                      kernel    asic
    ---------  -----------  --------------------------------  --------  ------
    Ethernet4  server_ipv4  10.50.145.18/32                   -         added
    Ethernet4  server_ipv6  2603:10b0:d11:8614::a32:9112/128  added     added
    zjswhhh authored and yxieca committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    efd2ab8 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. [db_migrator] Fix migration of Loopback data: handle all Loopback int…

    …erfaces (#2560)
    
    Fix the issue where cross branch upgrades (base DB version 1_0_1) lead to a OA crash due to a duplicate IP2ME route being added when there are more than one Loopback interfaces.
    
    The issue happens as in current implementation lo is hardcoded to be replaced as Loopback0.
    When the base image's APP DB has more than one IP assigned to lo interface, upon migration, all the IPs are assinged to same loopback Loopback0. This is incorrect, as in newer images different IPs are assinged to distinct Loopback interfaces.
    
    How to verify it
    Verified on a physical testbed that this change fixes the OA crash issue.
    Also added a unit test to catch this issue in PR tests.
    vaibhavhd authored and yxieca committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    f40d82f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. [202205] [generate_dump] Optimize the execution time of the 'show tec…

    …hsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562)
    
    - What I did
    Optimize the execution time of the 'show techsupport' script to 5-10%.
    
    - How I did it
    The show techsupport CLI command calls the generate_dump bash script. In the script, there are a many functions that do the next scenario:
    
    1. Run some CLI command
    2. Save output from step 1 to the temporary file
    3. Append the temporary file from step 2 to the `/var/dump/sonic_dump_XXXX.tar` file
    4. Delete the temporary file from step 2
    This PR removes the 3 and 4 step from those functions and creates a new function save_to_tar() which will add to .tar archive the whole directory with temporary files (which means it will not spawn a tar -v -rhf ... process for each temporary file)
    
    - How to verify it
    Run the time show techsupport CLI command and compare the execution time to the original script, the execution time will be decreased by 5-10%.
    
    Signed-off-by: Vadym Hlushko <[email protected]>
    vadymhlushko-mlnx authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    93172c4 View commit details
    Browse the repository at this point in the history
  2. [202205]Fixes #12170: Delete subinterface and recreate the subinterfa…

    …ce in default-vrf (#2564)
    
    * Fixes #12170: Delete subinterface and recreate the subinterface  in default-vrf while unbinding subinterface from user defined vrf.
    dgsudharsan authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    67cbb15 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. [generate_dump] Optimize the execution time of 'show techsupport' CLI…

    … by paraller function execution (#2565)
    
    - What I did
    Optimize the execution time of the 'show techsupport' script.
    
    - How I did it
    The show techsupport CLI command calls the generate_dump bash script. In the script, there are a many functions that do the next scenario:
    
    1. Run some CLI command
    2. Save output from step 1 to the temporary file
    3. Append the temporary file from step 2 to the `/var/dump/sonic_dump_XXXX.tar` file
    4. Delete the temporary file from step 2
    This PR will add the execution of these functions in parallel manner. Also, it will not spawn too many processes to not waste all CPU time.
    
    - How to verify it
    First test scenario
    
    Run the `time show techsupport` CLI command and compare the execution time to the original script (with no parallelism), the execution time will be decreased by 10-20%.
    Second test scenario
    
    1. Stuck the FW by using next commands
    	a. mcra /dev/mst/mt52100_pci_cr0 0xa01e4 0x10
    	b. mcra /dev/mst/mt52100_pci_cr0 0xa05e4 0x10
    	c. mcra /dev/mst/mt52100_pci_cr0 0xa07e4 0x10
    	d. mcra /dev/mst/mt52100_pci_cr0 0xa09e4 0x10
    	e. mcra /dev/mst/mt52100_pci_cr0 0xa0be4 0x10
    	f. mcra /dev/mst/mt52100_pci_cr0 0xa0de4 0x10
    	g. mcra /dev/mst/mt52100_pci_cr0 0xa0fe4 0x10
    2. Run the `time show techsupport` CLI command and compare the execution time to the original script (with no parallelism), the execution time will be decreased by up to 50% because inside the script we launch CLI commands with `timeout --foreground 5m`. 
    
    Signed-off-by: Vadym Hlushko <[email protected]>
    vadymhlushko-mlnx authored Dec 26, 2022
    Configuration menu
    Copy the full SHA
    f45dcfb View commit details
    Browse the repository at this point in the history
  2. [202205] [timer.unit.j2] use wanted-by in timer unit (#2561)

    - What I did
    I fixed the timer unit template to account "wanted-by" option in the manifest. In case service is delayed, "wanted-by" is applied to the timer unit that delays it.
    
    - How I did it
    I updated timer.unit.j2 template
    
    - How to verify it
    Make sure that "WantedBy" is rendered in the timer unit.
    
    Signed-off-by: Stepan Blyschak <[email protected]>
    stepanblyschak authored Dec 26, 2022
    Configuration menu
    Copy the full SHA
    f7988b0 View commit details
    Browse the repository at this point in the history
  3. [202205] Fix issue: unconfigured PGs are displayed in watermarkstat (…

    …#2568)
    
    This is to cherry-pick #2556 to 202205
    All the PGs between minimal and maximal indexes are displayed regardless of whether they are configured.
    Originally, watermark counters were enabled for all PGs, so there is no issue.
    Now, watermark counters are enabled only for PGs with buffer configured, eg. if PG 0/2/3/4/6, is configured, PG 0-6 will be displayed, which is confusing by giving users a feeling that PG 7 is lost
    
    - How I did it
    Display valid PGs only
    
    - How to verify it
    Manually test and unit test.
    
    - Previous command output (if the output of a command-line utility has changed)
           Port    PG0    PG1    PG2    PG3    PG4
    -----------  -----  -----  -----  -----  -----
     Ethernet0      0      0      0      0      0
     Ethernet2      0      0      0      0      0
     Ethernet8      0      0      0      0      0
    Ethernet10      0      0      0      0      0
    Ethernet16      0      0      0      0      0
    Ethernet18      0      0      0      0      0
    Ethernet32      0      0      0      0      0
    
    - New command output (if the output of a command-line utility has changed)
    PG1 won't be displayed if it is not configured
    
           Port    PG0    PG3    PG4
    -----------  -----  -----  -----
     Ethernet0      0      0      0
     Ethernet2      0      0      0
     Ethernet8      0      0      0
    Ethernet10      0      0      0
    Ethernet16      0      0      0
    Ethernet18      0      0      0
    Ethernet32      0      0      0
    
    Signed-off-by: Stephen Sun <[email protected]>
    stephenxs authored Dec 26, 2022
    Configuration menu
    Copy the full SHA
    9f2984a View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. [202205][generate_dump] Fix for a deletion flow for all secret files …

    …in the techsupport dump (#2572)
    
    - What I did
    Fixed a deletion flow for all secret files in the tech support dump.
    
    - How I did it
    Delete files by using the find and rm Linux utilities.
    
    - How to verify it
    Run the show_techsupport/test_techsupport_no_secret.py
    
    Signed-off-by: Vadym Hlushko <[email protected]>
    vadymhlushko-mlnx authored Dec 29, 2022
    Configuration menu
    Copy the full SHA
    e1c8243 View commit details
    Browse the repository at this point in the history
  2. [Mellanox][202205] Change severity to NOTICE in Mellanox buffer migra…

    …tor when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization (#2569) (#2570)
    
    - What I did
    It is expected that db_migrator is not able to fetch DEVICE_METADATA when it is invoked before the CONFIG_DB is initialized. In this case, we should not use ERROR to log the message since it's not an error.
    Change the severity to NOTICE
    
    - How I did it
    Change the severity.
    
    - How to verify it
    Manually test.
    
    Signed-off-by: Stephen Sun <[email protected]>
    
    Signed-off-by: Stephen Sun <[email protected]>
    stephenxs authored Dec 29, 2022
    Configuration menu
    Copy the full SHA
    3bc2bc6 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. [202205] [sonic_installer] use /etc/resolv.conf from the host when mi…

    …grating packages (#2573) (#2575)
    
    What I did
    SONiC package migration has been failing due to the lack of DNS configuration for registries domain names.
    I used /etc/resolv.conf from host OS when migrating.
    
    Based on PR #2573
    
    How I did it
    Copy /etc/resolv.conf into new image filesystem during migration, then, restore it back.
    
    How to verify it
    Run sonic-installer install.
    liorghub authored Jan 3, 2023
    Configuration menu
    Copy the full SHA
    c9ed09d View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. [202205] Preserve copp tables through DB migration (#2524) (#2574)

    - What I did
    Preserve COPP table contents through DB migration. (Mellanox only)
    
    - How I did it
    Skipped deleting of COPP tables in DB migrator
    
    - How to verify it
    Observe COPP table contents are preserved right after reboot
    dprital authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3cb66b4 View commit details
    Browse the repository at this point in the history
  2. Add sonic-delayed.target to Application Extension .timer file generat…

    …or (#2176)
    
    - What I did
    Add sonic-delayed.target to sonic-application-extension .timer file generator
    This change will complete sonic-net/sonic-buildimage#7846 of sonic-delayed.target addition.
    
    - How I did it
    N/A
    
    - How to verify it
    Make sure your App Ext is part of "WantedBy" sonic-delayed.target
    noaOrMlnx authored and yxieca committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    9990208 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1fa31d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. [202205] Revert the show-techsupport optimization PR's (#2581)

    - What I did
    Reverted PRs because they caused the degradation that some files are missing in show techsupport archive.
    
    - How I did it
    Reverts the following 
    e1c8243 [202205][generate_dump] Fix for a deletion flow for all secret files in the techsupport dump (#2572)
    f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution (#2565)
    93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation (#2562)
    vadymhlushko-mlnx authored Jan 5, 2023
    Configuration menu
    Copy the full SHA
    dddd6c5 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. resolved conflicts (#2589)

    Signed-off-by: kannankvs <[email protected]>
    
    Signed-off-by: kannankvs <[email protected]>
    kannankvs authored Jan 11, 2023
    Configuration menu
    Copy the full SHA
    98dde31 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. [202205] Added a new option in show queue counters command to display…

    … voq statistics (#2591)
    
    * Enhanced queue stat to add an option to display voq statistics. When voq option is
      given look at COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to derive
      the queue information to lookup. Added a modified header for voq statistics.
    
    * Added a unit test for the new voq option.
    skbarista authored Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d8202e8 View commit details
    Browse the repository at this point in the history
  2. [storyteller] add link prober state change to story teller (#2585)

    What I did
    Add linkprober category to story teller. It will reflect dualtor heartbeat events.
    
    sign-off: Jing Zhang [email protected]
    
    How to verify it
    Tested on dualtor device, was able to grep link prober state change events.
    zjswhhh authored and yxieca committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    7fc3fb7 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. [202205] Extend fast-reboot STATE_DB entry timer (#2578)

    This is a PR against 202205 based on the following PR: #2577
    Due to an issue of fallback from to cold-boot when using upgrade with fast-reboot combined with FW upgrade a short term solution is to extend the timer.
    An issue will be opened on this case with the full details, link will be added to the PR.
    Long term solution of using fast-reboot finalizer replacing the timer is in work.
    
    What I did
    Extend the timer of STATE DB fast-reboot entry to 210 seconds.
    
    How I did it
    Modify the TTL of the entry set in STATE DB.
    
    How to verify it
    Verify the entry was preserved for 210 seconds.
    arfeigin authored Jan 17, 2023
    Configuration menu
    Copy the full SHA
    0bc17f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Transceiver eeprom dom CLI modification to show output from TRANSCEIV…

    …ER_DOM_THRESHOLD table (#2535)
    
    * EEPROM CLI support to dump output from TRANSCEIVER_DOM_THRESHOLD table
    
    Signed-off-by: Mihir Patel <[email protected]>
    
    * Resolved test failures
    
    Signed-off-by: Mihir Patel <[email protected]>
    
    Signed-off-by: Mihir Patel <[email protected]>
    mihirpat1 authored and yxieca committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    7979b9b View commit details
    Browse the repository at this point in the history
  2. [show] Add bgpraw to show run all (#2537)

    #### What I did
    Add bgpraw output to `show runningconfiguration all`
    ```
    Requirements:
    1. current `show runningconfig` will print all the ConfigDB in a json format, we need to add a new key-value into the json output "bgpraw" with a long string value
    2. The long string value should be the output of `vtysh -c "show run"`. It is normally multiline string, may include special characters like \". Need to make sure the escaping properly
    3. We do not need to insert the key-value into ConfigDB is not existing there
    4. If ConfigDB already has the key-value, we do not need to override it by vtysh command output
    5. Not break multi-asic use
    ```
    #### How I did it
    Generate bgpraw output then append it to `show runnningconfiguration all`'s output
    #### How to verify it
    Mannual test
    #### Previous command output (if the output of a command-line utility has changed)
    ```
    admin@vlab-01:~$ show run all
    {
        "ACL_TABLE": {
    ......
        "WRED_PROFILE": {
            "AZURE_LOSSLESS": {
                "ecn": "ecn_all",
                "green_drop_probability": "5",
                "green_max_threshold": "2097152",
                "green_min_threshold": "1048576",
                "red_drop_probability": "5",
                "red_max_threshold": "2097152",
                "red_min_threshold": "1048576",
                "wred_green_enable": "true",
                "wred_red_enable": "true",
                "wred_yellow_enable": "true",
                "yellow_drop_probability": "5",
                "yellow_max_threshold": "2097152",
                "yellow_min_threshold": "1048576"
            }
        }
    }
    ```
    #### New command output (if the output of a command-line utility has changed)
    ```
    admin@vlab-01:~$ show run all
    {
        "ACL_TABLE": {
    ......
        "WRED_PROFILE": {
            "AZURE_LOSSLESS": {
                "ecn": "ecn_all",
                "green_drop_probability": "5",
                "green_max_threshold": "2097152",
                "green_min_threshold": "1048576",
                "red_drop_probability": "5",
                "red_max_threshold": "2097152",
                "red_min_threshold": "1048576",
                "wred_green_enable": "true",
                "wred_red_enable": "true",
                "wred_yellow_enable": "true",
                "yellow_drop_probability": "5",
                "yellow_max_threshold": "2097152",
                "yellow_min_threshold": "1048576"
            }
        },
        "bgpraw": "Building configuration...\n\nCurrent configuration......end\n"
    }
    ```
    wen587 authored and yxieca committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    3ebe948 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Revert "[show] Add bgpraw to show run all (#2537)"

    This reverts commit 3ebe948.
    yxieca committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    7e6e7ef View commit details
    Browse the repository at this point in the history
  2. [202205][show] Add bgpraw to show run all (#2609)

    What I did
    #2537
    202205 branch doesn't have from sonic_py_common import multi_asic, which results in test failure and build error.
    The only difference between this PR and original PR is just one line of import.
    
    How I did it
    How to verify it
    Tested locally on 202205 build and pass the build process.
    wen587 authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    2419145 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Revert "[202205][show] Add bgpraw to show run all (#2609)"

    This reverts commit 2419145.
    yxieca committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    1e3f38d View commit details
    Browse the repository at this point in the history
  2. [muxcable][config] Add support to enable/disable ceasing to be an adv…

    …ertisement interface when `radv` service is stopped (#2622)
    
    This PR is to add CLI support to enable or disable the feature to send out a good-bye packet when radv service is stopped on active-active dualtor devices.
    
    sign-off: Jing Zhang [email protected]
    zjswhhh authored and yxieca committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    c63a62b View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. [202205][show] Add bgpraw to show run all (#2624)

    What I did
    #2537
    #2623
    #2628
    
    202205 branch doesn't have from sonic_py_common import multi_asic, which results in test failure and build error.
    The only difference between this PR and original PR is just one line of import.
    
    How to verify it
    Tested locally on 202205 build and pass the build process.
    Test to make sure it pass GCU tests.
    wen587 authored Jan 30, 2023
    Configuration menu
    Copy the full SHA
    5e84f25 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Configuration menu
    Copy the full SHA
    5613277 View commit details
    Browse the repository at this point in the history
  2. [masic] 'show interfaces counters' reminds to use '-d all' option to …

    …check for internal links (#2466)
    
    Print reminder to check internal links on multi-asic platforms
    Signed-off-by: Wenyi Zhang <[email protected]>
    wenyiz2021 authored and yxieca committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    e0b3b4a View commit details
    Browse the repository at this point in the history
  3. Making 'show feature autorestart' more resilient to missing auto_rest…

    …art config in CONFIG_DB (#2592)
    
    Fixes BUG 762723
    kartik-arista authored and yxieca committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    28d7bb2 View commit details
    Browse the repository at this point in the history
  4. show logging CLI support for logs stored in tmpfs (#2641)

    * show logging CLI support for logs stored in tmpfs
    
    Signed-off-by: Mihir Patel <[email protected]>
    
    * Fixed testcase failures
    
    * Reverted unwanted change in a file
    
    * Added testcase for syslog.1 in log.tmpfs directory
    
    * mend
    
    ---------
    
    Signed-off-by: Mihir Patel <[email protected]>
    mihirpat1 authored and yxieca committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    557adfc View commit details
    Browse the repository at this point in the history
  5. multi asic support for show queue counter (#2647)

    Signed-off-by: Zhixin Zhu <[email protected]>
    zhixzhu authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2591e8b View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Add asic id for linecards so "show fabric counters queue/port" can wo…

    …rk for single chip systems (#2656)
    
    Add asic id for linecards so "show fabric counters queue/port" can work for single chip systems.
    
    This is from #2499. 2499 cannot be cherry-picked to 202205 branch cleanly. This PR is for merging up to 202205 branch.
    
    It looks like repeated work already in the branch when I tested locally.
    jfeng-arista authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    496a077 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ffb4b6 View commit details
    Browse the repository at this point in the history
  3. Filter port invalid MTU configuration (#2378)

    What I did
    Filter port invalid MTU configuration
    Adjust the MTU value to the range of [68,9216]
    pettershao-ragilenetworks authored and yxieca committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    a2252d8 View commit details
    Browse the repository at this point in the history
  4. [masic support] 'show run bgp' support for multi-asic (#2427)

    Support 'show run bgp' for multi-asics
    Add mock tables and UTs for single-asic, multi-asic, bgp not running cases
    wenyiz2021 authored and yxieca committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    32b1d4d View commit details
    Browse the repository at this point in the history
  5. Fixed admin state config CLI for Backport interfaces (#2557)

    Fixed admin state config CLI for Backport interfaces
    Fixes sonic-net/sonic-buildimage#13057
    anamehra authored and yxieca committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7772392 View commit details
    Browse the repository at this point in the history
  6. [show] add support for gRPC show commands for active-active (#2629)

    Signed-off-by: vaibhav-dahiya [email protected]
    This PR adds support for show mux hwmode muxdirection as well as
    show mux grpc muxdirection to show the state of gRPC connected to the SoCs for 'active-active' acble type
    
    
    vdahiya@sonic:~$ show mux grpc muxdirection 
    Port       Direction    Presence    PeerDirection    ConnectivityState
    ---------  -----------  ----------  ---------------  -------------------
    Ethernet0  active       False       active           READY
    vdahiya@sonic:~$ 
    vdahiya@sonic:~$ show mux grpc muxdirection --json
    {
        "HWMODE": {
            "Ethernet0": {
                "Direction": "active",
                "Presence": "False",
                "PeerDirection": "active",
                "ConnectivityState": "READY"
            }
        }
    }
    
    What I did
    Added support for the commands.
    
    How I did it
    How to verify it
    UT and running the changes on Testbed
    vdahiya12 authored and yxieca committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e949f31 View commit details
    Browse the repository at this point in the history
  7. [sai_failure_dump]Invoking dump during SAI failure (#2633)

    * Added logic in techsupport script to collect SAI failure dump
    dgsudharsan authored and yxieca committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2c933b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (#266…

    …0) (#2669)
    
    Why I did
    Currently, add/del a vlan doesn't change related dhcpv6_relay config, which is incorrect.
    
    How I did it
    1. Add dhcp_relay table init entry while adding vlan
    2. Delete dhcp_relay related config while deleting vlan
    3. Add unitest
    
    How to verify it
    1. By unitest
    2. install whl and run cli
    
    Signed-off-by: Yaqiang Zhu <[email protected]>
    yaqiangz authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e61c5ec View commit details
    Browse the repository at this point in the history
  2. Skip saidump for Spine Router as this can take more than 5 sec (#2637…

    …) (#2671)
    
    To address sonic-net/sonic-buildimage#13561 skip saidump on T2 platforms for time-being.
    
    Co-authored-by: abdosi <[email protected]>
    kenneth-arista and abdosi authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4f07f7f View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. [202205][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table w…

    …hile adding vlan (#2680)
    
    Cherry-pick of this PR: #2678
    What I did
    Remove add field of vlanid to DHCP_RELAY table while add vlan which would cause conflict with yang model.
    
    How I did it
    Remove add field of vlanid to DHCP_RELAY table while add vlan
    
    How to verify it
    By unit tests
    
    Signed-off-by: Yaqiang Zhu <[email protected]>
    yaqiangz authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    3587a94 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Configuration menu
    Copy the full SHA
    4e3bb6f View commit details
    Browse the repository at this point in the history
  2. [portstat CLI] don't print reminder if use json format (#2670)

    * no print if use json format
    * add print for chassis
    wenyiz2021 authored and yxieca committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    8aa7930 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947) (…

    …#2349)
    
    * [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947)
    
    - Description
    Checking that the running image is switched or not after CDB_run during firmware upgrade process.
    
    - Motivation and Context
    CDB_run will maybe cause several seconds NACK or stretching on i2c bus which depend on the implementation of module vendor, checking the status after CDB_run for compatible with different implementation.
    
    * Update unit tests for sfputil.
    
    Test : Creating "is_fw_switch_done" test, this function expected to return 1 when 'status' == True and running image('result'[1, 5]) different with committed('result'[2, 6]) one, otherwise return -1.
    
    * [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947)
    
    - Description
    Adding error judgements in "is_fw_switch_done" function.
    Update unit tests for "is_fw_switch_done".
    
    - Motivation and Context
    Checking status of images to avoid committing image with a wrong status.
    
    * [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947)
    
    Fixing : Comparing error code with a wrong variable.
    Refactor : Renaming variables for more suitable its purpose.
    Refactor : Removing if case which is low correlation with function.
    Feat : Adding "echo" to display detail result.
    
    * Update unit tests for sfputil.
    
    * [sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947)
    
    Feat : Reducing frequency of check during "is_fw_switch_done".
    Refactor : Removing a repeated line.
    CliveNi authored and yxieca committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    a4f141f View commit details
    Browse the repository at this point in the history
  2. removed duplicates and resolved conflicts (#2674)

    Signed-off-by: kannankvs <[email protected]>
    kannankvs authored Mar 1, 2023
    Configuration menu
    Copy the full SHA
    69a6039 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. [db_migrator] Add missing attribute 'weight' to route entries in APPL…

    … DB (#2691)
    
    Fixes: 201911 to 202205 warm upgrade failure in fpmsyncd reconciliation due to missing weight attr in routes. (sonic-net/sonic-buildimage#12625)
    
    How I did it
    Check for missing attribute weight in APPLDB route entries. If found missing this attribute is added with empty value.
    
    How to verify it
    Verified on physical device. 201911 to 202205 upgrade worked fine.
    vaibhavhd authored and yxieca committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4bd7d4f View commit details
    Browse the repository at this point in the history
  2. [ci] Fix pipeline issue caused by sonic-slave-* change. (#2709)

    What I did
    These 3 packages maybe purged by default. Do not block pipeline.
    Download deb/whl packages only to accelerate download process.
    How I did it
    How to verify it
    liushilongbuaa authored and yxieca committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    03aa77b View commit details
    Browse the repository at this point in the history
  3. [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm sh…

    …utdown (#2714)
    
    Goal: Preserve logs during TOR upgrades and shutdown
    
    Need:
    
    Below PRs moved logs from disk to tmpfs for specific hwskus.
    Due to these changes, shutdown path logs are now lost.
    The logs in shutdown path are crucial for debug purposes.
    
    sonic-net/sonic-buildimage#13805
    sonic-net/sonic-buildimage#13587
    sonic-net/sonic-buildimage#13587
    
    How I did it
    Check if logs are on tmpfs. If yes, backup logs from /var/log
    
    How to verify it
    Verified on a physical device - logs on tmfs are backed up for past 30 minutes.
    vaibhavhd authored and yxieca committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    51d9c9f View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. execute a platform-provided pre-reboot script before shutting down sw…

    …ss (#2708)
    
    * Update fast-reboot
    
    give platform chance to do proper cleanup before shutting down swss in warm/fast-reboot
    
    * Update fast-reboot
    jhli-cisco authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7c66b29 View commit details
    Browse the repository at this point in the history
  2. [202205][dhcp_relay] Fix dhcp_relay restart error while add/del vlan …

    …(#2688) (#2707)
    
    Why I did
    Cherry-pick and resolve conflicts of this PR: #2688
    In device that doesn't have dhcp_relay service, restart dhcp_relay after add/del vlan would encounter failed
    
    How I did it
    Add support to check whether device is support dhcp_relay service.
    
    How to verify it
    1. Unit test
    2. Build and install in device
    
    Signed-off-by: Yaqiang Zhu <[email protected]>
    yaqiangz authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b8072ea View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. [202205] Remove timer from FAST_REBOOT STATE_DB entry and use finaliz…

    …er (#2724)
    
    Dedicated PR for 202205 branch similar to #2621 as part of fast-reboot finalizer implementation.
    
    This should come along with sonic-buildimage PR implementing fast-reboot finalizing logic in finalize-warmboot script and other submodules PRs utilizing the change.
    
    This PR should come along with the following PRs as well:
    sonic-net/sonic-sairedis#1217
    sonic-net/sonic-platform-daemons#343
    sonic-net/sonic-buildimage#14143
    
    This set of PRs solves the issue sonic-net/sonic-buildimage#13251
    
    What I did
    Remove the timer used to clear fast-reboot entry from state-db, instead it will be cleared by fast-reboot finalize function implemented inside finalize-warmboot script (which will be invoked since fast-reboot is using warm-reboot infrastructure).
    
    As well instead of having "1" as the value for fast-reboot entry in state-db and deleting it when done it is now modified to set enable/disable according to the context.
    
    As well all scripts reading this entry should be modified to the new value options.
    
    How I did it
    Removed the timer usage in the fast-reboot script and adding fast-reboot finalize logic to warm-reboot in the linked PR.
    Use "enable: true/false" instead of "1" as the entry value.
    
    How to verify it
    Run fast-reboot and check that the state-db entry for fast-reboot is being deleted after finalizing fast-reboot and not by an expiring timer.
    arfeigin authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6f05f7e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. [202205] Fix fast-reboot DB migration (#2733)

    Fix DB migrator logic for migrating fast-reboot table, fixing #2724 db_migrator.
    
    How I did it
    Checking if fast-reboot table exists in DB.
    
    How to verify it
    Verified manually, migrating after fast-reboot and after cold/warm reboot.
    arfeigin authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    f861364 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Enhance the logic to wait for all buffer tables to be removed in _cle…

    …ar_qos (#2720)
    
    - What I did
    This is an enhancement of PR #2503
    
    - How I did it
    On top of waiting for BUFFER_POOL_TABLE to be cleared from APPL_DB, we need to wait for KEY_SET and DEL_SET as well.
    KEY_SET and DEL_SET are designed to accommodate the APPL_DB entries that were updated by manager daemons but have not yet been handled by the orchagent.
    In this case, even if the buffer tables are empty, entries in KEY_SET or DEL_SET will be in the buffer tables later on. So, we need to wait for key set tables as well.
    Do not delay for traditional buffer manager because it does not remove any buffer table.
    Provide a CLI option to print the detailed message if there is any table item which still exists
    
    - How to verify it
    Manually test and unit test
    
    - Previous command output (if the output of a command-line utility has changed)
    Running command: /usr/local/bin/sonic-cfggen  -d --write-to-db -t /usr/share/sonic/device/x86_64-mlnx_msn2410-r0/ACS-MSN2410/buffers_dynamic.json.j2,config-db -t /usr/share/sonic/device/x86_64-mlnx_msn2410-r0/ACS-MSN2410/qos.json.j2,config-db -y /etc/sonic/sonic_version.yml
    
    - New command output (if the output of a command-line utility has changed)
    Only with option --verbose there are new output. Without the option, the output is the same as it is.
    
    admin@mtbc-sonic-01-2410:~$ sudo config qos  reload --verbose 
    Some entries matching BUFFER_*_TABLE:* still exist: BUFFER_QUEUE_TABLE:Ethernet108:0-2
    Some entries matching BUFFER_*_SET still exist: BUFFER_PG_TABLE_KEY_SET
    Some entries matching BUFFER_*_TABLE:* still exist: BUFFER_QUEUE_TABLE:Ethernet108:0-2
    Some entries matching BUFFER_*_SET still exist: BUFFER_PG_TABLE_KEY_SET
    Some entries matching BUFFER_*_TABLE:* still exist: BUFFER_QUEUE_TABLE:Ethernet108:0-2
    Running command: /usr/local/bin/sonic-cfggen  -d --write-to-db -t /usr/share/sonic/device/x86_64-mlnx_msn2410-r0/ACS-MSN2410/buffers_dynamic.json.j2,config-db -t /usr/share/sonic/device/x86_64-mlnx_msn2410-r0/ACS-MSN2410/qos.json.j2,config-db -y /etc/sonic/sonic_version.yml
    stephenxs authored and yxieca committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    738406b View commit details
    Browse the repository at this point in the history
  2. Improve show acl commands (#2667)

    * Add status for ACL_TABLE and ACL_RULE in STATE_DB
    bingwang-ms authored and yxieca committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f88ca1c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. updated "show interfaces transceiver" command usage parameter in Comm…

    …and-Reference.md (pr2655 for 202205 CLI guide update) (#2723)
    
    * updated pr2655 for 202205 CLI guide
    
    updated pr2655 for 202205 CLI guide
    
    Signed-off-by: kannankvs <[email protected]>
    kannankvs authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    666f958 View commit details
    Browse the repository at this point in the history
  2. [202205][generate_dump] Revert "Revert generate_dump optimization PR'…

    …s #2581", add fixes for empty /dump forder and symbolic links (#2711)
    
    * Revert "[202205] Revert the show-techsupport optimization PR's (#2581)"
    
    This reverts commit dddd6c5.
    
    * [generate_dump] Fix for empty /dump folder
    
    Signed-off-by: vadymhlushko-mlnx <[email protected]>
    
    * [generate_dump] Fix for symlinks in collect_mellanox_dfw_dumps()
    
    Signed-off-by: vadymhlushko-mlnx <[email protected]>
    
    ---------
    
    Signed-off-by: vadymhlushko-mlnx <[email protected]>
    vadymhlushko-mlnx authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    90e00ea View commit details
    Browse the repository at this point in the history
  3. [show][muxcable] increase timeout for displaying HW_STATUS (#2712)

    What I did
    probe mux direction not always return success.
    
    Sample output of: while [ 1 ]; do date; show mux hwmode muxdirection; show mux status; sleep 1; done
    
    Mon 27 Feb 2023 03:12:25 PM UTC
    Port         Direction    Presence
    -----------  -----------  ----------
    Ethernet16   unknown      True
    
    PORT         STATUS    HEALTH    HWSTATUS      LAST_SWITCHOVER_TIME
    -----------  --------  --------  ------------  ---------------------------
    Ethernet16   standby   healthy   inconsistent  2023-Feb-25 07:55:18.269177
    If we increase the timeout to 0.5 secs to get the values back from ycabled, this will remove the inconsistency issue, and display the consistent values, because while telemetry is going on, the time to get actual mux value takes significantly longer than 0.1 seconds.
    
    PORT         STATUS    HEALTH    HWSTATUS      LAST_SWITCHOVER_TIME
    -----------  --------  --------  ------------  ---------------------------
    Ethernet16   standby   healthy   consistent  2023-Feb-25 07:55:18.269177
    How I did it
    How to verify it
    Manually run changes on setup
    worst-case CLI return time could be 16 seconds for 32 ports. on avg each port is 200 mSec if telemetry is going, but on average show command will return in < 1 sec for all 32 ports.
    
    Signed-off-by: vaibhav-dahiya <[email protected]>
    vdahiya12 authored and yxieca committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    077de53 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. [202205] Add transceiver info CLI support to show output from TRANSCE…

    …IVER_INFO for ZR (#2740)
    mihirpat1 authored Mar 17, 2023
    Configuration menu
    Copy the full SHA
    89012b8 View commit details
    Browse the repository at this point in the history
  2. Revert "Update load minigraph to load backend acl (#2236)" (#2735)

    This reverts commit 1518ca9.
    neethajohn authored and yxieca committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    14428fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42a57f4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. [202205] Fast-reboot: preserve connected routes and set teamd timer t…

    …o minimum. (#2744)
    
    Added a script to filter routes: preserve default routes (was already done as part of fast-reboot script) and connected routes.
    Set teamd timer to minimal allowed value (1 second) for fast-reboot.
    Both made in order to shorten dataplane downtime.
    
    How I did it
    fast-reboot-filter-routes.py was added to preserve connected and default routes and is being called from fast-reboot script.
    teamd-timer is set when setting fast-reboot.
    
    How to verify it
    Community fast-reboot test.
    stepanblyschak authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    3293866 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. [warm-reboot] fix warm-reboot when /tmp/cache is missing (#2367)

    - What I did
    Fixed issue when cache wasn't generated and warm reboot command fails.
    Fixes sonic-net/sonic-buildimage#11914
    
    - How I did it
    Added a check for cache existence
    
    - How to verify it
    Run warm-reboot
    
    Signed-off-by: Stepan Blyschak <[email protected]>
    stepanblyschak authored and yxieca committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    93f1d74 View commit details
    Browse the repository at this point in the history
  2. [warm-reboot] Use kexec_file_load instead of kexec_load when availabl…

    …e (#2608)
    
    On some dev VMs, warm reboot on a VS image fails. Specifically, after
    kexec is called and the new kernel starts, the new kernel tries to load
    the initramfs, but fails to do so for whatever reason. There may be
    messages about gzip decompression failing and that it's corrupted.
    
    After some experimentation, it was found that when first loading the new
    kernel and initramfs into memory, using the `kexec_file_load` syscall
    (`-s` flag in kexec) worked fine, whereas using the default `kexec_load`
    syscall resulted in a failure. It's unknown why `kexec_file_load` worked
    fine when `kexec_load` didn't; there shouldn't be any difference for
    non-secure boot kernels, as far as I can tell. What was seen, however,
    was that when taking a KVM dump in the failure case, the memory that
    stored the initramfs had differences compared to what was on disk. It's
    unknown what caused these differences.
    
    As a workaround (and as a bit of a feature enhancement), use the `-a`
    flag with kexec, which tells it to use `kexec_file_load` if available,
    and `kexec_load` if it's not available or otherwise fails. armhf doesn't
    support `kexec_file_load`, whereas arm64 gained support for
    `kexec_file_load` in the 5.19 kernel (we're currently on 5.10). `amd64`
    has supported `kexec_file_load` since 3.17. This also makes it possible
    to do kexec on secure boot systems, where the kernel image must be
    loaded via `kexec_file_load`.
    
    Signed-off-by: Saikrishna Arcot <[email protected]>
    
    Signed-off-by: Saikrishna Arcot <[email protected]>
    saiarcot895 authored and yxieca committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    cf12bb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Revert "Convert IPv6 addresses to lowercase in apply-patch (#2299)" (…

    …#2758)
    
    This reverts commit 28b6ba5.
    
    
    There are some issues when GCU tries to remove the interface IP in some tests, such as add rack test.
    
    In the initial config, the INTERFACE's IPv6 was all loaded in uppercase by default.
    
        "INTERFACE": {
            "Ethernet68": {},
            "Ethernet68|10.0.0.34/31": {},
            "Ethernet68|FC00::45/126": {},
            "Ethernet72": {},
            "Ethernet72|10.0.0.36/31": {},
            "Ethernet72|FC00::49/126": {},
    GCU will never be able to remove that IP because IPv6 was always translated to lowercase due to #2299 . It reported the error can't remove a non-existent object, thus making GCU fail.
    
    #2299  is to deal with this issue: sonic-net/sonic-buildimage#11622.
    
    Although config CLI always translates uppercase to lowercase when adding an IP, the user can have two choices to remove that IP: One is to use config CLI to remove that IP no matter uppercase or lowercase. Another way is to use GCU. In order to use GCU, the user has to check the IP format saved in ConfigDB because GCU operation does differentiate between uppercase and lowercase.
    #### What I did
    Revert #2299
    wen587 authored and yxieca committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    fe224f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. [GCU] Prohibit removal of PFC_WD POLL_INTERVAL field (#2777)

    What I did
    -Add new infrastructure to GCU for validation of moves that YANG models are unable to capture
    -Prohibit deletion of PFC_WD POLL_INTERVAL field
    
    How I did it
    Ensure JSON Diff does not have POLL_INTERVAL deletion
    If diff reflects request for POLL_INTERVAL deletion, raise an Exception and do not allow patch application to go through
    How to verify it
    Attempt to delete POLL_INTERVAL field using GCU
    isabelmsft authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    eb2d916 View commit details
    Browse the repository at this point in the history
  2. [voq] Add fabric_ns to the ns_list when display_option is DISPLAY_ALL…

    …. (#2717)
    
    The get_ns_list_based_on_options function only gets front_ns and back_ns in current code.
    This change adds fabric_ns in the ns_list when display_option is DISPLAY_ALL. This enables the fabric related tests on voq chassis, e.g the change in sonic-net/sonic-mgmt#6620
    jfeng-arista authored and yxieca committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f9f3e7e View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Use sonic-swss-common artifacts from the matching source branch (#2783)

    Signed-off-by: Saikrishna Arcot <[email protected]>
    saiarcot895 authored and yxieca committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    ea1d849 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. [route_check] fix IPv6 address handling (#2799)

    BACKPORT of #2722
    
    What I did
    In case user has configured an IPv6 address on an interface in CONFIG DB in non simplified form like 2000:31:0:0::1/64 it is present in a simplified form in ASIC_DB. This leads to route_check failure since it just compares strings.
    
    How I did it
    Convert prefix string using ip_network().
    
    How to verify it
    UT replicates the issue.
    
    Signed-off-by: Stepan Blyschak <[email protected]>
    stepanblyschak authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    fdea806 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Configuration menu
    Copy the full SHA
    98dadce View commit details
    Browse the repository at this point in the history
  2. Fixed a bug in "show vnet routes all" causing screen overrun. (#2644)…

    … (#2801)
    
    Signed-off-by: siqbal1486 <[email protected]>
    siqbal1986 authored Apr 19, 2023
    Configuration menu
    Copy the full SHA
    2410d36 View commit details
    Browse the repository at this point in the history
  3. [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM comman…

    …ds for fabric cards (#2606)
    
    Signed-off-by: Sakthivadivu Saravanaraj [email protected]
    
    What I did
    When we run generate_dump script in SFM cards in a Broadcom chassis, the errors were printed in syslog for all the Broadcom commands which are not supported in fabric/Ramon cards. Added a check to dump all l2, l3, fp and tm commands only if the switch_type is non fabric card since these commands are not valid for fabric cards.
    
    How I did it
    Get the switch_type from DEVICE_METADATA and check the switch_type before dumping these BCM commands.
    
    How to verify it
    Ran generate_dump script in both voq and fabric cards, (1)verified that the fabric cards don't log the errors for the BCM commands (2) verified that the commands are dumped correctly in non-fabric dnx cards.
    Signed-off-by: Sakthivadivu Saravanaraj <[email protected]>
    Signed-off-by: saksarav <[email protected]>
    saksarav-nokia authored and yxieca committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a5199f7 View commit details
    Browse the repository at this point in the history
  4. Support to display the SONiC OS Version in the command show version (…

    …#2787)
    
    What I did
    Support to display the SONiC OS Version in the command show version.
    It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version.
    
    SONiC Software Version: SONiC.master-13812.218661-7d94c0c28
    SONiC OS Version: 11
    Distribution: Debian 11.6
    Kernel: 5.10.0-18-2-amd64
    How I did it
    The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601
    The submodule change can be merged to sonic-buildimage, after the PR 14601 merged.
    
    How to verify it
    xumia authored and yxieca committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    3a880a2 View commit details
    Browse the repository at this point in the history
  5. Remove the no use new line in show version (#2792)

    What I did
    Remove the additional new line in the command show version, the new line character is no use.
    
    SONiC Software Version: SONiC.master-14619.252155-d7c9d3b7d
    
    SONiC OS Version: 11
    Distribution: Debian 11.6
    Change to:
    
    SONiC Software Version: SONiC.master-14619.252155-d7c9d3b7d
    SONiC OS Version: 11
    Distribution: Debian 11.6
    How I did it
    How to verify it
    xumia authored and yxieca committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7d16b18 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Revert "[GCU] Add PFC_WD RDMA validator (#2781)"

    This reverts commit 98dadce.
    yxieca committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ece22b7 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. [202205][DBMigrator] Update db_migrator to support EdgeZoneAggregator…

    … Buffer Config for T0s (#2769)
    
    * EZA buffer addition to 202205 branch
    
    * moved code change to common migrator
    
    * Update sample-t0-edgezoneagg-config-output.json
    
    * Update sample-t0-edgezoneagg-config-same-cable-output.json
    developfast authored Apr 25, 2023
    Configuration menu
    Copy the full SHA
    47f8499 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Configuration menu
    Copy the full SHA
    506dd7a View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. [GCU] protect loopback0 from deletion (#2638) (#2813)

    What I did
    Refer to sonic-net/sonic-buildimage#11171, protect loopback0 from deletion
    
    How I did it
    Add patch checker to fail the validation when remove loopback0
    
    How to verify it
    Unit test
    wen587 authored May 1, 2023
    Configuration menu
    Copy the full SHA
    6c400c4 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. [GCU] Add vlanintf-validator (#2697)

    What I did
    Fix the bug of GCU vlan interface modification. It should call ip neigh flush dev after removing interface ip.
    The fix is basically following config CLI's tradition.
    
    How I did it
    Add vlanintf service validator to check if extra step of ip neigh flush is needed.
    
    How to verify it
    GCU E2E test in dualtor testbed.
    wen587 authored and yxieca committed May 4, 2023
    Configuration menu
    Copy the full SHA
    79c9971 View commit details
    Browse the repository at this point in the history
  2. Fix bug in GCU vlanintf_validator (#2765)

    What I did
    Fix the bug in vlanintf_validator
    
    How I did it
    ret will be 0 if success. Fix the statement.
    
    How to verify it
    E2E test
    wen587 authored and yxieca committed May 4, 2023
    Configuration menu
    Copy the full SHA
    a8455fd View commit details
    Browse the repository at this point in the history
  3. [config]config reload should generate sysinfo if missing (#2778)

    What I did
    Missing platform and mac in CONFIG_DB will result in container failure. We should make the config reload generate those info if missing.
    
    How I did it
    Add missing sys info if config_db.json doesn't contain it.
    
    How to verify it
    Unit test
    wen587 authored and yxieca committed May 4, 2023
    Configuration menu
    Copy the full SHA
    6b5bf99 View commit details
    Browse the repository at this point in the history
  4. [show][muxcable] fix show mux hwmode muxdirection RC (#2812)

    What I did
    show mux hwmode muxdirection always has rc==1.
    
    Fixed the issue below:
    
    get_grpc_cached_version_mux_direction_per_port has reverted TRUE/FALSE return value compared to get_hwmode_mux_direction_port. The former is used to get results for active-active ports, the latter is used to get results for active-standby ports.
    Use sys.exit() instead of return rc. CLI rc is different from function return value.
    Fixed show mux grpc muxdirection as well.
    sign-off: Jing Zhang
    
    How to verify it
    Tested on DUTs to verify rc. Run commands for single port and all ports, with and without --json.
    Passed all UTs.
    zjswhhh authored and yxieca committed May 4, 2023
    Configuration menu
    Copy the full SHA
    2e9c99e View commit details
    Browse the repository at this point in the history
  5. Change default CDB run mode to non-hitless (#2817)

    * Change default CDB run mode to non-hitless
    
    Signed-off-by: Mihir Patel <[email protected]>
    
    * Improved diff coverage
    
    ---------
    
    Signed-off-by: Mihir Patel <[email protected]>
    mihirpat1 authored and yxieca committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b49d78c View commit details
    Browse the repository at this point in the history
  6. [acl-loader] Only add default deny rule when table is L3 or L3V6 (#27…

    …96) (#2826)
    
    What I did
    1. Update acl-loader to only add default deny rule when table is L3 or L3V6.
    2. Update unittest to cover it.
    
    How I did it
    Update function deny_rule and return {} if table is not L3 or L3V6.
    
    How to verify it
    1. Update unittest and run all testcases to verify.
    2. Built the package and installed on DUT to verify.
    
    Signed-off-by: Zhijian Li <[email protected]>
    lizhijianrd authored May 4, 2023
    Configuration menu
    Copy the full SHA
    f6359bc View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Added platform plugin support in load_minigraph (#2808) (#2831)

    Added platform plugin hook to execute platform script after minigraph config is loaded in config db and before starting the services. Cherry-pick of master PR:sonic-net/sonic-utilities#2808
    anamehra authored May 8, 2023
    Configuration menu
    Copy the full SHA
    8adaa02 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. [config]: Dynamically start and stop ndppd (#2814)

    - When enabling proxy_arp for a VLAN, configure and start the ndppd service if it isn't already running
    - When removing the last VLAN, stop the ndppd service
    
    Signed-off-by: Lawrence Lee <[email protected]>
    theasianpianist authored and yxieca committed May 11, 2023
    Configuration menu
    Copy the full SHA
    6268309 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. [config]Support multi-asic Golden Config override with fix (sonic-net#4)

    Resolve conflict and cherry pick sonic-utilities #2825
    wen587 authored May 16, 2023
    Configuration menu
    Copy the full SHA
    c72ddaf View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Update TRANSCEIVER_INFO table after CDB FW upgrade (#2837)

    * Update TRANSCEIVER_INFO table after CDB FW upgrade
    
    Signed-off-by: Mihir Patel <[email protected]>
    
    * Added testcases to improve code coverage
    
    ---------
    
    Signed-off-by: Mihir Patel <[email protected]>
    mihirpat1 authored and yxieca committed May 17, 2023
    Configuration menu
    Copy the full SHA
    3053371 View commit details
    Browse the repository at this point in the history
  2. LAG keepalive script to reduce lacp session wait during warm-reboot (…

    …#2806)
    
    A new mechanism is added here to to reduce LAG flap issue during hitless upgrades.
    
    Problem being solved:
    During warm upgrades T0 goes down and with that wait time for LACP session starts.
    If the waittime to refresh LACP session is > 90s then T1 initiates LAG teardown, and as a result dataplane impact is seen.
    This script makes sure that LACPDUs are sent in the going down path continuously.
    
    How time is saved w/ this mechanism:
    
    The lacpsession wait period earlier used to start from when teamd container goes down.
    New lacpsession wait period starts when kexec in current kernel is issued, and new kernel boots up.
    
    Implementation:
    When warm-reboot starts, capture LACPDUs sent from all LAG member ports.
    For this allow 60s of prep + collection time.
    Start sending LACPDUs w/ ~1s interval.
    The last LACPDU is sent after all containers are down and kexec is issued.
    
    Results:
    Tested this on different platforms and images. Some results for time saved:
    
    BRCM: 201811 -> 202012 --- 18s
    BRCM: 202012 -> 202012 --- 20s
    MLNX: 201911 -> 202205 --- 10s
    MLNX: 202205 -> 202205 --- 10s
    vaibhavhd authored and yxieca committed May 17, 2023
    Configuration menu
    Copy the full SHA
    e2f0f2c View commit details
    Browse the repository at this point in the history
  3. [GCU]Fix rdma check failure (#2824)

    What I did
    if substring.isdigit() and re.match(r'^\d{8}$', substring): In this version check, it only applies to this pattern: 20220531.XXX. It will fail the master and other build check. For example, master.261851-010dc3957 is a master build_version string. It will fail version validation and return failure.
    
    My thought to remove the check is that GCU is only supported in 202205 and later. Either branch_version >= "20201200" or branch_version >= "20181100" is already satisfied.
    
    How I did it
    Remove redundant check in GCU RDMA validator
    
    How to verify it
    Unit test
    wen587 authored and yxieca committed May 17, 2023
    Configuration menu
    Copy the full SHA
    14b2150 View commit details
    Browse the repository at this point in the history
  4. correctly parsing complete ipv6 vnet info (#2827)

    cisco sonic router will hit below error message from route_check
    str3-8101-02 ERR monit[519]: 'routeCheck' status failed (255) –
    Failure results: sonic-net#12 "Unaccounted_ROUTE_ENTRY_TABLE_entries": sonic-net#12 "fddd:a150:a0::a66:1/128",sonic-net#12 "fddd:a150:a0::a67:1/128",sonic-net#12 "fddd:a150:a0::a71:1/128",sonic-net#12 "fddd:a150:a0::a78:1/128",sonic-net#12 "fddd:a150:a0::a80:1/128"sonic-net#12
    sonic-net#12#012Failed. Look at reported mismatches above#012add: []#012del: []
    
    the parser will only cut the chars before : regardless it is the IPv6 format.
    For instance,
    route_check: "fddd:a150:a0::a21:1/128
    Will be parsed as “fddd" ONLY
    Vnet_v6_in_v4-0: : a150:a0::a21:1/128"
    solution:
    fix the parsing scheme on route check when APPL_DB refers IPv6 format.
    yenlu-keith authored and yxieca committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d98033f View commit details
    Browse the repository at this point in the history
  5. Fix the invalid variable issue when set-fips in uboot (#2834)

    What I did
    Reproduce the issue:
    
    /home/admin# sonic-installer set-fips
    Command: /usr/bin/fw_setenv linuxargs net.ifnames=0 loopfstype=squashfs loop=image-20220531.27/fs.squashfs systemd.unified_cgroup_hierarchy=0 varlog_size=4096 loglevel=4 sonic_fips=1
    Error: illegal character '=' in variable name "loopfstype=squashfs"
    
    Work item tracking
    Microsoft ADO (number only): 22333116
    How I did it
    Add the double quotation marks when calling the command.
    
    How to verify it
    It works fine when calling the following command:
    /usr/bin/fw_setenv linuxargs "net.ifnames=0 loopfstype=squashfs loop=image-20220531.27/fs.squashfs systemd.unified_cgroup_hierarchy=0 varlog_size=4096 loglevel=4 sonic_fips=1"
    xumia authored and yxieca committed May 17, 2023
    Configuration menu
    Copy the full SHA
    ff26d90 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    673564e View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#5 from gechiang/202205

    [Manual Sync] From sonic-net/sonic-utilities 202205 to Azure/sonic-utitities.msft repo
    gechiang authored May 25, 2023
    Configuration menu
    Copy the full SHA
    3dabc06 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Fix the show interface counters throwing exception on device with no …

    …external interfaces (#2851)
    
    Cherry-pick of PR:sonic-net/sonic-utilities#2703
    
    Signed-off-by: Abhishek Dosi <[email protected]>
    abdosi authored May 26, 2023
    Configuration menu
    Copy the full SHA
    77b725c View commit details
    Browse the repository at this point in the history
  2. Update pcieutil error message on loading common pcie module (#2786)

    * Update pcieutil load module error message
    
    * Add pcieutil test for load module warning to not print to output
    
    * Update pcieutil import test
    
    * Update pcieutil import test
    
    * Fix pcieutil import test
    cytsao1 authored and yxieca committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4b96bd7 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    377e404 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#6 from mssonicbld/sonicbld/202205-merge

    Merge code from sonic-utilities/202205
    gechiang authored May 30, 2023
    Configuration menu
    Copy the full SHA
    a35b227 View commit details
    Browse the repository at this point in the history
  3. [show][muxcable] add some new commands health, reset-cause, queue_inf…

    …o support for muxcable (#2853)
    
    * [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (#2414)
    
    This PR adds the support for adding some utility commands for muxacble
    This includes commands for health, operationtime, queueinfo, resetcause
    
    vdahiya@sonic:~$ show mux health Ethernet4
    PORT          ATTR               HEALTH
    ---------     ---------------   --------
    Ethernet4     health_check       Ok
    vdahiya@sonic:~$ show mux health Ethernet4 --json
    {
        "health_check": "Ok"
    }
    
    vdahiya@sonic:~$ show mux operation Ethernet4 --json
    {
        "operation_time": "22:22"
    }
    vdahiya@sonic:~$ show mux operation Ethernet4
    PORT       ATTR              OPERATION_TIME
    ---------  --------------  ----------------
    Ethernet4  operation_time                 22:22
    vdahiya@sonic:~$
    
    vdahiya@sonic:~$ show mux resetcause Ethernet4
    PORT       ATTR           RESETCAUSE
    ---------  -----------  ------------
    Ethernet4  reset_cause             0
    
    vdahiya@sonic:~$ show mux resetcause Ethernet4 --json
    {
        "reset_cause": "0"
    }
    
    vdahiya@sonic:~$ show mux queueinfo Ethernet4 --json
    {
        "Remote": "{'VSC': {'r_ptr': 0, 'w_ptr': 0, 'total_count': 0, 'free_count': 0, 'buff_addr': 0, 'node_size': 0}, 'UART1': {'r_ptr': 0, 'w_ptr': 0, 'total_count': 0, 'free_count': 0, 'buff_addr': 209870, 'node_size': 1682183}, 'UART2': {'r_ptr': 13262, 'w_ptr': 3, 'total_count': 0, 'free_count': 0, 'buff_addr': 12, 'node_size': 0}}",
        "Local": "{'VSC': {'r_ptr': 0, 'w_ptr': 0, 'total_count': 0, 'free_count': 0, 'buff_addr': 0, 'node_size': 0}, 'UART1': {'r_ptr': 0, 'w_ptr': 0, 'total_count': 0, 'free_count': 0, 'buff_addr': 209870, 'node_size': 1682183}, 'UART2': {'r_ptr': 13262, 'w_ptr': 3, 'total_count': 0, 'free_count': 0, 'buff_addr': 12, 'node_size': 0}}"
    }
    
    
    Signed-off-by: vaibhav dahiya <[email protected]>
    vdahiya12 authored May 30, 2023
    Configuration menu
    Copy the full SHA
    cd08aa6 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Configuration menu
    Copy the full SHA
    b26b917 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#7 from mssonicbld/sonicbld/202205-merge

    Merge code from sonic-utilities/202205
    gechiang authored May 31, 2023
    Configuration menu
    Copy the full SHA
    d65f6e2 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. [db-migrator] Fix hwsku match for 6100 and add errors when hwsku is N…

    …one (#2821)
    
    * Fix hwsku match for 6100 and add errors when hwsku is None
    
    * Asic type fix
    vaibhavhd authored and yxieca committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    051f28c View commit details
    Browse the repository at this point in the history
  2. [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (#2…

    …852)
    
    What I did
    Fix this issue: sonic-net/sonic-buildimage#15047
    Show dhcp_relay ipv6 counter will display vlan which has been deleted.
    
    How I did it
    Remove related info in state_db while deleting a vlan
    
    How to verify it
    Add unit test
    Build utilities and run cmd to verify
    
    Signed-off-by: Yaqiang Zhu <[email protected]>
    yaqiangz authored and yxieca committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    d1f4413 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Configuration menu
    Copy the full SHA
    ec47214 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. [202205][config]Support multi-asic Golden Config override with fix (#…

    …2825) (#2862)
    
    ADO: 17746282
    
    Support multi-asic Golden Config Override with fix based on sonic-net/sonic-utilities#2738
    Add ConfigMgmt support for ASIC validation. Modify override config cli to support multi-asic.
    Unit test:
    ```
    tests/config_override_test.py::TestConfigOverrideMultiasic::test_macsec_override PASSED [  8%]
    tests/config_override_test.py::TestConfigOverrideMultiasic::test_device_metadata_table_rm PASSED [  8%]
    ```
    wen587 authored Jun 6, 2023
    Configuration menu
    Copy the full SHA
    75ca81e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Add display support for serial field in show chassis modules status C…

    …LI (#2858)
    
    Add display support for serial field in show chassis modules status CLI
    amulyan7 authored and yxieca committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    0b87808 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf90d4d View commit details
    Browse the repository at this point in the history
  3. Merge pull request sonic-net#8 from mssonicbld/sonicbld/202205-merge

    Merge code from sonic-utilities/202205
    mssonicbld authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    542411b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Update portstat (#2877)

    wenyiz2021 authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    24d0d1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    499378c View commit details
    Browse the repository at this point in the history
  3. Merge pull request sonic-net#9 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e7b4125 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. [config] Generate sysinfo as needed when override config (#2836)

    ADO: 17921518
    
    What I did
    The generated Golden Config will not have knowledge of configs that are produced in run time, such as mac and platform.
    Generate that info in Override Config if missing.
    
    How I did it
    Reuse the mac and platform in existing device runnning config and generate that if missing.
    
    How to verify it
    Unit test
    wen587 authored and yxieca committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e42291b View commit details
    Browse the repository at this point in the history
  2. [config] Generate sysinfo in single asic (#2856)

    What I did
    It is a bug introduced from #2836. Need to generate sysinfo for single asic.
    
    How I did it
    Reuse the mac and platform in existing device runnning config and generate that if missing.
    
    How to verify it
    Unit test
    wen587 authored and yxieca committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e7eac6b View commit details
    Browse the repository at this point in the history
  3. Revert "[config]config reload should generate sysinfo if missing (#27…

    …78)" (#2865)
    
    This reverts commit 88ffb16.
    wen587 authored and yxieca committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e0333b5 View commit details
    Browse the repository at this point in the history
  4. [dhcp-relay] Fix dhcp6relay counter issue (#2866)

    Why I did
    While deleting a Vlan, clear dhcpv6_relay counter info state_db before dhcp_relay container restart would cause that counter info still exist in state_db, which is incorrect.
    Microsoft ADO number: 24211173
    
    How I did it
    Clear counter info in state_db after container restart.
    
    How to verify it
    Previous ut and build image to verify.
    
    Signed-off-by: Yaqiang Zhu <[email protected]>
    yaqiangz authored and yxieca committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    43c85ef View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    3bd6b3c View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#10 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    b7c9a1d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. [chassis]: remote cli commands infra for sonic chassis (#2850)

    What I did
    Microsoft ADO 17792956
    
    Since each Linecard is running an independent SONiC Instance, the user needs to login to a linecard to run any CLI command
    The user can login to each Linecard 2 ways
    
    Ssh directly to the linecard using the management IP address
    Ssh to supervisor and from supervisor ssh to the Linecard using the Linecard’s internal IP address
    To simplify the user experience and allow scripting agents to execute commands on all linecards.
    Two new commands are being added
    rexec <linecard_name|all> -c <cli_command> This command will execute the command on specified linecards or all linecards.
    
    rshell <linecard_name> connects to the linecard for interactive shell
    
    This PR is adding the changes of PR #2701
    
    How to verify it
    UT and tested chassis
    
    Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
    arlakshm authored and root committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    bf48061 View commit details
    Browse the repository at this point in the history
  2. [chassis][voq[Add "config fabric port ..." commands and tests. (#2730)

    Added "config fabric port ..." commands and the tests.
    
    This change added following config commands and the test for them.
    
    config fabric port isolate #portId#
    config fabric port unisolate #portId#
    The above two commands can be used to manually isolate and unisolate a fabric link.
    
    config fabric port monitor error threshold #crcCells# #rxCells#
    It sets a fabric link monitoring error threshold
    
    config fabric port monitor poll threshold isolation #pollnumber#
    It sets the number of consecutive polls in which the threshold needs to be detected to isolate a link
    
    config fabric port monitor poll threshold recovery #pollnumber#
    It sets the number of consecutive polls in which no error is detected to unisolate a link
    jfeng-arista authored and root committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    29b26b9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request sonic-net#11 from gechiang/202205

    [202205 Chassis-Cherry-pick] Pick Up 2 PRs from sonic-net/sonic-utilities for chassis specific needs (2730), (2850)
    gechiang authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    78c2a15 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. [202205][db_migrator] Add migration of FLEX_COUNTER_DELAY_STATUS duri…

    …ng 1911->2211 upgrade + fast-reboot. Add UT. (#2870)
    
    What I did
    Add migration of FLEX_COUNTER_DELAY_STATUS attribute of config_db FLEX_COUNTER_TABLE during the SONiC to SONiC upgrade + fast-reboot from older versions 201911 -> 202205.
    
    This change is required for the fast-reboot procedure because without it the counters will be created during the init flow which will waste a lot of resources and cause data plane degradation of more than 30 seconds.
    
    How I did it
    Modify the db_migrator.py.
    
    How to verify it
    Add UT.
    
    Signed-off-by: vadymhlushko-mlnx <[email protected]>
    vadymhlushko-mlnx authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    1787410 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d01c03 View commit details
    Browse the repository at this point in the history
  3. Merge pull request sonic-net#12 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b7c78cb View commit details
    Browse the repository at this point in the history
  4. [GCU Feature Update] Cherry-pick Platform Validator PR to 202205 (#2883)

    * [GCU] Complete RDMA Platform Validator PR (#2857)
    Cherry-pick PR 2692, 2818, and 2857 to 202205
    isabelmsft authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    436ecb0 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. Configuration menu
    Copy the full SHA
    7b18000 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#13 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jun 24, 2023
    Configuration menu
    Copy the full SHA
    2fb0432 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. [chassis][multi asic] change acl_loader to use tcp socket for db comm…

    …unication (#2525)
    
    Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
    
    Microsoft ADO 24363637
    
    What I did
    Currently on multi asic platform the acl-loader script connects to all the db in the namespaces using unix sockets.
    This cause permission errors when executing show acl commands for user with RO privileges.
    To avoid this change the acl-loader to use tcp socket to connect to db in namespaces
    
    How I did it
    update acl-loader
    
    How to verify it
    UT
    Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
    arlakshm authored and yxieca committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    517ba4d View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    f0cf040 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#14 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    029dbe0 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    b932092 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Configuration menu
    Copy the full SHA
    11ed0f3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#15 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b6ea3e3 View commit details
    Browse the repository at this point in the history
  3. [db_migrator] Remove hardcoded config and migrate config from minigra…

    …ph (#2887)
    
    Microsoft ADO: 18217044
    
    This PR is follow up to an old PR: #2515
    
    This PR addresses two issues:
    
    Not migrating RESTAPI, TELEMETRY, DEVICE_METADATA entries if they are not supported in target image's minigraph.py.
    Not migrating these entries if minigraph.xml file is missing.
    Not maintaining the config for these tables in two different places. Currently db migrator has its own constants, and minigraph.py maintains its own.
    How I did it
    This change removes hardcoding config in migrator code, and migrating the config for RESTAPI, TELEMETRY, DEVICE_METADATA from minigraph generator.
    
    How to verify it
    Tested on a physical device.
    vaibhavhd authored and yxieca committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0ea47b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Configuration menu
    Copy the full SHA
    054a8b9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#16 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    b4fb0e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Revert "[GCU Feature Update] Cherry-pick Platform Validator PR to 202…

    …205 (#2883)" (#2908)
    
    This reverts commit 436ecb0.
    isabelmsft authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    20853a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Configuration menu
    Copy the full SHA
    e2547d1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#17 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ad65cf1 View commit details
    Browse the repository at this point in the history
  3. [route_check][dualtor] Ignore vlan neighbor route miss (#2888)

    What I did
    As the subject.
    This PR is to leave the vlan neighbor route checking to dualtor_neighbor_check.py script: #2840
    
    Signed-off-by: Longxiang Lyu [email protected]
    
    How I did it
    If any misses are found on dualtor, ignore those vlan neighbor misses.
    
    How to verify it
    UT and verify on testbed.
    lolyu authored and yxieca committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d89d483 View commit details
    Browse the repository at this point in the history
  4. [dualtor][route_check] filter out soc_ipv6 (#2899)

    What I did
    Skip soc_ipv6 when comparing appl_db and asic_db route entries on active-active dualtor. Because it's creating false alarms when tunnel route is added for soc ips. The route is meant to be programmed in asic only.
    
    sign-off: Jing Zhang [email protected]
    
    How I did it
    How to verify it
    Run the updated script on active-active dualtor devices.
    zjswhhh authored and yxieca committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    24fc1db View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58db48a View commit details
    Browse the repository at this point in the history
  6. Add FEC correctable and uncorrectable port stats (#2027)

    * Add FEC correctable and uncorrectable port stats
    
    Signed-off-by: Prince George <[email protected]>
    
    * fix pytest failures
    
    Signed-off-by: Prince George <[email protected]>
    
    * fix pytest failure
    
    * Added separate command for fec stats
    
    * Fix test failure
    
    * Fix LGTM warning
    
    * Improve code coveraged
    prgeor authored and yxieca committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    bc7c792 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    e77f559 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#18 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    5c7f8ca View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. [202205] Flush RESTAPI db in fast-reboot shutdown path (#2921)

    * Flush RESTAPI db in fast-reboot shutdown path
    bingwang-ms authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    0c6d0c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. [show][muxcable] update show mux config to print out soc_ipv6 as …

    …well (#2909)
    
    Update `show mux config` to print soc_ipv6 as well if it exists. 
    
    sign-off: Jing Zhang [email protected]
    zjswhhh authored and yxieca committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a32ddc1 View commit details
    Browse the repository at this point in the history
  2. [dualtor] Add script to verify consistency between kernel and ASIC (#…

    …2840)
    
    #### What I did
    Add script `dualtor_neighbor_check.py` to verify the neighbor consistency
    based on the mux state. It will have the following output:
    ```
    NEIGHBOR       MAC                PORT        MUX_STATE    IN_MUX_TOGGLE    NEIGHBOR_IN_ASIC    TUNNERL_IN_ASIC    HWSTATUS
    -------------  -----------------  ----------  -----------  ---------------  ------------------  -----------------  ----------
    192.168.0.2    ee:86:d8:46:7d:01  Ethernet4   standby      False            no                  yes                consistent
    192.168.0.3    86:73:c2:22:bf:02  Ethernet8   standby      False            no                  yes                consistent
    192.168.0.24   56:a6:bf:c5:dd:17  Ethernet92  active       False            yes                 no                 consistent
    192.168.0.25   3a:18:56:f5:02:18  Ethernet96  active       False            yes                 no                 consistent
    192.168.0.100  00:00:00:00:00:00  N/A         N/A          N/A              no                  yes                consistent
    ```
    
    Signed-off-by: Longxiang Lyu <[email protected]>
    
    #### How I did it
    the workflow of this scripts:
    1. for non-zero-mac neighbors in `APPL_DB` `NEIGH_TABLE`, use the `ASIC_DB` fdb entries to find the mux port that it belongs to.
    2. check if the neighbor is consistent with mux state:
        * if mux state is `active`, the neighbor is consistent only if the neighbor is present in `ASIC_DB` but no tunnel route.
        * if mux state is `standby`, the neighbor is consistent only if the tunnel route is present in `ASIC_DB`1 but no neighbor.
    3. if there are any inconsistent neighbors and the mux port is currently in-toggle, the script will have a non-zero negative return, and will write error messages to logs.
    
    
    #### How to verify it
    UT and verify on testbed.
    
    #### Previous command output (if the output of a command-line utility has changed)
    
    #### New command output (if the output of a command-line utility has changed)
    lolyu authored and yxieca committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    9986464 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f14ee2 View commit details
    Browse the repository at this point in the history
  4. Merge pull request sonic-net#19 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0a38fe4 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. [db_migrator] Set docker_routing_config_mode to the value obtained fr…

    …om minigraph parser (#2890) (#2922)
    
    MSFT ADO: 24419953
    
    This is to fix a bug where warm upgrade from old image (eg. 20181130) to new image (eg. 202012) does not update docker_routing_config_mode to the new config expected the target OS.
    
    For eg., in 201811 DEVICE_METADATA.localhost.docker_routing_config_mode is set to unified.
    After upgrade to 202012 the value is not changed. However, the expectation in newer images is that the value is separated.
    
    The move from unified to separated was done as part of an old change: sonic-net/sonic-buildimage#2961
    
    However, migration logic was not updated since then. Because of this miss, cross-branch warm-upgrade from 201811 to 2020212 to 202305 to latest will always keep the setting as unified.
    
    How I did it
    Added a common migration logic: update docker_routing_config_mode to the value from minigraph parser.
    
    How to verify it
    Added a new unit test. Updated old unit tests.
    vaibhavhd authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    bef3ffe View commit details
    Browse the repository at this point in the history
  2. [multi-asic] Refine [override config table] for corner cases (#2918)

    Handle corner case for multi-asics:
    1. when golden config file is empty for multi-asic case
    2. when config format is incorrect for multi-asics, e.g. localhost or namespace is missing in golden config db
    wenyiz2021 authored and yxieca committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    4c6af3c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    69d348d View commit details
    Browse the repository at this point in the history
  4. UT change: for db_migrator test do not check for RESTAPI cert values …

    …(#2919)
    
    What I did
    MSFT ADO: 24598790
    
    Why:
    RESTAPI table has certs generated from minigraph parser.
    The values in RESTAPI table (cert and key names) are dependent on how they are hardcoded in minigraph parser.
    Current solution works on public repo, but breaks the internal build (different naming).
    
    What:
    Do not match values for RESTAPI attributes. The test still ensures that missing table and keys are migrated.
    
    How I did it
    How to verify it
    vaibhavhd authored and yxieca committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0f001c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Configuration menu
    Copy the full SHA
    661193f View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#20 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    32a5b1d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. clear: Fix clear queuecounters to also clear VOQ counters (#2879)

    The `sonic-clear queuecounters` command does not currently clear VOQ
    counters. Fix it and add a unit test to verify that the VOQ counters
    were actually cleared.
    
    The unit test changes required some updates to the VOQ counters tests,
    because on an actual DUT the VOQ counter uses fully-qualified
    interface names (dut|asic|port) whereas the queue counters just use
    the port name. The unit tests had kept the names the same but this
    meant that the saved counters for VOQ and non-VOQ counters would
    overwrite each other when the counters were cleared during the unit
    tests. Qualify the interface names used in the VOQ unit tests to avoid
    this.
    patrickmacarthur authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    56a1ae2 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Configuration menu
    Copy the full SHA
    eec809a View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#21 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bfb0112 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. [Chassis][Voq] Clear fabric counters queue/port (#2892)

    What I did
    This PR is a clone of #2789.
    
    Added two clear commands for fabric counters queue and fabric counters port.
    
    sonic-clear fabriccountersport
    sonic-clear fabriccountersqueue
    Fabric counters are cleared and saved with these two commands. For example,
    
    # show fabric counters port
      ASIC    PORT    STATE    IN_CELL    IN_OCTET    OUT_CELL    OUT_OCTET    CRC    FEC_CORRECTABLE    FEC_UNCORRECTABLE    SYMBOL_ERR
    ------  ------  -------  ---------  ----------  ----------  -----------  -----  -----------------  -------------------  ----------
    ...
         0      49       up          1         244           0            0       0                  2        2,372,752,496               0
         0      50       up          2         315           1          135       0                  4        2,522,457,120               4
    ...
    # sonic-clear fabriccountersport
    Clear and update saved counters port
    # show fabric counters port
      ASIC    PORT    STATE    IN_CELL    IN_OCTET    OUT_CELL    OUT_OCTET    CRC    FEC_CORRECTABLE    FEC_UNCORRECTABLE    SYMBOL_ERR
    ------  ------  -------  ---------  ----------  ----------  -----------  -----  -----------------  -------------------  ------------
    ...
        0      49       up          0           0           0            0      0                  0                    0             0
        0      50       up          0           0           0            0      0                  0                    0      
    
    Co-authored-by: Qi Luo <[email protected]>
    Co-authored-by: Jie Feng <[email protected]>
    3 people authored and root committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    49bb94d View commit details
    Browse the repository at this point in the history
  2. Fix in config override when all asic namespaces not present in golden…

    …_config_db (#2946)
    
    #### What I did
    Fixes sonic-net/sonic-buildimage#16164
    
    #### How I did it
    In the multi-asic devices for eg: supervisor card of a chassis, the asics are not of its own -- it is the asic present in the fabric cards in the chassis. On then -- all the fabric cards need not be present in the chassis everytime.
    
    In that case golden_config_db.json file generated by NDM ( based on the Subdevices in the minigraph ) will not have all ASICs -- it will be for the fabric cards present in the chassis  
    
    With the current logic, if there is an asic namespace missing -- config load_minigraph will exit with error as in the Issue #sonic-net/sonic-buildimage#16164 and not restart dockers.
    
    Add logic to check and continue if the "asic" namespace is not present in the golden_config_db.json for multi-asic platforms.
    
    #### How to verify it
    Verified on a SUP
    
    ```
    admin@str2-xxxx-sup-1:~$ sudo config load_minigraph -y --override_config 
    Disabling container monitoring ...
    Stopping SONiC target ...
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json   --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic0 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic1 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic2 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic3 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic4 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic5 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic6 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic7 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic8 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic9 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic10 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic11 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic12 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic13 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic14 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -H -m -j /etc/sonic/init_cfg.json  -n asic15 --write-to-db
    Running command: /usr/local/bin/sonic-cfggen -d -y /etc/sonic/sonic_version.yml -t /usr/share/sonic/templates/sonic-environment.j2,/etc/sonic/sonic-environment
    Running command: config qos reload --no-dynamic-buffer --no-delay
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/0/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/1/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/2/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/3/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/4/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/5/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/6/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/7/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/8/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/9/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/10/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/11/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/12/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/13/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/14/buffers.json.j2
    Buffer definition template not found at /usr/share/sonic/device/x86_64-nokia_ixrxxxxe_sup-r0/Nokia-IXRxxxxE-SUP-10/15/buffers.json.j2
    Running command: pfcwd start_default
    Running command: config override-config-table /etc/sonic/golden_config_db.json
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Override config not present for asic1                                   <<<<<<<<<<<<<<<<<<<<<
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Removing configDB overriden table first ...
    Overriding input config to configDB ...
    Overriding completed. No service is restarted.
    Override config not present for asic14                          <<<<<<<<<<<<<<<<<<<<<
    Override config not present for asic15                          <<<<<<<<<<<<<<<<<<<<<
    Restarting SONiC target ...
    Enabling container monitoring ...
    Reloading Monit configuration ...
    Reinitializing monit daemon
    
    ```
    judyjoseph authored and yxieca committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ba32772 View commit details
    Browse the repository at this point in the history
  3. Add transceiver status CLI to show output from TRANSCEIVER_STATUS tab…

    …le (cherry-pick to 202205) (#2950)
    
    * Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (#2772)
    
    * Correct Command-Reference.md
    
    * Use double quote
    longhuan-cisco authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1ed5b5a View commit details
    Browse the repository at this point in the history
  4. Merge pull request sonic-net#22 from gechiang/202205

    [Chassis][Voq] Clear fabric counters queue/port (#2892)
    gechiang authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1353492 View commit details
    Browse the repository at this point in the history
  5. [chassis] rexec enhancements(#2935)

    Microsoft ADO 24703217
    
    What I did
    In this PR the following enhancements are done
    
    Add support for user to pass username
    Add support to login to all linecards before executing any commands
    How I did it
    How to verify it
    UT and chassis
    arlakshm authored and root committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    543be01 View commit details
    Browse the repository at this point in the history
  6. Merge pull request sonic-net#23 from gechiang/202205

    [chassis] rexec enhancements(#2935)
    gechiang authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c422c10 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    fdf101a View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#24 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    69f4c71 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Configuration menu
    Copy the full SHA
    c4d2c47 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Merge pull request sonic-net#25 from Azure/revert-22-202205

    Revert "[Chassis][Voq] Clear fabric counters queue/port (#2892)"
    gechiang authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ac9bd53 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    4c91f77 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. [Techsupport] Update the message seen during the lock acquisition fai…

    …lure (#2897)
    
    #### What I did
    
    When a second techsupport instance starts while one is running, the message thrown before exiting is not very user friendly. Thus updating the message for it to make more sense.
    vivekrnv authored and yxieca committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    627a2f5 View commit details
    Browse the repository at this point in the history
  2. Fix show acl table for masic (#2937)

    What I did
    Fixes sonic-net/sonic-buildimage#16012
    The show acl table command currently get the ports from host config_db on multi asic platforms.
    This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the show acl table not to display the phyiscal ports in the output on multi asic devices/linecards.
    
    The test iface_namingmode/test_iface_namingmode.py::test_show_acl_table fails because of this issue.
    arlakshm authored and yxieca committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    03292ff View commit details
    Browse the repository at this point in the history
  3. Remove SFP index usage in generating list of SFP hw error (#2961)

    * Remove SFP index usage in generating list of SFP hw error
    
    * Consider case with multiple logical port map to same physical port
    
    * Added test case
    prgeor authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    787b4a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    dc55f21 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#27 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    387b980 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Added support of queue non zero counter option

    Signed-off-by: Abhishek Dosi <[email protected]>
    abdosi committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    3f0d455 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merge pull request sonic-net#28 from abdosi/202205

    [202205-msft] Added support to display nonzero Queue Counters.
    abdosi authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    66ea58a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. [sonic-package-manager] Increate timeout for sonic-package-manager mi…

    …grate (#2973)
    
    What I did
    When we migrate package via sonic-package-manager in some low-performance device, getting docker image from old image via docker socket may timeout by default timeout setting (60s) client.py. This PR is to increase timeout to 120s.
    
    How I did it
    Increase docker client timeout from 60s to 120s.
    
    How to verify it
    ut passed.
    Build image with INCLUDE_MACSEC, and install it, macsec image was not include. And the build image with this PR, install it. Migrate package successfully.
    
    Signed-off-by: Yaqiang Zhu <[email protected]>
    yaqiangz authored and yxieca committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4bf29fe View commit details
    Browse the repository at this point in the history
  2. Handle NotImplementedError exception while changing optoe write max (…

    …#2985)
    
    * Handle NotImplementedError exception while changing optoe write max
    
    Signed-off-by: Mihir Patel <[email protected]>
    
    * Added unit test for more coverage
    
    * Removed unused import
    
    ---------
    
    Signed-off-by: Mihir Patel <[email protected]>
    mihirpat1 authored and yxieca committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d9bc820 View commit details
    Browse the repository at this point in the history
  3. Merge pull request sonic-net#26 from jfeng-arista/202205-clear-fabric…

    …-counters
    
    Clear fabric counters queue/port
    gechiang authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8cf9817 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    7df1c6b View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#29 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    75030e0 View commit details
    Browse the repository at this point in the history
  3. mmuconfig to set threshold for profiles master#2775

    Signed-off-by: Alpesh S Patel <[email protected]>
    alpeshspatel committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    44dbfde View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Merge pull request sonic-net#30 from alpeshspatel/alpeshspatel/util.m…

    …sft.202205.mmuconfig
    
    What I did
    Extended the mmuconfig utility with a "-s / --staticth" keyword to configure the threshold configured via pg_profile_lookup.ini
    The utility had ability to configure "-a/alpha" for dynamic threshold
    abdosi authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ceced56 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. [202205][acl-loader] Identity ICMP v4/v6 based on IP_PROTOCOL for cus…

    …tom ACL table types (#3003)
    
    * [acl-loader] Identity ICMP v4/v6 based on IP_PROTOCOL for custom ACL table types (#2994)
    
    What is the motivation for this PR?
    When adding ICMPv6 ACL rules in custom ACL table type, current acl-loader will incorrectly treat the ACL table as IPv4. I open this PR to fix this bug and let acl-loader identify ICMP v4 or v6 based on IP_PROTOCOL.
    Also fixed some typo in UT of acl-loader to avoid confusion.
    
    How did you do it?
    In function convert_icmp, add one step to identify the rule is v4 or v6 based on IP_PROTOCOL.
    
    How did you verify/test it?
    Verified by UT.
    
    Signed-off-by: Zhijian Li <[email protected]>
    
    * update
    
    ---------
    
    Signed-off-by: Zhijian Li <[email protected]>
    lizhijianrd authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ff8a064 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Configuration menu
    Copy the full SHA
    bb5123d View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#31 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    c4dcb32 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Include /var/log.tmpfs in techsupport (#2979)

    Signed-off-by: Mihir Patel <[email protected]>
    mihirpat1 authored and yxieca committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    0ad458c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27cea9f View commit details
    Browse the repository at this point in the history
  3. Merge pull request sonic-net#32 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Oct 14, 2023
    Configuration menu
    Copy the full SHA
    b97d75e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. [dualtor_neighbor_check] Adjust zero-mac check condition (#3034)

    * [dualtor_neighbor_check] Adjust zero-mac check condition
    lolyu authored and yxieca committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5d3c563 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Configuration menu
    Copy the full SHA
    d61c2a3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#33 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities:202205 to 202205
    mssonicbld authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    189ea52 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. [GCU Bug Fix] Cherry-pick RDMA Platform Validator PR to 202205 (#3051)

    Cherry-pick PR #2692 (set up test infrastructure used in later PR 2857), #2857 (platform validator PR), #2913 (edge case fix), #2951, #3018 (add support for new Mellanox HwSKU in conf file)
    This change stops GCU from modifying a protected RDMA field.
    
    Signed-off-by: Stephen Sun <[email protected]>
    Co-authored-by: Stephen Sun <[email protected]>
    isabelmsft and stephenxs authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8765fce View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Configuration menu
    Copy the full SHA
    4b52394 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#35 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities.msft:202205 to 202205
    mssonicbld authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0bf2af5 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    4463875 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. [DPB] Remove the optimization logic for delete/add ports. (#2463)

    * Fix port breakout issue
    
    * Address comments
    
    * fix LGTM alerts
    aravindmani-1 authored and mssonicbld committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f5f9a85 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge pull request sonic-net#39 from deepak-singhal0408/deepsinghal/e…

    …nhance_route_check_masic
    
    What I did
    Enhanced route_check.py script to cover multi-asic platforms.
    Accordingly enhanced the test files as well.
    Master Branch PR: sonic-net/sonic-utilities#3077
    
    MSFT ADO: 25416673
    
    How I did it
    Enhanced the route_check.py script to take additional optional parameter(--n/namespace). Without this parameter, the check will be run on all asics in multi-asic platforms.
    Different connections to DBs are modified accordingly to connect to relevant ns dbs.
    Result will be encapsulated under different namespace. For single asic, results will be displayed under Default-Namespace("").
    
    testData and the testfiles are enhanced accordinly.
    rlhui authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    89f62d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2024

  1. [chassis]: Support show ip bgp summary to display without error when …

    …no external neighbors are configured on chassis LC (#3099)
    
    Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC
    arlakshm authored and gechiang committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    ee2c12e View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#40 from gechiang/202205

    [chassis]: Support show ip bgp summary to display without error when …
    gechiang authored Jan 6, 2024
    Configuration menu
    Copy the full SHA
    7dc1a54 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. [202205] Allow using latest sonic-swss-common build even if tests fai…

    …led (#3127)
    
    The current 202205 branch build of sonic-swss-common has failing test
    cases. This is blocking sonic-utilities, since this is the only build
    available in that branch.
    
    Allow using that build even though tests are failing, to unblock PRs in
    this repo.
    
    Signed-off-by: Saikrishna Arcot <[email protected]>
    saiarcot895 authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    bef96a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. [config] config reload should generate sysinfo if missing (#3031) (#3…

    …126)
    
    What I did
    Missing platform and mac in CONFIG_DB will result in container failure. We should make the config reload generate those info if missing.
    
    How I did it
    Add missing sys info if config_db.json doesn't contain it.
    
    How to verify it
    Unit test
    wen587 authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    06d1133 View commit details
    Browse the repository at this point in the history
  2. Fix issue: out of range sflow polling interval is accepted and stored…

    … in config_db (#2847) (#3123)
    
    Fixed issue: out of range sflow polling interval is accepted and stored in config_db.
    
    Reproduce step:
    ```
    1. Enable sflow feature:   config feature state sflow enabled
    2. Enable sflow itself:   config sflow enable
    3. Configure out of range polling interval:  config sflow polling-interval 1. Error message is shown as expected
    4. Save config:    config save -y
    5. Check "SFLOW" section inside config_db
    ```
    
    As the interval is invalid, the expected behavior is that the interval is not saved to redis. But we see the invalid value was written to redis.
    
    Change `click.echo` to `ctx.fail`
    
    1. Manual test
    2. Add a check in existing unit test case to cover the change
    
    Co-authored-by: Junchao-Mellanox <[email protected]>
    stephenxs and Junchao-Mellanox authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7a7305e View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. [202205] Add teamd retry count script to 202205 image (#3116)

    * Add teamd retry count script to 202205 image
    
    This backports a part of #3069 to allow upgrading from 202205 to 202305
    with the teamd retry count feature.
    
    Signed-off-by: Saikrishna Arcot <[email protected]>
    saiarcot895 authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    241f9cc View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Added change to not return error for Sonic t2/spine-router role

    when config bgp shut/startup command given for BGP Neighbor if the given
    neighbor are not present. This is done because for T2 BGP neighbors are
    present across different LC's so it's possible when command is executed
    that neighbor might not be present on that LC
    
    Signed-off-by: Abhishek Dosi <[email protected]>
    abdosi committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    49d9087 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#41 from abdosi/202205

    [202205-msft] Added change to not return error for Sonic t2/spine-router role when config bgp shutdown/startup is given
    gechiang authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9099585 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. [chassis] fix show bgp summary when no neighbors are present on one A…

    …SIC (#3158)
    
    This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this.
    
    How I did it
    Add check in bgp_util to create empty peer list only once
    Add UT to cover this case
    arlakshm authored and gechiang committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8bd6327 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#42 from gechiang/202205

    [chassis] fix show bgp summary when no neighbors are present on one ASIC (#3158)
    gechiang authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    2242e5a View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    b80fbdf View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#44 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities.msft:202205 to 202205
    mssonicbld authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6535704 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. [show] Update show run all to cover all asic config in multiasic (#3148)

    * [show] Update show run all to cover all asic config in masic
    
    * per comment
    wen587 authored and gechiang committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f068356 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#45 from gechiang/202205

    [show] Update show run all to cover all asic config in multiasic (#3148)
    gechiang authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a364953 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    e573439 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#49 from gechiang/ghc-202205

    [show] multi-asic show running test residue (#3198)
    gechiang authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2b86126 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    724178c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    39316e4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#52 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities.msft:202205 to 202205
    mssonicbld authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c6ac555 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. T2-VOQ-VS: Modified exception handling due to new sonic_platform pack…

    …age support for VS (#3250)
    
    ### What I did
    For T2-Chassis VS support, we are adding new sonic_platform package for vs platforms. Please refer sonic-net/sonic-buildimage#18512 for more details.
    Due to this new platform package, need to modify excpetion handling as now the Module would be found, but the metadata file will not be found for pizzabox vs platforms.
    
    #### How I did it
    Modified the exception handling logic.
    MSFT ADO: 27414904
    
    #### How to verify it
    Bring up vms-kvm-t0 topology. ran show interface status. The output is proper.
    
    PS: the Main PR(sonic-net/sonic-buildimage#18512) is dependent on this PR to be merged in first.
    deepak-singhal0408 authored and gechiang committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    49c32d0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#61 from gechiang/202205

    T2-VOQ-VS: Modified exception handling due to new sonic_platform pack…
    gechiang authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    26f49f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    bbc154a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Merge pull request sonic-net#64 from xincunli-sonic/xincun/gcu-multiasic

    Add Multi ASIC support for apply-patch
    gechiang authored Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8d815da View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. [chassis][midplane] Add notification to Supervisor when LC is gracefu…

    …l reboot (#3292)
    
    * [chassis][midplane] Add notification to Supervisor when LC is graceful reboot
    
    * Address review comment by adding log message when failed to create wentry in CHASSIS_STATE_DB
    
    Signed-off-by: mlok <[email protected]>
    mlok-nokia authored and gechiang committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5449b6c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    f8e347e View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#70 from wen587/show_run_587

    [show] Show running config when bgp is down
    gechiang authored May 30, 2024
    Configuration menu
    Copy the full SHA
    dec2418 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Import Patch

    xincunli-sonic committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    07ff07a View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#71 from xincunli-sonic/xincun/fix-patch

    Import Patch to fix build break from PR (sonic-net#64)
    gechiang authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ad9dc50 View commit details
    Browse the repository at this point in the history
  3. Fix build error

    xincunli-sonic committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    eb44b6b View commit details
    Browse the repository at this point in the history
  4. Merge pull request sonic-net#72 from xincunli-sonic/xincun/fix-build-…

    …error
    
    Fix build error
    gechiang authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    72df294 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    6742ebe View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#69 from gechiang/202205

    [chassis][midplane] Add notification to Supervisor when LC is gracefu…
    gechiang authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    9c26b65 View commit details
    Browse the repository at this point in the history
  3. Update for the procedures for insertion/hot swap of Switch Fabric Mod…

    …ule(SFM) by using "config chassis modules shutdown/startup" commands (#3283)
    
    sudo config chassis modules shutdown/startup <module name>
    
    The HLD for Shutdown and Startup of the Fabric Module is below:
    sonic-net/SONiC#1694
    JunhongMao authored and gechiang committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    5388cb4 View commit details
    Browse the repository at this point in the history
  4. Merge pull request sonic-net#73 from gechiang/202205

    Update for the procedures for insertion/hot swap of Switch Fabric Mod…
    gechiang authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    af721c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. [build] Fix base OS compilation issue caused by incompatibility betwe…

    …en urllib3 and requests packages (#3328) (#3355)
    
    Co-authored-by: Oleksandr Ivantsiv <[email protected]>
    volodymyrsamotiy and oleksandrivantsiv authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8e71e65 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    e5ba06c View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#74 from mssonicbld/sonicbld/202205-merge

    [code sync] Merge code from sonic-net/sonic-utilities.msft:202205 to 202205
    mssonicbld authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a9d7b12 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. [chassis][show-runningconfig] Fix the show runningconfiguration all i…

    …ssue on the Supervisor (#3194)
    
    Signed-off-by: mlok <[email protected]>
    mlok-nokia authored and gechiang committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    79cb599 View commit details
    Browse the repository at this point in the history
  2. Merge pull request sonic-net#76 from gechiang/202205

    [chassis][show-runningconfig] Fix the show runningconfiguration all i…
    gechiang authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    47415b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Add full configuration validation. (#3316)

    #### What I did
    
    Before apply the json patch, we will precheck and simulate-patch the payload in entire box level.
    
    #### How I did it
    
    1. Add Duplication check
    2. JSON patch structure validating
    3. Simulating patch to full configuration
    4. Verifying simulating result match YANG validation.
    
    #### How to verify it
    
    1. Single ASIC
    
    ```
    admin@str2-msn2700-spy-2:~/gcu$ cat empty.json
    []
    admin@str2-msn2700-spy-2:~/gcu$ sudo config apply-patch empty.json
    Patch Applier: localhost: Patch application starting.
    Patch Applier: localhost: Patch: []
    Patch Applier: localhost getting current config db.
    Patch Applier: localhost: simulating the target full config after applying the patch.
    Patch Applier: localhost: validating all JsonPatch operations are permitted on the specified fields
    Patch Applier: localhost: validating target config does not have empty tables,
                                   since they do not show up in ConfigDb.
    Patch Applier: localhost: sorting patch updates.
    Patch Applier: The localhost patch was converted into 0 changes.
    Patch Applier: localhost: applying 0 changes in order.
    Patch Applier: localhost: verifying patch updates are reflected on ConfigDB.
    Patch Applier: localhost patch application completed.
    Patch applied successfully.
    ```
    
    2. Multi ASIC
    
    ```
    stli@str2-7250-2-lc01:~/gcu$ cat empty.json
    []
    stli@str2-7250-2-lc01:~/gcu$ sudo config apply-patch empty.json
    sonic_yang(6):Note: Below table(s) have no YANG models: DHCP_SERVER, KUBERNETES_MASTER
    sonic_yang(6):Note: Below table(s) have no YANG models: KUBERNETES_MASTER
    sonic_yang(6):Note: Below table(s) have no YANG models: KUBERNETES_MASTER
    Patch Applier: localhost: Patch application starting.
    Patch Applier: localhost: Patch: []
    Patch Applier: localhost getting current config db.
    Patch Applier: localhost: simulating the target full config after applying the patch.
    Patch Applier: localhost: validating all JsonPatch operations are permitted on the specified fields
    Patch Applier: localhost: validating target config does not have empty tables,
                                   since they do not show up in ConfigDb.
    Patch Applier: localhost: sorting patch updates.
    Patch Applier: The localhost patch was converted into 0 changes.
    Patch Applier: localhost: applying 0 changes in order.
    Patch Applier: localhost: verifying patch updates are reflected on ConfigDB.
    Patch Applier: localhost patch application completed.
    Patch Applier: asic0: Patch application starting.
    Patch Applier: asic0: Patch: []
    Patch Applier: asic0 getting current config db.
    Patch Applier: asic0: simulating the target full config after applying the patch.
    Patch Applier: asic0: validating all JsonPatch operations are permitted on the specified fields
    Patch Applier: asic0: validating target config does not have empty tables,
                                   since they do not show up in ConfigDb.
    Patch Applier: asic0: sorting patch updates.
    Patch Applier: The asic0 patch was converted into 0 changes.
    Patch Applier: asic0: applying 0 changes in order.
    Patch Applier: asic0: verifying patch updates are reflected on ConfigDB.
    Patch Applier: asic0 patch application completed.
    Patch Applier: asic1: Patch application starting.
    Patch Applier: asic1: Patch: []
    Patch Applier: asic1 getting current config db.
    Patch Applier: asic1: simulating the target full config after applying the patch.
    Patch Applier: asic1: validating all JsonPatch operations are permitted on the specified fields
    Patch Applier: asic1: validating target config does not have empty tables,
                                   since they do not show up in ConfigDb.
    Patch Applier: asic1: sorting patch updates.
    Patch Applier: The asic1 patch was converted into 0 changes.
    Patch Applier: asic1: applying 0 changes in order.
    Patch Applier: asic1: verifying patch updates are reflected on ConfigDB.
    Patch Applier: asic1 patch application completed.
    Patch applied successfully.
    ```
    xincunli-sonic committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    90fd38f View commit details
    Browse the repository at this point in the history
  2. Cherry pick 3299

    xincunli-sonic committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    621fc64 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Add missing import

    xincunli-sonic committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c643f68 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge pull request sonic-net#77 from xincunli-sonic/xincun/cherry-pic…

    …k-3316-and-3299
    
    Cherry pick 3316 and 3299
    gechiang authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8157142 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Configuration menu
    Copy the full SHA
    cc5acba View commit details
    Browse the repository at this point in the history