Skip unnumbered BGP neighbors instead of failing #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasstockner
force-pushed
the
skip-unnumbered-bgp-neighbor
branch
from
24e509b
to
863d26d
Compare
Signed-off-by: Lukas Stockner <[email protected]>
lukasstockner
force-pushed
the
skip-unnumbered-bgp-neighbor
branch
from
863d26d
to
842fbaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Handle ValueError when trying to parse the IP of a BGP neighbor.
In case unnumbered BGP is used,
neigh_strwill be an interface name, which can't be represented in this MIB. So instead of failing, just skip the neighbor.- How I did it
Catch
ValueError, continue.- How to verify it
- Description for the changelog
Skip unnumbered BGP neighbors instead of failing