Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding flex counter to wrong context #1421

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Sep 18, 2024

  1. Fix adding flex counter to wrong context

    The counters for syncd (switch chip) were attempted to be added to
    gbsyncd (gearbox phys), and vice versa.
    This issue is introduced by
    sonic-net#1362
    When setting the redis attribute
    SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER_GROUP and
    SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER, the operation is applied to every
    contexts (both syncd and gbsyncd). However, the counters to initialize
    could only exist in one context.
    
    The fix is to check that the target switch id exists in the context; if
    not, skip the operation.
    byu343 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8639ace View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fix formatting

    byu343 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0c0ae57 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Fix to pass the test SyncdMlnxTest.portBulkAddRemove

    Normally, setting SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER_GROUP and
    SAI_REDIS_SWITCH_ATTR_FLEX_COUNTER should provide a valid switch id
    and the setting is only applied to the context with the switch id.
    Fall back to loop all contexts if SAI_NULL_OBJECT_ID is provided.
    byu343 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    28eb780 View commit details
    Browse the repository at this point in the history