Update GNMI design #2
Conversation
| update { | ||
| path { | ||
| origin: "sonic_db" | ||
| elem {name: "DPU0"} elem {name: "APPL_DB"} elem {name: "DASH_ACL_RULE_TABLE"} elem {name: "group1:3"} |
There was a problem hiding this comment.
If DPU0 is not specified, can it be defaulted to 'localhost'?
| 2. The first element is device name, and it should be one of the following values: `localhost`, `DPU0`, `DPU1`, ..., `DPUx` | ||
| 3. The second element is SONiC database name, and it should be `APPL_DB` for DASH API | ||
| 4. The third element is table name, please refer to [DASH APP DB](https://github.com/sonic-net/DASH/blob/main/documentation/general/dash-sonic-hld.md#32-dash-app-db) | ||
| 5. The fourth element is table key. For example, in the `DASH_ACL_RULE_TABLE`, the table key consists of two fields: `group_id` and `rule_num`. These fields are separated by a colon `:` in the APPL_DB. Therefore, the fourth element would be `group1:3` |
There was a problem hiding this comment.
i thought the fourth element should be part ofthe protobuf definition. it should not be part of the path. @qiluo-msft
There was a problem hiding this comment.
GNMI delete operation only has path, and it does not have value. So, there's no protobuf in GNMI delete operation.
https://github.com/openconfig/gnmi/blob/master/proto/gnmi/gnmi.proto#L337
There was a problem hiding this comment.
i thought protobuf has the key already defined. then you need to state how would people know how to form a key for a specific table. https://github.com/sonic-net/sonic-dash-api/blob/master/proto/eni.proto#L38
| 1. GNMI path will have 4 elements, please refer to the above example | ||
| 2. The first element is device name, and it should be one of the following values: `localhost`, `DPU0`, `DPU1`, ..., `DPUx` | ||
| 3. The second element is SONiC database name, and it should be `APPL_DB` for DASH API | ||
| 4. The third element is table name, please refer to [DASH APP DB](https://github.com/sonic-net/DASH/blob/main/documentation/general/dash-sonic-hld.md#32-dash-app-db) |
There was a problem hiding this comment.
this needs to be self-contained, the table name should be refered in this repo. do not refer to dash doc.
|
overall order needs to be changed as well, we should first talk about gnmi, then protobuf, last one is redis db. I do not really think people care about redis db, that is implementation, people care about gnmi and protobuf. we should not talk gnmi at the end. |
Explain GNMI path and value for DASH API.