Silicon config support for Broadcom yml file and property overwrite

[geans-pin]

Module name	PR	State
sonic-buildimage	Common Config Update
sonic-sairedis	Modify syncd script to support yml

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: geans-pin / name: 賓少鈺 (a65543a, 45aa3e0, 3678e95, 7f344a4, effd3cd, 1c69d91)

[ZhaohuiS]

@geans-pin
After last meeting, we have the following comments for the new design:

• Add flag/option to allow vendor's config.bcm to override common (current behavior), but it could support to common config.bcm to override vendor's config.bcm to give better control.

First, we extract the common attributes from platform config.bcm. If it's a common config for all HWSKUs of one type of ASIC, we have to remove it from platform specific config.bcm and only keep it in common config.bcm,

It could give us a better control that we can just modify one place to sync one config change for all related HWSKUs, don't have to update platform specific config.bcm one by one.

Second, since this a huge change for config.bcm which is critical file for SAI, could you please cover how to do unit test in this design doc? Unit test is quite important to make sure config.bcm is consistent after this feature.

• could you please consider .j2 format for common config.bcm? Support to add the logic for some specific HwSku or other scenarios?

[geans-pin]

Fix review comments :

1. Add #section to control property level overwrite in common config
2. ADD mode UT cases

[ZhaohuiS]

Should TD4, TH4 or TH5's common file be ***.config.yml file?

[geans-pin]

It's fine to use the same naming in common file. Only the TH5/TH4/TD4 targeted platform and merged config is yml based.

Geans

[geans-pin]

ZhaohuiS,

I've committed the changes for HLD review comment. You can check and verify. Fox example as the following,
the properties in the [Overwrite Section] will overwrite the platform config.

[Overwrite Section]
l3_mem_entries=16384
lpm_scaling_enable=0
l3_alpm_enable=0

sonic-net/sonic-sairedis#1411

Geans

[ZhaohuiS]

ZhaohuiS,

I've committed the changes for HLD review comment. You can check and verify. Fox example as the following, the properties in the [Overwrite Section] will overwrite the platform config.

[Overwrite Section] l3_mem_entries=16384 lpm_scaling_enable=0 l3_alpm_enable=0

sonic-net/sonic-sairedis#1411

Geans

@geans-pin sorry to miss your latest commit, I have several comments, could you please take a look? thanks