Improve readability of sai_api_gen.py for SAI header file generation. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-pritsak
approved these changes
Dec 8, 2023
|
Reorganized sections to more easily see the hierarchy and become more obvious. Much easier changes in the future; for this one no functionality will change, all produced files will remain unchanged. |
r12f
added a commit
to r12f/DASH
that referenced
this pull request
Dec 8, 2023
…sonic-net#470) * temp checkin. * temp checkin. * Update SAI to reference. * table data parser. * DASH API set object. * minor update. * Table keys and types. * table action and param. * fix v4_or_v6 fields. * Simplify template based file generation code. * Revert to current SAI * SAI Generator. * Fix header generation issues. * Fix lib generation issue. * Fix ignored tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will not change any generated SAI header files but only update the sai_api_gen.py file for better readability.
After this change, all header files are lib files are output with the exactly the same format:
SAI folder:
Lib:
